[Desktop] Tor tab loses connection to Internet

[hollons]

Description

When you open a tor window from a private window, and then close the private window, the tor window looses it's internet connection.

Steps to Reproduce

1. Launch brave
2. Open a new private window
3. Open a new private window with Tor
4. Close the private window without Tor
5. Then Brave sends the tor daemon SIGTERM.

Actual result:

Tor tab loses connection to internet

Expected result:

Tor tab maintains connection to internet

Reproduces how often:

Brave version (brave://version info)

Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)

Version/Channel Information:

• Can you reproduce this issue with the current release?
  Yes
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the dev channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
  No
• Does the issue resolve itself when disabling Brave Rewards?
  No
• Is the issue reproducible on the latest version of Chrome?
  NA

Miscellaneous Information:

https://www.reddit.com/r/brave_browser/comments/ey2tg7/can_somebody_reproduce_this_problem/

[btlechowski]

Reproduced the issue on Ubuntu and Windows

Brave	1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision	583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS	Ubuntu 18.04 LTS

Brave	1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision	583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS	Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa

[kjozwiak]

Reproduced on macOS 10.15.3 x64 using the following build:

Brave	1.3.111 Chromium: 80.0.3987.85 (Official Build) (64-bit)
Revision	583b05dfa4ffc657f0f7c5cc13f53aa17c9a5bcf-refs/branch-heads/3987@{#791}
OS	macOS Version 10.15.3 (Build 19D76)

@rebron @yrliou is something we want to fix for 1.3.x? Seems like it's occurring in the current release so not a regression. Doesn't seem critical/urgent IMO. We'll need one more 1.3.x build once #8058 starts landing into the other channels so we might have time to include this.

[rebron]

Reproduced too on macOS. Not something we'd block 1.3.x for since it's all related to opening and closing a normal private window. A user can open private window with tor from a normal window without any issue.

[augustoschnorr]

Just installed Brave on Windows. Same problem here.
Brave Version 1.3.115 Chromium: 80.0.3987.87 (Official Build) (64-bit)
Windows Version 10.0.18362 Build 18362

[RuthlessRuler]

Brave on Linux Mint also have this problem.
Brave Version 1.3.118 Chromium: 80.0.3987.116 (Official Build) (64-bit)
Linux Mint - 19.3 XFCE 64-bit

[KIMWW]

Very annoying this issue!!! Then until an update is found shall we downgrade to previous version??

[rebron]

@KIMWW Can you add what version your running now and add the Tor version you're running in brave://components

[rebron]

cc: @riastradh-brave

[NumDeP]

Just came across the same issue @rebron, hope it helps.

Version 1.7.92 Chromium: 80.0.3987.163 (Official Build) (64-bit) (openSuse)

[alwaysharsha]

I have the same issue as well
Using latest version Version 1.9.72 Chromium: 81.0.4044.138 (Official Build) (64-bit)

Tor component details
Brave Tor Client Updater (Windows) - Version: 1.0.11
Status - Up-to-date

[jorgicio]

I'm having this issue since I moved to a deb-based package. I tried with the zip-packaged one and it works, while in deb-packaged not.
Tried with 1.13.86 and 1.14.82.

[bsclifton]

Newer versions should have this fixed, I believe. It might be in 1.15?
cc: @darkdh

[qnxdev]

Having same issue