Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up #7948 Moving of bookmark is not propagated to another device #8065

Closed
btlechowski opened this issue Feb 4, 2020 · 7 comments
Closed

Comments

@btlechowski
Copy link

btlechowski commented Feb 4, 2020

Follow up #7948. The issue still reproduces.

Important: Reproduces on 1.3.110, 1.4.78, 1.5.82. All versions are Chromium 80.

Steps to Reproduce

  1. Clean profile DeviceA and DeviceB
  2. DeviceA: open interia.pl
  3. DeviceA: open youtube.com
  4. DeviceA: create sync chain and copy code words
  5. DeviceB: enter code words
  6. Wait for sync
  7. DeviceA: bookmark interia.pl
  8. DeviceA: bookmark youtube.com
  9. Wait till bookmarks are synced to DeviceB
  10. DeviceA:Move interia.pl after youtube.com bookmark
  11. Wait till the change is propagated to DeviceB

DeviceA: Ubuntu 18.04LTS
DeviceB: Windows 7x64

Actual result:

The moving of bookmark is not propagate to another device
DeviceA
image

DeviceB
image

Expected result:

The moving of the bookmark is always propagated

Reproduces how often:

100% repro rate with above STR

Brave version (brave://version info)

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Ubuntu 18.04 LTS
Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.4.78 Chromium: 80.0.3987.78 (Official Build) dev (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Ubuntu 18.04 LTS
Brave 1.4.78 Chromium: 80.0.3987.78 (Official Build) dev (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 7 Service Pack 1 (Build 7601.24544)
Brave 1.5.82 Chromium: 80.0.3987.78 (Official Build) nightly (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Ubuntu 18.04 LTS
Brave 1.5.82 Chromium: 80.0.3987.78 (Official Build) nightly (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 7 Service Pack 1 (Build 7601.24544)

cc @brave/legacy_qa @jsecretan @AlexeyBarabash @darkdh @rebron

@rebron
Copy link
Collaborator

rebron commented Feb 5, 2020

I was able to reproduce on 1.3.110 Windows 10/macOS 10.15.3
I was also able to reproduce on 1.5.79 Windows 10/macOS 10.15.3 but here first bookmark move propagated, (on macOS first device) second move of same bookmark and a delete of a bookmark wasn't reflected in second device (Win10).

@btlechowski
Copy link
Author

btlechowski commented Feb 5, 2020

According to #7948 (comment), this issue was fixed in 1.5.69, but now I can reproduce it on 1.5.69. Maybe it is a server side issue?

@GeetaSarvadnya
Copy link

Couldn't reproduce the issue in Window 10 x64 - 1.3.110

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified creating folder in both Device A and Device B - folders sync works fine
  • Verified adding bookmarks into folders in both Device A and Device B - BM's sync inside folders works fne
  • Verified deleting folders from Device A and Device B - sync works fine deleted folders removed from both devices.

@darkdh
Copy link
Member

darkdh commented Feb 5, 2020

It was the issue of SQS events couldn't get forwarded.
And now it is fixed so feel free to close the issue if verification passed.

@rebron
Copy link
Collaborator

rebron commented Feb 5, 2020

#8065 (comment) retried after SQS fix and it working properly on 1.3.110 Windows 10 x64 and macOS, following Geeta's steps.

@btlechowski close out if it's working for you now.

@btlechowski
Copy link
Author

Not reproducible anymore

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 1.3.110 Chromium: 80.0.3987.78 (Official Build) (64-bit)
Revision cb5aa81cb0a3a2c674b93bc7ffb34a86cd3b4802-refs/branch-heads/3987@{#752}
OS Windows 7 Service Pack 1 (Build 7601.24544)

@btlechowski
Copy link
Author

The test case is the same as for #7948 so I set this as QA/No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants