Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote debugging should be proxied and enabled by default #7645

Closed
bsclifton opened this issue Jan 7, 2020 · 6 comments · Fixed by brave/brave-core#5500
Closed

Remote debugging should be proxied and enabled by default #7645

bsclifton opened this issue Jan 7, 2020 · 6 comments · Fixed by brave/brave-core#5500
Assignees
Labels
feature/settings priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@bsclifton
Copy link
Member

Background

Starting with Brave v1.2, users can enable the remote debugging option which allows for:

  • service calls to be made out to Google (fetching syntax highlighting data, etc)
  • Lighthouse audits
  • actual remote debugging (connecting to phone, etc)

This setting is in brave://settings/privacy and is DISABLED by default. A more detailed description of this (including the Google network annotation) can be found here:
#7372 (comment)

There is no alert (infobar, etc) when the setting is disabled, so users are left thinking there is a bug

Feature request

  1. The calls made out to Google services for remote debugging should be proxied to remove user identifiable information (ex: IP address)
  2. The Remote Debugging feature should be defaulted to ENABLED

Steps to Reproduce

  1. Fresh profile
  2. Visit https://brave.com
  3. Open developer tools
  4. Go to audit tab
  5. Run Lighthouse audit

Actual result:

It fails and there is no UI notifying you ☹️

If you opened via the command line, you WILL see stdout logging which suggests going to brave://settings/privacy and enabling Remote Debugging

Expected result:

It should just work

Reproduces how often:

100%

cc: @jumde @rebron

@bsclifton bsclifton added priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. feature/settings labels Jan 7, 2020
@jumde jumde self-assigned this Jan 7, 2020
@bsclifton
Copy link
Member Author

per @xPaw via GoogleChrome/lighthouse#9484 (comment)

I have adblock running on my local network, and chrome-devtools-frontend.appspot.com is blocked in AdAway list, whitelisting that has fixed lighthouse for me.

Lighthouse ought to have a proper error message when it's unable to fetch from there.

@jumde
Copy link
Contributor

jumde commented May 5, 2020

Upstream bug is triggered by enabling this: https://bugs.chromium.org/p/chromium/issues/detail?id=1036525.

Work in progress, stay tuned!

@btlechowski
Copy link

btlechowski commented Jun 10, 2020

Verification passed on

Brave 1.10.87 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS Ubuntu 18.04 LTS

Reproduced the original issue on 1.9.80. Lighthouse audit is stuck

image

Verified test plan from brave/brave-core#5500 and description

Verified Remote debugging is turned on in settings
image

Verified Lighthouse audit was successful
image

Verified on clean install and upgrade.
Encountered #9715

Verification PASSED on macOS 10.15.5 Catalina x64 using the following build:

Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.15.5 (Build 19F101)

Reproduced the original issue using 1.9.80 CR: 81.0.4044.138 as per #7645 (comment). Example of Lighthouse audit stalling:

Screen Shot 2020-06-10 at 6 15 41 PM

[40196:775:0610/182439.336577:ERROR:devtools_ui_bindings.cc(18)] Remote debugging is DISABLED. If you want to use it, please enable in brave://settings/privacy
  • verified that Remote Debugging is enabled by default via brave://settings/privacy
  • ensured that Lighthouse audit is being proxies through devtools.brave.com
  • ensured that Lighthouse audit works as expected
  • ensured that Remote Debugging is enabled via brave://settings/privacy when upgrading from 1.9.80 CR: 81.0.4044.138 to 1.10.88 CR: 83.0.4103.97

Screen Shot 2020-06-10 at 10 39 12 PM

Verification passed on


Brave | 1.10.88 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 1803 (Build 17134.1006)

Reproduced the issue in 1.9.80, Lighthouse audit is stuck
image

  • verified that Remote Debugging is enabled by default via brave://settings/privacy
  • ensured that Lighthouse audit is being proxies through devtools.brave.com
  • ensured that Lighthouse audit works as expected
  • ensured that Remote Debugging is enabled via brave://settings/privacy when upgrading from 1.9.80 CR: 81.0.4044.138 to 1.10.88 CR: 83.0.4103.97
    image

@francoism90
Copy link

It would be great if a description could be added for this setting:

image

Does this need a new ticket?

@bsclifton
Copy link
Member Author

@francoism90 I think we're going to remove that setting, as it's now defaulted to on

You can follow #9715 for updates

bsclifton added a commit to brave/brave-core that referenced this issue Jun 29, 2020
- Removes the preference
- Removes from Settings page
- This is on by default and proxied now, thanks to brave/brave-browser#7645

Fixes brave/brave-browser#9715
@0x1eef
Copy link

0x1eef commented Aug 10, 2020

@bsclifton I don't want to use Remote debugging and I would prefer to keep it off. I was surprised to learn this is enabled by default. Anything that allows remote access to my browser (as I understand this feature) is not okay with me and I don't want it on nor do I want to use services that rely on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/settings priority/P3 The next thing for us to work on. It'll ride the trains. privacy/connect This requires making a network connection to a third-party service. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants