Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clicking on Restore account? Import using account seed phrase does nothing #7537

Closed
bsclifton opened this issue Dec 30, 2019 · 37 comments · Fixed by brave/ethereum-remote-client#108
Assignees
Labels
feature/ethereum-remote-client priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include support addition/edits to articles on support website

Comments

@bsclifton
Copy link
Member

bsclifton commented Dec 30, 2019

Description

Reported by @CMEONE here and @paulwaldmann here, it seems even with the latest version of Brave (1.1.23) this is still a problem

Steps to Reproduce

See below report 😄

@bsclifton bsclifton added the feature/web3/wallet Integrating Ethereum+ wallet support label Dec 30, 2019
@paulwaldmann
Copy link

Description

Returning to brave://wallet can't use "import using account seed phrase"

Steps to Reproduce

  1. Go to brave://wallet
  2. Close browser and go back to brave://wallet (so you're logged out and see Welcome Back! screen)
  3. Click "Import using account seed phrase"
  4. Nothing happens, clicking the link has no effect.

Extra note: When I generated the new wallet, during the seed phrase retyping step, the browser crashed, and that's how I encountered the problem to begin with (step 2).

Actual result:

brave_wallet

Expected result:

It should take me to import flow.

Brave version (brave://version)

Version 1.1.23 Chromium: 79.0.3945.88 (Official Build) unknown (64-bit)

@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 3, 2020
@ryanml ryanml self-assigned this Jan 3, 2020
@ryanml
Copy link
Contributor

ryanml commented Jan 3, 2020

Fixed via: https://github.com/brave/devops/pull/2322 cc: @bsclifton

@ryanml ryanml closed this as completed Jan 3, 2020
@ryanml
Copy link
Contributor

ryanml commented Jan 3, 2020

@paulwaldmann thanks for reporting! Restore flow should work correctly now.

@paulwaldmann
Copy link

@ryanml anytime, love Brave and what it stands for!

@paulwaldmann
Copy link

@ryanml when will the changes be pushed to the stable version? I see that the dev version has been updated but the stable 1.1.23 hasn't changed. Thanks.

@ryanml
Copy link
Contributor

ryanml commented Jan 4, 2020

@paulwaldmann there was a networking issue with our JSON RPC, no deployments needed. Are you still seeing the problem? If so, try relaunching Brave. Let me know how that works thank you!

@paulwaldmann
Copy link

Restarted browser and laptop, the problem persists.

@ryanml ryanml reopened this Jan 4, 2020
@ryanml
Copy link
Contributor

ryanml commented Jan 4, 2020

@paulwaldmann got it, apologies. I cannot reproduce but I will continue to look in to this issue.

@ryanml
Copy link
Contributor

ryanml commented Jan 4, 2020

It would be great if you could provide any errors you see in console, if there are any

@paulwaldmann
Copy link

No errors in the console. I've already checked and would have posted it if there were any. If you want, You can join via AnyDesk and have a look by yourself.

@Kevmate
Copy link

Kevmate commented Jan 9, 2020

I am getting the same problem, using latest version. I was creating a wallet, wrote down my passphrase, then on the next screen where you have to select the words I found they were not all on the screen. I couldn't scroll, so I refreshed the page. The words disappeared. After that the page didn't work so I came out and went back in. Now I am asked for a password, which I can remember, but when I continue it just returns to the password prompt. Recovery using phrase also fails. I expect you could reproduce this. We need a way to delete corrupted wallets.

@ryanml
Copy link
Contributor

ryanml commented Jan 9, 2020

Hey folks cc: @Kevmate @paulwaldmann a reset feature is in the works, however, this workaround will suffice in the meantime. (Note this will completely reset everything to how it was the first time you used Crypto Wallets)

Navigate to your Application data directory for Brave, (on MacOS for example it is /Users/your-username/Library/Application Support/BraveSoftware/Brave-Browser). Inside that directory navigate to Default/Local Extension Settings/odbfpeeihdkbihmopkbjmoonfanlbfcl and delete the file 000003.log. Now restart Brave completely, and navigate to brave://wallet. You should see the original welcome screen. (If you restart Brave with that tab open you may need to refresh the page once)

@Kevmate
Copy link

Kevmate commented Jan 10, 2020

Yes, thanks, that removed the corrupt wallet. I haven't created a new one yet, but the fault is cleared :)

@bbondy bbondy added the support addition/edits to articles on support website label Jan 10, 2020
@ryanml
Copy link
Contributor

ryanml commented Jan 15, 2020

Reopening as it has not deployed yet

@ryanml ryanml reopened this Jan 15, 2020
@bbondy
Copy link
Member

bbondy commented Jan 17, 2020

Let's close and move to the project's awaiting deployment column.

@GitNasi
Copy link

GitNasi commented Feb 7, 2020

I have the same issue and cant fix it.
I have followed the steps deleting file 000003.log and restating Brave which led me to the
"KeyringController - No account found on keychain." error while creating a new profile.
After this error I cant do anything but closing Brave again which leads me to the initial problem situation. "Welcome Back!" screen.

Brave is up to date
Version 1.2.43 Chromium: 79.0.3945.130 (Official Build) (64-bit)

Windows 10

@srirambv
Copy link
Contributor

srirambv commented Feb 11, 2020

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Windows 10 OS Version 1803 (Build 17134.523)
Component 0.1.42

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS Linux
Component 0.1.42

Verification passed on

Brave 1.6.14 Chromium: 80.0.3987.87 (Official Build) nightly (64-bit)
Revision 449cb163497b70dbf98d389f54e38e85d4c59b43-refs/branch-heads/3987@{#801}
OS macOS Version 10.15.1 (Build 19B88)
Component 0.1.42

@nonkreon
Copy link

nonkreon commented May 3, 2020

I am still stuck here indefinitely:

image
This is Brave 1.8.86 on Windows 10 1809. Local extension settings folder looks like this (snapshot taken 6:19PM)

image

@bsclifton
Copy link
Member Author

@NejcZdovc ^^

@NejcZdovc
Copy link
Contributor

@nonkreon could you please start browser like this. You can send me logs on nejc[at]brave.com. Thank you

Open the windows command prompt
Change directory with a cd “C:\Program Files (x86)\BraveSoftware\Brave-Browse\Application”
Run the following: brave.exe --enable-logging=stderr --vmodule=*rewards*=6 --v=0 --log-level=1
Copy and paste logs from the command prompt

@nonkreon
Copy link

@nonkreon could you please start browser like this. You can send me logs on nejc[at]brave.com. Thank you

Open the windows command prompt
Change directory with a cd “C:\Program Files (x86)\BraveSoftware\Brave-Browse\Application”
Run the following: brave.exe --enable-logging=stderr --vmodule=*rewards*=6 --v=0 --log-level=1
Copy and paste logs from the command prompt

Thank you for your help @bsclifton and @NejcZdovc , interestingly i got 3 separate log files out of these, i'm putting them all here.
Log0: https://pastebin.com/iuTFs836
Log1: https://pastebin.com/6gWf3hJW
Log2: https://pastebin.com/Wpu085WW
What kind of problem have i gotten myself into 😄

@nonkreon
Copy link

@nonkreon could you please start browser like this. You can send me logs on nejc[at]brave.com. Thank you

Open the windows command prompt
Change directory with a cd “C:\Program Files (x86)\BraveSoftware\Brave-Browse\Application”
Run the following: brave.exe --enable-logging=stderr --vmodule=*rewards*=6 --v=0 --log-level=1
Copy and paste logs from the command prompt

Thank you for your help @bsclifton and @NejcZdovc , interestingly i got 3 separate log files out of these, i'm putting them all here.
Log0: https://pastebin.com/iuTFs836
Log1: https://pastebin.com/6gWf3hJW
Log2: https://pastebin.com/Wpu085WW
What kind of problem have i gotten myself into 😄

@NejcZdovc Brave updated today and it only asked to reauthorize my uphold, everything is set back up now. Thanks for the background fixes!

@NejcZdovc
Copy link
Contributor

@nonkreon great to hear that it was fixed for you

@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/ethereum-remote-client priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include support addition/edits to articles on support website
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants