-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Dapp detection #718
Comments
Would it be possible for us to preload MetaMask, as we do with b-l? We provided a security and blockchain advantage in the market when we shipped with MM pre-installed (and inactive). Recalling when the extension store recently removed the legit MM along with some duplicates - Brave had the advantage and benefit of being able to confirm to our user base (and the public) that our pre-loaded MM extension was authentic and up to date. Also allows for Brave to state that we ship a web3-ready browser. There may be some reason I'm unaware of why it's better not to do this, but mentioning as I found myself looking for MM in the dev channel. |
We never pre-installed metamask, but we just made it really easy to install via the Dapp detection and by having an option directly in settings to download and install it in 1 step. |
When looking at this, please see this issue regarding the integration done with the Muon version of Brave: |
Sub tasks
|
@simonhong we're currently developing a separate cryptocurrency wallet based on MetaMask. The Ðapp-detection should be integrated with that rather than prompting for a separate MetaMask install. |
@tomlowenthal Yup, modified (I know that but forgot to mention about it) :) |
@bbondy could you put together a quick test plan? 😄 |
added test plan |
Verification PASSED on
Verification passed on
Verification passed on
|
Because my previous bug got folded into this one, let me summarize: Detecting 'Installing a Crypto Wallet' by using a getter on window.web3 is inaccurate and misleading to users. For sites like ours, we want to keep track of globals, and something as simple as Object.getOwnPropertyNames(window).forEach(key => window[key]) Triggers this message, which recurs even if a user clicks 'Deny'. It's a product that has nothing to do with crypto and this message is incorrect at least and a problem for user trust. You could:
Or something else. For now we'll have to hardcode a workaround into our app to make it avoid web3. |
@tmcw your previous issue was on muon (legacy browser) Would you mind adding a new issue and we can have that triaged. |
We should give a notification prompt to ask the user to install MetaMask if they visit a Dapp like cryptokitties.
See:
https://github.com/brave/browser-laptop/blob/master/app/browser/reducers/dappReducer.js
Test plan
The text was updated successfully, but these errors were encountered: