Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Contribution button border/edge is shown when wallet balance is zero #6914

Closed
GeetaSarvadnya opened this issue Nov 14, 2019 · 4 comments · Fixed by brave/brave-core#5218

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 14, 2019

Description

Set Contribution button border is shown when wallet balance is zero. Set Contribution button edge needs to be removed.

Steps to Reproduce

  1. Clean profile
  2. Open DDG
  3. Open BR panel
  4. Click on Monthly Contributions button Set...

Actual result:

Set Contribution button border/edge is shown when wallet balance is zero
image

Expected result:

Set Contribution button border is shown when wallet balance is zero. Set Contribution button edge needs to be removed.

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.72.124 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the dev channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @NejcZdovc @brave/legacy_qa

@NejcZdovc
Copy link
Contributor

it overlaps as you can't set monthly contribution if you don't have enough funds. This is not a bug. We have same logic on one time tip

@GeetaSarvadnya GeetaSarvadnya changed the title Not enough tokens message is overlapping on the Set Contribution button in tipping banner Set Contribution button boarder is shown when wallet balance is zero Nov 14, 2019
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Nov 14, 2019

@NejcZdovc Agree with you. changing the subject of the issue. In case of one-time tip, Send Tip button isn't shown completely when wallet balance is zero (as shown in below screenshot)
image

In case of monthly tip Set Contribution button border is shown, that looks odd that should be removed.
image

@GeetaSarvadnya GeetaSarvadnya changed the title Set Contribution button boarder is shown when wallet balance is zero Set Contribution button border/edge is shown when wallet balance is zero Nov 14, 2019
@NejcZdovc NejcZdovc added the priority/P4 Planned work. We expect to get to it "soon". label Nov 14, 2019
@LaurenWags
Copy link
Member

cc @mandar-brave @alexwykoff as this relates to the tipping efficiency changes

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Apr 30, 2020

Verification passed on

Brave 1.9.44 Chromium: 81.0.4044.122 (Official Build) dev (64-bit)
Revision 44f4233f08910d83b146130c1938256a2e05b136-refs/branch-heads/4044@{#963}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave | 1.9.49 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
-- | --
Revision | 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-04-30 at 4 32 24 PM

Verification passed on

Brave 1.9.55 Chromium: 81.0.4044.129 (Official Build) dev (64-bit)
Revision 3d71af9f5704a40b85806f4d08925db24605ba25-refs/branch-heads/4044@{#979}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants