-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect new node modules added to brave-core without a LICENSE #6857
Labels
dev-concern
documentation ✍️
licensing
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
Milestone
Comments
32 tasks
fmarier
added a commit
to brave/brave-core
that referenced
this issue
May 15, 2020
fmarier
added a commit
to brave/brave-core
that referenced
this issue
May 22, 2020
fmarier
added a commit
to brave/brave-core
that referenced
this issue
May 26, 2020
bridiver
pushed a commit
to brave/brave-core
that referenced
this issue
May 27, 2020
fmarier
added a commit
to fmarier/brave-core
that referenced
this issue
Jun 2, 2020
fmarier
added a commit
to brave/brave-core
that referenced
this issue
Jun 4, 2020
Verified passed with
Verification passed on
Verification passed on
|
bbondy
added
OS/Android
Fixes related to Android browser functionality
OS/Desktop
labels
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev-concern
documentation ✍️
licensing
OS/Android
Fixes related to Android browser functionality
OS/Desktop
QA Pass - Android ARM
QA Pass - Android Tab
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/exclude
In order for node module dependencies to show up in
brave://credits
, a developer needs to add aREADME.chromium
inbrave/third_party/
.We could rely on the
brave/third_party/npm_<module name>
pattern and write an automate check which parsesbrave/package.json
and looks for missingbrave/third_party/npm_<module name>
directories.The text was updated successfully, but these errors were encountered: