Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect new node modules added to brave-core without a LICENSE #6857

Closed
fmarier opened this issue Nov 9, 2019 · 2 comments · Fixed by brave/brave-core#5561
Closed

Detect new node modules added to brave-core without a LICENSE #6857

fmarier opened this issue Nov 9, 2019 · 2 comments · Fixed by brave/brave-core#5561

Comments

@fmarier
Copy link
Member

fmarier commented Nov 9, 2019

In order for node module dependencies to show up in brave://credits, a developer needs to add a README.chromium in brave/third_party/.

We could rely on the brave/third_party/npm_<module name> pattern and write an automate check which parses brave/package.json and looks for missing brave/third_party/npm_<module name> directories.

@fmarier fmarier self-assigned this Nov 9, 2019
@fmarier fmarier added this to the 1.12.x - Nightly milestone Jun 5, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jul 17, 2020

Verified passed with

Brave | 1.12.92 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-07-17 at 9 14 01 AM

Screen Shot 2020-07-17 at 9 14 30 AM

Screen Shot 2020-07-17 at 9 14 58 AM


Verification passed on


Brave | 1.12.101 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


Verification passed on

Brave 1.12.102 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

image
image
image

@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 7, 2020
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.12.111 x64 build

  • Verified following credits are listed
array-move parse-domain React Sortable HOC
image image image

Verification passed on Samsung Tab A with Android 10 running 1.12.111 x64 build

  • Verified following credits are listed
array-move parse-domain React Sortable HOC
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment