Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icon for Auto-Contribute disappears when Ads is enabled #6321

Closed
Miyayes opened this issue Oct 5, 2019 · 1 comment · Fixed by brave/brave-core#3741
Closed

Icon for Auto-Contribute disappears when Ads is enabled #6321

Miyayes opened this issue Oct 5, 2019 · 1 comment · Fixed by brave/brave-core#3741
Assignees
@ryanml
Labels
bug feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.2.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 5, 2019

Description

If Ads is enabled but A-C is disabled, then the icon for A-C will disappear.

image

Steps to Reproduce

  1. Go to brave://rewards
  2. Enable Ads
  3. Disable A-C

Reproduces how often:

100% of the time.

Brave version (brave://version info)

Version 0.72.72 Chromium: 77.0.3865.90 (Official Build) nightly (64-bit)
@NejcZdovc NejcZdovc assigned NejcZdovc and ryanml and unassigned NejcZdovc Oct 9, 2019
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Oct 9, 2019
@ryanml ryanml mentioned this issue Oct 18, 2019
Merged
ryanml added a commit to brave/brave-core that referenced this issue Oct 18, 2019
@ryanml
Updates brave-ui to fix broken a-c icon
3555e3c 
Fixes brave/brave-browser#6321
@ryanml ryanml added this to the 0.73.x - Nightly milestone Oct 18, 2019
@ryanml ryanml mentioned this issue Oct 18, 2019
Merged
32 tasks
@LaurenWags
Copy link
Member

LaurenWags commented Nov 20, 2019 •
edited by btlechowski
Loading

Verified passed with

Brave 1.2.5 Chromium: 78.0.3904.97 (Official Build) dev (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description

issue6321

Verification passed on

Brave 1.2.7 Chromium: 78.0.3904.108 (Official Build) dev (64-bit)
Revision 4b26898a39ee037623a72fcfb77279fce0e7d648-refs/branch-heads/3904@{#889}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified STR from the description
    image

Verification passed on

Brave 1.2.6 Chromium: 78.0.3904.97 (Official Build) dev (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified STR from the description

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ryanml ryanml

Labels
bug feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.2.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes broken a-c icon on brave://rewards brave/brave-core
8 participants
@rebron @ryanml @NejcZdovc @Miyayes @srirambv @LaurenWags @btlechowski @GeetaSarvadnya