Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot tweet after inline tipping on reddit #6223

Closed
btlechowski opened this issue Sep 30, 2019 · 2 comments · Fixed by brave/brave-core#3592
Closed

Cannot tweet after inline tipping on reddit #6223

btlechowski opened this issue Sep 30, 2019 · 2 comments · Fixed by brave/brave-core#3592

Comments

@btlechowski
Copy link

btlechowski commented Sep 30, 2019

Cannot tweet after inline tipping on reddit. This is recent regression.

Steps to Reproduce

  1. Clean profile (used staging env)
  2. Enable rewards
  3. Open https://www.reddit.com/user/jsadler-brave
  4. Use inline Tip button on the page
  5. Tweet about the tip

Note: first noticed by @masparrow when working on #5516

Actual result:

Nothing happens, the page to tweet is not shown

Expected result:

the page to tweet is shown
image

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Reproduced on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Not reproducible on Twitter(inline tipping), youtube(https://www.youtube.com/user/JJDSampson) and regular page
This is not linked to publisher being connected as https://www.youtube.com/user/JJDSampson works fine.

Not reproducible on

Brave 0.68.142 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 7 Service Pack 1 (Build 7601.24519)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

cc @brave/legacy_qa @NejcZdovc

@LaurenWags
Copy link
Member

LaurenWags commented Sep 30, 2019

Reproduces with

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Note, with the above version I was still able to tweet about by in-line tip on both Twitter and GitHub, but not Reddit.

Additionally, Reddit in-line tipping issue did not reproduce with below build for me.

Brave 0.68.142 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

@btlechowski
Copy link
Author

btlechowski commented Oct 29, 2019

Verification passed on

Brave 0.72.110 Chromium: 78.0.3904.70 (Official Build) dev (64-bit)
Revision edb9c9f3de0247fd912a77b7f6cae7447f6d3ad5-refs/branch-heads/3904@{#800}
OS Ubuntu 18.04 LTS

Verified STR from the description. Verified new and old reddit. Tested on staging env.

image
image

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from the description
  • Verified in-line tip for Reddit, Twitter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment