Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to 24 hour ad payment token cash ins #5999

Closed
jsecretan opened this issue Sep 12, 2019 · 1 comment · Fixed by brave/brave-core#3511
Closed

Switch to 24 hour ad payment token cash ins #5999

jsecretan opened this issue Sep 12, 2019 · 1 comment · Fixed by brave/brave-core#3511

Comments

@jsecretan
Copy link

Description

Right now, after a user sees ads, the browser will wait an exponentially distributed time averaging 7 days. This was chosen initially to safely keep the two token streams distinct and unlinkable. However, after analysis of a few months of data, our current scale is more than enough to keep these two streams unlinkable even with 24 hour check ins.

There are some tangible benefits to this. This will make sure that tokens are kept protected and accounted server side sooner in the case of client data loss. It will also payouts less confusing because they will more accurately reflect the monthly cycle.

We have run this by @evq and @riastradh-brave to make sure we are good but we should file an official security review issue when this work is complete.

@jsecretan jsecretan added priority/P3 The next thing for us to work on. It'll ride the trains. feature/ads labels Sep 12, 2019
@tmancey tmancey added the QA/Yes label Sep 23, 2019
@tmancey tmancey added this to the 0.72.x - Nightly milestone Sep 23, 2019
tmancey added a commit to brave/brave-core that referenced this issue Sep 24, 2019
@LaurenWags
Copy link
Member

LaurenWags commented Nov 14, 2019

Verified passed with

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Per discussion with @tmancey ,
    • Confirmed on a clean profile that after enabling Rewards, the next_token_redemption_date_in_seconds in confirmations.json was set to be in 24h (confirmed via epochconverter.com)
    • Confirmed on an upgrade profile that after tokens were redeemed/cashed in, the next_token_redemption_date_in_seconds in confirmations.json was set to be in 24h (confirmed via epochconverter.com)

Verification passed on

Brave 1.1.2 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified on a clean profile that after enabling Rewards, the next_token_redemption_date_in_seconds in confirmations.json was set to be in 24h (confirmed via epochconverter.com)
  • Verified on an upgrade profile that after tokens were redeemed/cashed in, the next_token_redemption_date_in_seconds in confirmations.json was set to be in 24h (confirmed via epochconverter.com)

Verification passed on

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified on a clean profile that after enabling Rewards, the next_token_redemption_date_in_seconds in confirmations.json was set to be in 24h (confirmed via epochconverter.com)
  • Verified on an upgrade profile that after tokens were redeemed/cashed in, the next_token_redemption_date_in_seconds in confirmations.json was set to be in 24h (confirmed via epochconverter.com)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants