Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3rd device doesn't show This Device entry in the sync chain #5866

Closed
GeetaSarvadnya opened this issue Sep 3, 2019 · 2 comments · Fixed by brave/brave-core#3328
Closed

3rd device doesn't show This Device entry in the sync chain #5866

GeetaSarvadnya opened this issue Sep 3, 2019 · 2 comments · Fixed by brave/brave-core#3328

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 3, 2019

Description

Found while testing #5770
When three devices are in sync, the 3rd device doesn't show This device entry in the sync chain.

Device

Device A: Beta (0.69.121)
Device B: Dev (0.70.80)
Device C: Nightly (0.71.57)

Steps to Reproduce

  1. Create a sync chain in Device A
  2. Add Device B to sync chain through Sync code
  3. Add Device C to sync chain through Sync code
  4. All the 3 devices listed in the sync chain for both Device A and Device B, But This Device entry isn't listed in Device C

Actual result:

3rd device doesn't show This Device entry in the sync chain

image

Expected result:

All the 3 devices should be displayed in the sync chain for all the three devices

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.71.57 Chromium: 76.0.3809.132 (Official Build) nightly (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@brave/legacy_qa @AlexeyBarabash @darkdh

@GeetaSarvadnya GeetaSarvadnya changed the title 3rd device doesn't show This Device entry in sync chain 3rd device doesn't show This Device entry in the sync chain Sep 3, 2019
@btlechowski
Copy link

btlechowski commented Sep 3, 2019

edit: Reproduced the issue on the latest nightly.

Beta: 0.69.121
Dev: 0.70.80
Nightly: 0.71.63

Steps:

  1. Create sync on Beta
  2. Sync Nightly
  3. Wait 5 seconds
  4. Sync Dev

Result:
Nightly build only gets 2 devices listed.

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Sep 8, 2019

Verification passed on

Brave 0.71.70 Chromium: 76.0.3809.132 (Official Build) dev (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
Brave 0.72.6 Chromium: 77.0.3865.65 (Official Build) nightly (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.523)
Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR from the description
  • Verified the sync between all the 4 channels (R-B-D-N), devices listed in each device as expected
  • Verified the BM's synced in all the 4 devices
    Sync between Release-Dev-Nightly
    image

Sync between Release-Beta-Dev-Nightly
image

Verification passed on

Brave 0.69.125 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.70.103 Chromium: 77.0.3865.90 (Official Build) beta (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.71.82 Chromium: 77.0.3865.90 (Official Build) dev (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
Brave 0.72.60 Chromium: 77.0.3865.90 (Official Build) nightly (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified the STR from the description
  • Verified the sync between all the 4 channels (R-B-D-N), devices listed in each device as expected
  • Verified the BM's synced in all the 4 devices
    Top Row (L -> R): Release, Beta
    Bottom Row (L -> R): Dev, Nightly

Screen Shot 2019-09-30 at 4 49 39 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment