Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New YubiKeys don't work with stable version #5697

Closed
jumde opened this issue Aug 16, 2019 · 2 comments · Fixed by brave/brave-core#3199
Closed

New YubiKeys don't work with stable version #5697

jumde opened this issue Aug 16, 2019 · 2 comments · Fixed by brave/brave-core#3199

Comments

@jumde
Copy link
Contributor

jumde commented Aug 16, 2019

Description

Upstream fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1757608

Steps to Reproduce

  1. Use the new YubiKeys to register/authenticate with GitHub

Also see brave/brave-core#3199

Actual result:

Fails

Expected result:

Should succeed

Reproduces how often:

Easily

Brave version (brave://version info)

Version 0.67.125 Chromium: 76.0.3809.100 (Official Build) (64-bit)

@LaurenWags
Copy link
Member

@kjozwiak since you have the latest yubikey would you mind testing this one?

@kjozwiak
Copy link
Member

kjozwiak commented Sep 4, 2019

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.122 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Screen Shot 2019-09-03 at 11 56 16 PM

Screen Shot 2019-09-03 at 11 56 22 PM

Verification PASSED on Mint 19.1 x64 using the following build:

Brave 0.69.122 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Linux

Screenshot from 2019-09-04 00-34-21

Screenshot from 2019-09-04 00-34-45

Verification PASSED on Windows 10 x64 using the following build:

Brave 0.69.122 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1809 (Build 17763.678)

Annotation 2019-09-04 051812

Annotation 2019-09-04 051835

@rebron rebron changed the title New yubikeys don't work with stable version New YubiKeys don't work with stable version Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment