Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Twitter tip button vertical alignment #5596

Closed
DanielPintilei opened this issue Aug 8, 2019 · 1 comment
Closed

Fix Twitter tip button vertical alignment #5596

DanielPintilei opened this issue Aug 8, 2019 · 1 comment
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.

Comments

@DanielPintilei
Copy link

DanielPintilei commented Aug 8, 2019

Description

Twitter tip button is misaligned vertically, the problem being the Pocket extension'

Actual result:

135316

Expected result:

Changing display: inline-block to display: inline-flex on .ProfileTweet-action.js-tooltip.action-brave-tip fixes the problem.

Reproduces how often:

Edit: I just realized it happens because of the Pocket extension which adds its own button to the list.
Edit 2: It looks like the pocket extension has some messed up styles so it's not Brave's business to work around them. Changing the display property would just be a nice enhancement. Feel free to close this.

Brave version (brave://version info)

Brave | 0.67.124 Chromium: 76.0.3809.100 (Official Build) (64-bit)
Revision | ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS | Windows 10 OS Version 1903 (Build 18362.239)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?: No
@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Sep 20, 2019
@Miyayes
Copy link
Collaborator

Miyayes commented Oct 26, 2021

I believe this has been resolved.

@Miyayes Miyayes closed this as completed Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/rewards priority/P5 Not scheduled. Don't anticipate work on this any time soon.
Projects
None yet
Development

No branches or pull requests

4 participants