Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewards : User Wallets - Verified wallet visual indicator is causing confusion versus verified publishers #5543

Closed
alexwykoff opened this issue Aug 5, 2019 · 2 comments · Fixed by brave/brave-core#3458
Assignees
Labels
design A design change, especially one which needs input from the design team feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@alexwykoff
Copy link

Description

As noted internally, there is a visual conflict between the verified indicator for a user wallet versus the verified indicator for a publisher in the BAT panel.

Steps to Reproduce

  1. Verify your user wallet
  2. Open the BAT panel

Actual result:

Screen Shot 2019-08-05 at 9 04 11 AM

Expected result:

There should not be confusion between a verified user wallet and a verified publisher.

Reproduces how often:

N/A

Brave version (brave://version info)

0.70.34

Version/Channel Information:

Only occurs on Nightly currently, but will follow train as user wallets move.

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No

Miscellaneous Information:

N/A

@bradleyrichter
Copy link

@petemill The design solution is as follows:

image

Wallet Verified button style should be changed to a clear background.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 25, 2019

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verified passed with

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)

Verified test plan from brave/brave-core#3458
Verified display:
Screen Shot 2019-09-25 at 5 38 29 PM
Screen Shot 2019-09-25 at 5 38 58 PM

Connected (not KYC'd) display:
Screen Shot 2019-09-25 at 5 53 21 PM

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

Verified publisher
image
image

Connected publisher
image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants