Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebTorrent: Show torrent name when possible #5351

Closed
feross opened this issue Jul 23, 2019 · 1 comment · Fixed by brave/brave-core#2985
Closed

WebTorrent: Show torrent name when possible #5351

feross opened this issue Jul 23, 2019 · 1 comment · Fixed by brave/brave-core#2985
Assignees
@feross
Labels
feature/webtorrent Label for webtorrent related issues QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@feross
Copy link

feross commented Jul 23, 2019

Description

Torrent name should be preferred over the name of the torrent file, when possible. We show the torrent file name (big-buck-bunny.torrent) but we should attempt to show the torrent name (e.g. Big Buck Bunny) when it is available which is usually once the torrent has been started and metadata has been fetched transfer has started.

Steps to Reproduce

  1. Visit https://webtorrent.io/free-torrents
  2. Click Big Buck Bunny (torrent file)
  3. Start download
  4. See that title shows up as "big-buck-bunny.torrent" instead of "Big Buck Bunny"

Actual result:

Screen Shot 2019-07-23 at 1 03 45 PM

Expected result:

Screen Shot 2019-07-23 at 1 03 40 PM

Reproduces how often:

Always

Brave version (brave://version info)

Version 0.66.101 Chromium: 75.0.3770.142 (Official Build) (64-bit)
@feross feross added the feature/webtorrent Label for webtorrent related issues label Jul 23, 2019
@feross feross self-assigned this Jul 23, 2019
@feross feross mentioned this issue Jul 24, 2019
Merged
32 tasks
feross added a commit to brave/brave-core that referenced this issue Jul 25, 2019
@feross
webtorrent: torrent name improvements
f40ad55 
- Properly capitalize WebTorrent in interface
- Show torrent name in <title>
- Show torrent name in TorrentViewer header
  - Previously, we showed the torrent file name (big-buck-bunny.torrent) but now we attempt to show the torrent name (e.g. Big Buck Bunny) when it is available which is usually once the torrent has been started and metadata has been fetched transfer has started.
- Indent page HTML and add doctype

Closes brave/brave-browser#5351
@yrliou yrliou added this to the 0.70.x - Nightly milestone Jul 26, 2019
@btlechowski
Copy link

btlechowski commented Sep 18, 2019 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 0.70.96 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2985

image

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.126 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS macOS Version 10.14.6 (Build 18G95)

Screen Shot 2019-09-18 at 2 28 56 AM

Screen Shot 2019-09-18 at 2 28 46 AM

Screen Shot 2019-09-18 at 2 28 35 AM

Verification passed on

Brave 0.70.97 Chromium: 77.0.3865.65 (Official Build) beta (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feross feross

Labels
feature/webtorrent Label for webtorrent related issues QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

WebTorrent: torrent name improvements brave/brave-core
6 participants
@feross @kjozwiak @yrliou @LaurenWags @btlechowski @GeetaSarvadnya