Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate Brave ads client state from JSON to database/prefs #5150

Closed
tmancey opened this issue Jul 4, 2019 · 1 comment
Closed

Migrate Brave ads client state from JSON to database/prefs #5150

tmancey opened this issue Jul 4, 2019 · 1 comment
Assignees
@tmancey
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. dev-concern feature/ads OS/Desktop perf

Comments

@tmancey
Copy link
Contributor

tmancey commented Jul 4, 2019 •
edited
Loading

Migrate Ads state from JSON (defaults/ads_service/client.json) to a database/prefs to optimise memory and performance which will become more important for mobile

Nb. components/brave_ads/browser/bundle_state_database.cc / Init - if statement for creating tables is growing, perhaps move to a dedicated method to create all tables?
@tmancey tmancey changed the title Migrate Ads state from JSON to a database Migrate Ads state from JSON to a database to optimise memory and performance Jul 4, 2019
@tmancey tmancey added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 8, 2019
@tmancey tmancey assigned tmancey and unassigned tmancey Jul 8, 2019
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jul 10, 2019
@tmancey tmancey added the perf label Jul 17, 2019
@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Oct 11, 2019
@tmancey tmancey added the QA/Yes label Jan 20, 2020
@tmancey tmancey mentioned this issue Feb 23, 2020
Closed
tmancey pushed a commit that referenced this issue Apr 9, 2020
@bsclifton
Merge pull request #5150 from brave/81.0.4044.92_master_35
db3f024 
Upgrade patches from Chromium 81.0.4044.83 to Chromium 81.0.4044.92
@tmancey tmancey changed the title Migrate Ads state from JSON to a database to optimise memory and performance Migrate Ads state from JSON to a database/prefs to optimise memory and performance May 5, 2020
@tmancey tmancey removed QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels May 16, 2020
@tmancey tmancey added OS/Android Fixes related to Android browser functionality OS/Desktop and removed OS/Android Fixes related to Android browser functionality OS/Desktop labels Aug 5, 2020
@srirambv srirambv changed the title Migrate Ads state from JSON to a database/prefs to optimise memory and performance [Desktop] Migrate Ads state from JSON to a database/prefs to optimise memory and performance Sep 9, 2020
@tmancey tmancey changed the title [Desktop] Migrate Ads state from JSON to a database/prefs to optimise memory and performance Migrate Ads state from JSON to a database/prefs to optimise memory and performance Dec 5, 2020
@tmancey tmancey changed the title Migrate Ads state from JSON to a database/prefs to optimise memory and performance Migrate Ads state from JSON to database/prefs Mar 12, 2021
@tmancey tmancey changed the title Migrate Ads state from JSON to database/prefs Migrate Brave ads client state from JSON to database/prefs Aug 3, 2021
@tmancey tmancey mentioned this issue Sep 14, 2021
Closed
@bsclifton bsclifton mentioned this issue Oct 4, 2021
Closed
@tmancey
Copy link
Contributor Author

tmancey commented Jul 13, 2022

Closing as broken out each node from the JSON into separate issues

@tmancey tmancey closed this as completed Jul 13, 2022
@tmancey tmancey self-assigned this Jul 13, 2022
@tmancey tmancey added the closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. label Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. dev-concern feature/ads OS/Desktop perf
Projects
Ads
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tmancey @NejcZdovc