Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No subframe should be present when ethereum-remote-client is installed #5110

Closed
bbondy opened this issue Jul 3, 2019 · 1 comment · Fixed by brave/ethereum-remote-client#20
Closed

No subframe should be present when ethereum-remote-client is installed #5110

bbondy opened this issue Jul 3, 2019 · 1 comment · Fixed by brave/ethereum-remote-client#20
Assignees
@bbondy
Labels
feature/ethereum-remote-client QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
0.69.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Jul 3, 2019 •
edited
Loading

Screen Shot 2019-07-03 at 12 05 17 AM

Subframe to metamask.github.io should not be there.

app/scripts/lib/setupMetamaskMeshMetrics.js: testingContainer.src = 'https://metamask.github.io/mesh-testing/'
@bbondy bbondy added the feature/web3/wallet Integrating Ethereum+ wallet support label Jul 3, 2019
bbondy added a commit to brave/ethereum-remote-client that referenced this issue Jul 3, 2019
@bbondy
Remove MeteMetrics process https://metamask.github.io
e87d94d 
Fix brave/brave-browser#5110
@bbondy bbondy mentioned this issue Jul 3, 2019
Merged
ryanml pushed a commit to brave/ethereum-remote-client that referenced this issue Jul 9, 2019
@bbondy @ryanml
Remove MeteMetrics process https://metamask.github.io
95499e4 
Fix brave/brave-browser#5110
ryanml pushed a commit to brave/ethereum-remote-client that referenced this issue Jul 9, 2019
@bbondy @ryanml
Remove MeteMetrics process https://metamask.github.io
d57152f 
Fix brave/brave-browser#5110
bbondy added a commit to brave/ethereum-remote-client that referenced this issue Aug 12, 2019
@bbondy
Remove MeteMetrics process https://metamask.github.io
ef25c2e 
Fix brave/brave-browser#5110
@bbondy bbondy added the QA/Yes label Aug 14, 2019
@bbondy bbondy self-assigned this Aug 14, 2019
@bbondy bbondy added this to the 0.70.x - Dev milestone Aug 14, 2019
This was referenced Sep 23, 2019
Closed
Closed
Closed
@kjozwiak
Copy link
Member

kjozwiak commented Sep 27, 2019 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.14.6 (Build 18G95)
  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when launching a new profile
  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when loading brave://wallet
  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when connecting via https://uniswap.exchange/swap
  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when connecting via https://www.cryptokitties.co

Screen Shot 2019-09-26 at 9 00 39 PM

Screen Shot 2019-09-26 at 9 00 12 PM

Screen Shot 2019-09-26 at 9 16 56 PM

Screen Shot 2019-09-26 at 9 18 45 PM

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when launching a new profile

  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when loading brave://wallet
    image

  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when connecting via https://uniswap.exchange/swap
    image

  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when connecting via https://www.cryptokitties.co
    image

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when launching a new profile
  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when loading brave://wallet
  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when connecting via https://uniswap.exchange/swap
  • ensured that Subframe: metamask.github.io wasn't appearing under Task Manager when connecting via https://www.cryptokitties.co

image

image

image

image

ryanml pushed a commit to brave/ethereum-remote-client that referenced this issue Dec 5, 2019
@bbondy @ryanml
Remove MeteMetrics process https://metamask.github.io
0904381 
Fix brave/brave-browser#5110
@srirambv srirambv added feature/ethereum-remote-client and removed feature/web3/wallet Integrating Ethereum+ wallet support labels Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbondy bbondy

Labels
feature/ethereum-remote-client QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Remove MeteMetrics process https://metamask.github.io brave/ethereum-remote-client
5 participants
@bbondy @kjozwiak @srirambv @btlechowski @GeetaSarvadnya