Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Brave Verified Creator" & "Refresh Status" are not translated in Brave Panel #4865

Closed
btlechowski opened this issue Jun 12, 2019 · 4 comments

Comments

@btlechowski
Copy link

btlechowski commented Jun 12, 2019

Steps to Reproduce

  1. Change language to German
  2. Open a verified creator page
  3. Open Brave Panel

Note: also reproducible for Norwegian
Not reproducible: Polish

Actual result:

Brave Verified Creator is not translated in Brave Panel

image

Expected result:

Brave Verified Creator is translated in Brave Panel

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 0.66.88 Chromium: 75.0.3770.87 (Offizieller Build) beta (64-Bit)
Überarbeitung 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
Betriebssystem Windows 7 Service Pack 1 (Build 7601.24465)
Brave 0.68.36 Chromium: 75.0.3770.87 (Offisiell delversjon)nightly (64-bit)
Versjon 9dc58a2353af60ab2b48bab98a25bc43ed59085d-refs/branch-heads/3770@{#982}
OS Windows 7 Service Pack 1 (Build 7601.24465)

cc @brave/legacy_qa @bsclifton @NejcZdovc

@kjozwiak kjozwiak changed the title Brave Verified Creator is not translated in Brave Panel "Brave Verified Creator" & "Refresh Status" are not translated in Brave Panel Jun 13, 2019
@kjozwiak
Copy link
Member

Example of the "Refresh Status" string not being translated while using the Norwegian locale:

Skjermbilde 2019-06-12 kl  20 50 27

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 21, 2019
@rebron
Copy link
Collaborator

rebron commented Jul 11, 2019

This should be fixed with the next translation pull. cc: @mkarolin

@mkarolin
Copy link
Contributor

@rebron the localization files pulled in with c76 do have it translated. So should be in the master/Nightly at this point.

@LaurenWags
Copy link
Member

LaurenWags commented Aug 27, 2019

Verified passed with

Brave 0.69.116 Chromium: 76.0.3809.100 (Offisiell delversjon) beta (64-bit)
Versjon ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Mac OS X
  • Verified "Brave Verified Creator" & "Refresh Status" are translated in German and Norwegian
  • German:
    german1
    german-2
  • Norwegian:
    norwegian1
    norwegian-2

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS
  • German:
    image
    image

  • Norwegian:
    image
    image

Verification passed on

Brave 0.69.119 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants