Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create an exclusion list for the Brave User Agent #4641

Closed
bsclifton opened this issue May 29, 2019 · 3 comments
Closed

Create an exclusion list for the Brave User Agent #4641

bsclifton opened this issue May 29, 2019 · 3 comments
Labels
closed/wontfix webcompat/not-shields-related Sites are breaking because of something other than Shields.

Comments

@bsclifton
Copy link
Member

bsclifton commented May 29, 2019 •
edited
Loading

Description

This is a pre-requisite to providing our our UA #1052

  • If site is in the exclusion list, send the regular Chromium UA
  • If the site is NOT in exclusion list, send Brave UA

Implementation

We can look at existing lists that other browsers have (if applicable)

Examples this will fix

These are the known issues which would be fixed (if the sites are included in this exclusion list)

For other possible examples, check the webcompat project board
@bsclifton bsclifton added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label May 29, 2019
@bsclifton bsclifton self-assigned this May 29, 2019
@bsclifton bsclifton mentioned this issue Jun 3, 2019
Closed
@simonhong simonhong self-assigned this Jun 3, 2019
@pilgrim-brave
Copy link

https://lobste.rs/ is explicitly blocking Brave in User-Agent (confirmed with site owner)

@bsclifton bsclifton mentioned this issue Jun 3, 2019
Merged
29 tasks
mihaiplesa pushed a commit to brave/brave-core that referenced this issue Jun 4, 2019
@bsclifton @mihaiplesa
Revert changes to user agent after experiencing webcompat issues in D…
2a4a7ff 
…ev/Nightly.

Proposed solution:
1. revert this code :) leave the header code in (for the time being) to ensure partner compatibility
2. create a new branch and make the UA toggle-able (ex: "Use Brave user agent") in brave://settings (default to off)
3. continue to flush out UA exceptions as part of brave/brave-browser#4641
4. re-submit work as pull request

Fixes brave/brave-browser#4608
Unfixes brave/brave-browser#1052
(we can remove milestone from brave/brave-browser#4623 as revert won't break this)

-----

Revert "Merge pull request #2515 from brave/fix_ua"
This reverts commit 1a135b6, reversing
changes made to 0160133.

Revert "Merge pull request #2442 from brave/override_ua"
This reverts commit f5a2264, reversing
changes made to 7f958f8.
bsclifton added a commit to brave/brave-core that referenced this issue Jun 4, 2019
@bsclifton
Revert changes to user agent after experiencing webcompat issues in D…
1d4ca9e 
…ev/Nightly.

Proposed solution:
1. revert this code :) leave the header code in (for the time being) to ensure partner compatibility
2. create a new branch and make the UA toggle-able (ex: "Use Brave user agent") in brave://settings (default to off)
3. continue to flush out UA exceptions as part of brave/brave-browser#4641
4. re-submit work as pull request

Fixes brave/brave-browser#4608
Unfixes brave/brave-browser#1052
(we can remove milestone from brave/brave-browser#4623 as revert won't break this)

-----

Revert "Merge pull request #2515 from brave/fix_ua"
This reverts commit 1a135b6, reversing
changes made to 0160133.

Revert "Merge pull request #2442 from brave/override_ua"
This reverts commit f5a2264, reversing
changes made to 7f958f8.
@bsclifton bsclifton mentioned this issue Jun 4, 2019
Closed
@bsclifton bsclifton added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 4, 2019
@WorldLanguages
Copy link

I've seen on Twitter that Whatsapp Web rejects to work with the new useragent.

@pushcx pushcx mentioned this issue Sep 16, 2019
Closed
@bsclifton
Copy link
Member Author

Closing as wontfix; we're going to go with an inclusion list (similar to partner headers). Once #1052 is completed and partners move over, we can deprecate the partner headers

@bsclifton bsclifton added closed/wontfix and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 7, 2019
@pushcx pushcx mentioned this issue Oct 8, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/wontfix webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@bsclifton @simonhong @WorldLanguages @pilgrim-brave