Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shields interface should handle different locales gracefully #4575

Closed
cezaraugusto opened this issue May 23, 2019 · 3 comments
Closed

Shields interface should handle different locales gracefully #4575

cezaraugusto opened this issue May 23, 2019 · 3 comments
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/shields The overall Shields feature in Brave.

Comments

@cezaraugusto
Copy link
Contributor

cezaraugusto commented May 23, 2019 •
edited
Loading

Task split of #2996

Test Plan:

  1. Change OS locale to Russian or any other language with long words
  2. Shields interface should look good without words breaking the interface

The interface should accommodate long strings when translated. For example, the strings in the Shields panel translated to Russian should wrap like this:
@cezaraugusto cezaraugusto added feature/shields The overall Shields feature in Brave. feature/shields/!scripts Blocking JavaScript with Shields labels May 23, 2019
@cezaraugusto cezaraugusto added this to the 0.67.x - Nightly milestone May 23, 2019
@cezaraugusto cezaraugusto self-assigned this May 23, 2019
@cezaraugusto
Copy link
Contributor Author

needs brave/brave-core#2485

@kjozwiak kjozwiak removed this from the 0.67.x - Dev milestone Jun 3, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Jun 3, 2019

Removed 0.67.x - Dev as this issue hasn't been closed/completed and still needs to land in nightly. @cezaraugusto once the PR for this issue lands in nightly, let's add all needed labels and move the issue into the appropriate milestone at that point 👍

@tildelowengrimm tildelowengrimm added the priority/P4 Planned work. We expect to get to it "soon". label Jun 13, 2019
cezaraugusto added a commit to brave/brave-core that referenced this issue Mar 16, 2020
@cezaraugusto
Shields: Better accomodate long strings in non-English languages
fe3877f 
Close brave/brave-browser#4575
@cezaraugusto cezaraugusto mentioned this issue Mar 16, 2020
Closed
32 tasks
@cezaraugusto cezaraugusto removed their assignment May 18, 2020
@rebron rebron added closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. and removed feature/shields/!scripts Blocking JavaScript with Shields labels Nov 16, 2021
@rebron
Copy link
Collaborator

rebron commented Nov 16, 2021

Closing as stale as we're moving over to a new design. cc: @nullhook

@rebron rebron closed this as completed Nov 16, 2021
@rebron rebron removed the priority/P4 Planned work. We expect to get to it "soon". label Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
closed/stale Issue is no longer relevant, perhaps because the feature it refers to has been deprecated. feature/shields The overall Shields feature in Brave.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tildelowengrimm @kjozwiak @cezaraugusto @rebron