Shields shows incorrect blocked items when visiting anew site in the same tab

[srirambv]

Description

Shields shows incorrect blocked items when visiting anew site in the same tab

Steps to Reproduce

1. Visit icloud.com in a new tab and change to Block all fingerprinting
2. See blocked count in shields
3. Visit nytimes.com in the same tab
4. Ensure there are no fingerprint blocked items
5. Click on 0 Fingerprint blocked,. shows icloud items that are blocked

Actual result:

Expected result:

Should only show items blocked for the current domain not from previous site visited on the same tab

Reproduces how often:

100%

Brave version (about:brave info)

Packaged build

Reproducible on current release:

No

Website problems only:

• Does the issue gets fixed with Brave Shields disabled?
• Does the issue reproduces on Chrome?

Additional Information

[GeetaSarvadnya]

Re-validated the issue against the latest build ""Version 0.54.2 Chromium: 69.0.3497.42 (Official Build) dev (64-bit)". Issue still persists hence reopening the issue.

[cezaraugusto]

self-note seems like a race condition. both resources and stats are reset in the ON_BEFORE_NAVIGATION event. commit added by myself in brave/brave-extension@c8edd0f

[cezaraugusto]

worth check if creating an ON_COMMITTED action is best to host resources reset as it is the next event after ON_BEFORE_NAVIGATION and just before onDOMContentLoaded is fired which is when blocked resources start to show

[cezaraugusto]

this issue matches #429 (comment) but not the original issue description which was partially addressed.

worth noticing that both stats and resource blocked are not updated which indicates that maybe ON_BEFORE_NAVIGATION is happening too soon and other events might overlap it and skip stat/resource reset

[btlechowski]

Verification passed on

Brave	0.55.5 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Windows 7

Tried several time to repro.

Verification Passed on

Brave	0.55.6 Chromium: 70.0.3538.16 (Official Build) dev (64-bit)
Revision	16ed95b41bb05e565b11fb66ac33c660b721f778-refs/branch-heads/3538@{#306}
OS	Linux

Verified passed with

Brave	0.55.10 Chromium: 70.0.3538.22 (Official Build) beta(64-bit)
Revision	ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS	Mac OS X