Segmentation fault when launching a second window via terminal #4142
Labels
bug
needs-investigation
A bug not 100% confirmed/fixed
OS/Linux
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-Linux
QA/Yes
Milestone
Comments
srirambv
added
bug
needs-investigation
|
I think I've also run into this on my personal laptop (Debian unstable, Brave release is my default I've also noticed a strange |
|
Other than making |
|
I have a similar problem, opening external links opens 3 new tabs with the same url. Opening links directly from the terminal results in segmentation fault, but it only opens 1 new tab. |
|
Clicking on links in the desktop brings that annoying popup on Xubuntu too. Here is a strace, if it may help: https://gist.githubusercontent.com/teresaejunior/e5c0f6b51f2d93e2ffe4fda1953d5b4d/raw/2d5d665b7f72b2e6421627ff6e8609d2b37144a4/strace |
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this issue
Jun 15, 2019
0.12.6
======
- Bug Fixes:
- Add trailing ";" to mimeapps.list (Xfce #15087)
- Clear bad entries from mimeapps.list (Xfce #15046, #15238)
- Synchronize default applications to gio-mime (Xfce #14633)
- Disable emoji menu in type-ahead search (Xfce #15451)
- Enable dismissal of "Failed to open default" dialogs
- Related: brave/brave-browser#4142
- If the error can be safely ignored, the user is able to dismiss
it. After changing defaults, the dismissal is forgotten.
- Translation Updates: Albanian, Armenian (Armenia), Bulgarian,
Chinese (China), Chinese (Taiwan), Croatian, Danish, French,
Galician, German, Hungarian, Icelandic, Interlingue, Italian,
Polish, Portuguese, Portuguese (Brazil), Russian, Spanish, Thai,
Turkish
clrpackages
pushed a commit
to clearlinux-pkgs/exo
that referenced
this issue
Jun 19, 2019
…able to dismiss
0.12.6
======
- Bug Fixes:
- Add trailing ";" to mimeapps.list (Xfce #15087)
- Clear bad entries from mimeapps.list (Xfce #15046, #15238)
- Synchronize default applications to gio-mime (Xfce #14633)
- Disable emoji menu in type-ahead search (Xfce #15451)
- Enable dismissal of "Failed to open default" dialogs
- Related: brave/brave-browser#4142
- If the error can be safely ignored, the user is able to dismiss
it. After changing defaults, the dismissal is forgotten.
- Translation Updates: Albanian, Armenian (Armenia), Bulgarian,
Chinese (China), Chinese (Taiwan), Croatian, Danish, French,
Galician, German, Hungarian, Icelandic, Interlingue, Italian,
Polish, Portuguese, Portuguese (Brazil), Russian, Spanish, Thai,
(NEWS truncated at 15 lines)
commit 6b7fab6c0812d6c630af0d0e43869368e581eb89
Author: Allar Kiristaja <[email protected]>
Date: Wed Oct 26 22:17:33 2011 +0200
l10n: Updated Estonian (et) translation to 99%
New status: 273 messages complete with 1 fuzzy and 0 untranslated.
Transmitted-via: Transifex (translations.xfce.org).
commit cdbbe036d87de221462bbbaaf81feb18cf5e31cd
Author: Allar Kiristaja <[email protected]>
Date: Wed Oct 26 16:27:39 2011 +0200
l10n: Updated Estonian (et) translation to 98%
(NEWS truncated at 15 lines)
|
Workaround to make |
|
Great workaround, I was about to abandon the browser |
|
Will a packaged release version include a fix for this? |
|
I'm going to take a look at this, it's a pretty bad papercut. |
fmarier
added a commit
to brave/brave-core
that referenced
this issue
Jul 3, 2019
|
Interesting data. After applying the workaround described by @maximbaz I noticed, that brave coredumps every time I click on a link. This is on Fedora 30 x86_64. |
fmarier
added
priority/P3
artemave
added a commit
to artemave/dotfiles
that referenced
this issue
Aug 9, 2019
|
I would not have thought Brave to be the culprit, I was chasing my mime configuration for quite awhile before I stumbled on this issue. I'd love to help assist in any way I can to help resolve this issue. My method of reproducing the problem is performing the following: I ran an strace on the main pid at the time of the test, results are logged here: An odd thing to note is that this is not generating crash reports or dumps as described here: https://github.com/brave/browser-laptop/wiki/Crashes. Instead I have a crash report from the system. If by chance you have the ability to pull this crash from Ubuntu, the ID for the above reproduction is |
fmarier
added a commit
to brave/brave-core
that referenced
this issue
Sep 20, 2019
The `brave` binary returns a non-zero error code and that causes the wrapper to return a non-zero error code too. Since it's not possible to override the error code with an `exec` call (`exec` will terminate the shell immediately with a successful return value), we need to keep the original shell around so that we can hide the true return value of the `brave` binary. This hack should be removed once we have fixed the crash.
|
I merged @maximbaz's work-around on Friday. While the crash hasn't been identified/fixed yet, it will no longer cause more than one browser window to pop up. |
|
I'm happy the work around is released, but fear that as it no longer bites people, the motivation to fix the root cause will atrophy :/ |
4 tasks
fmarier
added a commit
to brave/brave-core
that referenced
this issue
Sep 30, 2019
The `brave` binary returns a non-zero error code and that causes the wrapper to return a non-zero error code too. Since it's not possible to override the error code with an `exec` call (`exec` will terminate the shell immediately with a successful return value), we need to keep the original shell around so that we can hide the true return value of the `brave` binary. This hack should be removed once we have fixed the crash.
|
The work-around has been merged to the Beta (0.70.x) and Dev (0.71.x) branches too. |
|
As mentioned on the issue linked above, still happening for me on Brave version 1.2.36, Manjaro Linux. |
|
@fmestevez I can definitely reproduce on Brave 1.2 (release) but not on 1.3 (beta), 1.4 (dev) or 1.5 (nightly). So this appears to have been fixed on 1.3 if you get a chance to test on beta. |
|
Hey @fmarier. I installed the AUR This is not an issue on a different PC with Linux Mint. It didn't happen before on this PC until a month or so ago. No rush anyways! Thanks. |
@fmestevez Is it crashing the whole browser (like #7581) or is it just a coredump which doesn't appear to have any user-visible impact when you open a second tab using something like |
|
It crashes the whole browser with exit code 139. |
In that case, you're seeing a different issue on that machine. This is most likely #7581 (inherited from the last Chromium merge). |
|
No longer reproducible Verification passed on
Verified test plan from the description |
|
Verification passed on
Verified opening a second terminal and launching brave doesn't show any segmentation fault error message
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Segmentation fault when launching a second window via terminal.
Steps to Reproduce
Actual result:
Release (Manjaro): No crash dump ID generated for release on Ubuntu
Beta: Crash Dump
Dev: Crash dump
Expected result:
No segmentation fault to be shown when launching a second window via terminal
Reproduces how often:
Easy
Brave version (brave://version info)
Reproducible on current release:
Yes
Website problems only:
N/A
N/A
Additional Information
Issue originally reported on community. https://community.brave.com/t/second-launch-gives-segmentation-fault/53664/5
cc: @fmarier @bbondy
The text was updated successfully, but these errors were encountered: