Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ads are enabled by default after update to 0.63.x #4131

Closed
LaurenWags opened this issue Apr 16, 2019 · 3 comments · Fixed by brave/brave-core#2232
Closed

Ads are enabled by default after update to 0.63.x #4131

LaurenWags opened this issue Apr 16, 2019 · 3 comments · Fixed by brave/brave-core#2232

Comments

@LaurenWags
Copy link
Member

Description

When you update from a version where Ads is not available, the Ads toggle gets turned on without user choice.

Steps to Reproduce

  1. Remove any existing Beta installs/profiles.
  2. Clean install https://github.com/brave/brave-browser/releases/tag/v0.61.48 (this is a Beta version where Ads are disabled, I don't know of any more recent beta versions where this is the case)
  3. Launch and enable Rewards. Note, can't enable Ads thru UI.
  4. Go to brave://settings/help
  5. Update to latest Beta on update channel (should be 0.63.x)
  6. Relaunch, go to brave://rewards

Another way to reproduce is:

  1. Install release channel version 0.62.51
  2. Enable Rewards, note, can't enable Ads thru UI.
  3. Close Brave.
  4. Rename release channel version to be a beta profile
  5. Launch Beta version 0.63.x.
  6. Navigate to brave://rewards --> Ads are enabled.

Actual result:

Ads is toggled to on and Ads will begin being served to user.

Expected result:

Ads should not be toggled on.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.63.40 Chromium: 74.0.3729.61 (Official Build) beta(64-bit)
Revision 5df2c8936783bd7575987e45d72a92fcf528496b-refs/branch-heads/3729@{#645}
OS Mac OS X

Reproducible on current release:

n/a, Ads not enabled on current release

  • Does it reproduce on brave-browser dev/beta builds? yes, reproduced on Beta

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

cc @jsecretan @brave/legacy_qa

@jsecretan jsecretan added priority/P1 A very extremely bad problem. We might push a hotfix for it. release/blocking labels Apr 16, 2019
@LaurenWags LaurenWags added this to the 0.63.x - Beta milestone Apr 16, 2019
@btlechowski
Copy link

Reproduced on

Brave 0.63.44 Chromium: 74.0.3729.75 (Official Build) beta (64-bit)
Revision fdb7915642fef8cf997beac2554709d148e3c187-refs/branch-heads/3729@{#754}
OS Windows 10 OS Build 17134.523

@tmancey
Copy link
Contributor

tmancey commented Apr 17, 2019

@LaurenWags this issue will be resolved as part of #3967 and #4154

@LaurenWags
Copy link
Member Author

LaurenWags commented Apr 22, 2019

Verified passed with

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X
  • Verified on Release channel. Verified when updating from 0.62.51 to 0.63.46 Ads were not enabled by default when Rewards had been enabled on 0.62.51.

Verification PASSED on macOS 10.14.4 x64 using the following build:

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Mac OS X
  • Verified on release. Ensured when updating from 0.62.51 to 0.63.46, Ads were not enabled by default when Rewards had been enabled on 0.62.51.

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523
  • Verified on release. Ensured when updating from 0.62.51 to 0.63.46, Ads were not enabled by default when Rewards had been enabled on 0.62.51.

Verification passed on

Brave 0.63.46 Chromium: 74.0.3729.91 (Official Build) (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Linux
  • Verified enabling rewards on 0.62.51 and upgrading to to 0.63.46, Ads is not enabled by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment