Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip behiiv link IDs from URLs #40716

Closed
fmarier opened this issue Aug 27, 2024 · 4 comments · Fixed by brave/brave-core#25364
Closed

Strip behiiv link IDs from URLs #40716

fmarier opened this issue Aug 27, 2024 · 4 comments · Fixed by brave/brave-core#25364
Assignees

Comments

@fmarier
Copy link
Member

fmarier commented Aug 27, 2024

I noticed a _bhlid parameter in the following link: https://techcrunch.com/2024/08/26/anthropic-publishes-the-system-prompt-that-makes-claude-tick/?_bhlid=0b2d1e067fdf041e2c1a357f8466ab8c3df13f76

and then from PublicWWW I found another example that pointed me in the direction of beehiiv.com.

Given that they advertise the ability to track clicks and opens, I assume that _bhlid stands for beehiiv link ID and that this is a unique identifier that can be traced back to an individual newsletter subscriber.

@fmarier fmarier added release-notes/include OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter OS/iOS Fixes related to iOS browser functionality labels Aug 27, 2024
@fmarier fmarier self-assigned this Aug 27, 2024
@github-project-automation github-project-automation bot moved this to Untriaged Backlog in Security & Privacy Aug 28, 2024
@fmarier fmarier moved this from Untriaged Backlog to In Progress in Security & Privacy Aug 28, 2024
fmarier added a commit to brave/brave-core that referenced this issue Aug 28, 2024
@fmarier fmarier added the QA/Yes label Aug 28, 2024
@fmarier fmarier moved this from In Progress to Pending review in Security & Privacy Aug 28, 2024
@github-project-automation github-project-automation bot moved this from Pending review to Completed in Security & Privacy Aug 30, 2024
@brave-builds brave-builds added this to the 1.71.x - Nightly milestone Aug 30, 2024
@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.71.90 Chromium: 129.0.6668.59 (Official Build) beta (64-bit)
-- | --
Revision | 1f5f0d1b8a45a4c60a78c15df081751e39184b97
OS | Windows 11 Version 23H2 (Build 22631.4169)

Reproduced 1.70.117

image

  1. Installed 1.71.90
  2. launched Brave
  3. opened brave://settings/shields in a new tab
  4. verified Trackers & ads blocking shows Standard
  5. visited https://brave.com/?_bhlid=123456

Confirmed that the URL bar only shown https://brave.com/ and no _bhlid = 123456 parameter.

example example
image image

@srirambv
Copy link
Contributor

srirambv commented Oct 8, 2024

Verification passed on Google Pixel 8 with Android 14 running 1.71.104 x64 Beta build

  • Verified steps from issue description
  • Verified with Shields set to Block trackers & ads (Standard) visiting https://brave.com/?_bhlid=123456 redirects to https://brave.com and removes ?_bhlid=123456
40716.mp4

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 21, 2024
@hffvld
Copy link
Contributor

hffvld commented Oct 21, 2024

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.7
Brave build: 1.71 (116)
BraveCore: 1.71.116 (130.0.6723.58)

STEPS:

  1. Follow the STR/TP from Strip behiiv link IDs from URLs brave-core#25364 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that _bhlid=123456 parameter is removed when navigating to https://brave.com/?_bhlid=123456 and redirects to https://brave.com/ when Trackers & Ads Blocking in Brave Shields is set to Standard.

1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

5 participants