clicking on Restore causes infinite spinner when there's no subscription to restore

[kjozwiak]

Description:

When clicking on Restore via the Leo Premium paywall and there's nothing to restore, you'll get stuck in an infinite spinning loop which will never timeout. We shouldn't be attempting to Restore if there's nothing to restore. Or at least reduce the timeout.

Steps to Reproduce

1. install 1.63.173 Chromium: 122.0.6261.111 via TF
2. go into Hamburger Menu -> Settings -> Leo -> Go Premium
3. click on Restore and notice that it won't timeout/will spinning

Actual result:

When clicking in Restore, both the Restore & Upgrade Now button will keep spinning and nothing will happen.

Expected result:

If there's nothing to Restore, we should give the user some type of warning after timing out that there's no active subscriptions that can be restored.

Reproduces how often: [Easily reproduced, Intermittent Issue]

I've managed to reproduce the issue ~3-4 times out of a few attempts so it's pretty reproducible.

Brave Version:

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
• Can you reproduce this issue with the current build from AppStore? N/A (1.63.x hasn't been released with Leo)

Device details:

1.63.173 Chromium: 122.0.6261.111 (Official Build) unknown (64-bit) 
--- | ---
Revision | 77ac6bd3b328...
OS | iOS 17.4 via iPhone 11

Website problems only:

• Does the issue resolve itself when disabling Brave Shields? N/A
• Is the issue reproducible on the latest version of Mobile Safari? N/A

Additional Information

[kjozwiak]

Closing as the above has been fixed via brave/brave-core#22578.

[kjozwiak]

The above requires 1.63.177 or higher for 1.63.x verification 👍

[kjozwiak]

Verifications PASSED on iPhone 11 running iOS 17.4 using the following build(s):

1.63.178 Chromium: 122.0.6261.128 (Official Build) unknown (64-bit)
--- | ---
Revision | 83e0e6978dea...
OS | iOS

Using the STR/Cases outlined via #36788 (comment), ensured that Restore eventually times out when there's nothing to restore with an error rather than spinning for ~1min. We'll need to verify this once we get a real build on AppStore to make sure it's also behaving correctly. For example, clicking on Restore when a real subscription doesn't exists.

---

Verifications PASSED on iPad Air (3rd Gen) running iOS 17.4 using the following build(s):

1.63.178 Chromium: 122.0.6261.128 (Official Build)unknown (64-bit)
-- | --
Revision | 83e0e6978deaec315c9050550a651cca2a4e60dc
OS | iOS

Using the STR/Cases outlined via #36788 (comment), ensured that Restore eventually times out when there's nothing to restore with an error rather than spinning for ~1min. We'll need to verify this once we get a real build on AppStore to make sure it's also behaving correctly. For example, clicking on Restore when a real subscription doesn't exists.