-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Excluded sites can't be viewed without having them restored #3657
Comments
@NejcZdovc @ryanml to make it easy on the design, can we just have another symbol color that shows? This will ensure there is no extra table and the sites that were excluded show up as part of the attention. Alternative option: My worry is the privacy focused segments may not want to have anyone be able to see what was excluded. |
I think that an extra table is probably the right design: interact with the text at the bottom about excluded items and the table turns into the excluded items, with interactive elements to restore them one at a time, or all. But I defer to design. |
@tomlowenthal you comfy showing excluded items? please double confirm |
No problem showing excluded items behind a click/button. Showing excluded items without a click is dicier. |
Here is the design recommendations. |
@jenn-rhim this looks slick! Thanks for providing. One nit, on the Excluded Sites view, for the restore action, was the X icon intentional? Maybe something like this from our icon library: |
Though I do understand if the X icon was more meant to denote: |
@ryanml I believe that contextually it is appropriate to use 'x' as a notion of 'Remove' from this list. The context is "here is the list of sites you excluded. Would you like to remove any of the sites from this exclusion list?" I've purposefully displayed the tooltip on hover to make this clear to the user. What may be helpful is to change the tooltip text to 'Remove from the excluded' instead of 'Restore' maybe? |
Verified passed with
Verification passed on
Verification passed on
|
Description
Excluded sites can't be viewed without having them restored
Steps to Reproduce
Actual result:
Expected result:
There should be a way to see excluded sites without having to restore them
Reproduces how often:
Easy
Brave version (brave://version info)
All
Reproducible on current release:
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: