Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded sites can't be viewed without having them restored #3657

Closed
srirambv opened this issue Mar 11, 2019 · 10 comments · Fixed by brave/brave-core#2199
Closed

Excluded sites can't be viewed without having them restored #3657

srirambv opened this issue Mar 11, 2019 · 10 comments · Fixed by brave/brave-core#2199

Comments

@srirambv
Copy link
Contributor

Description

Excluded sites can't be viewed without having them restored

Steps to Reproduce

  1. Enable rewards
  2. Visit a few sites (3-4)
  3. Exclude them from a-c
  4. Feel like Bruce Willis from Sixth Sense that you think you know but you don't actually know

Actual result:

image

Expected result:

There should be a way to see excluded sites without having to restore them

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@mandar-brave
Copy link

mandar-brave commented Apr 1, 2019

@NejcZdovc @ryanml to make it easy on the design, can we just have another symbol color that shows?
(excluded icon) site/contributor with a different color.

This will ensure there is no extra table and the sites that were excluded show up as part of the attention.

Alternative option:
We have an easter egg that replaces existing attention table with table of exclusions.

My worry is the privacy focused segments may not want to have anyone be able to see what was excluded.

cc @jenn-rhim @tomlowenthal

@tildelowengrimm
Copy link
Contributor

I think that an extra table is probably the right design: interact with the text at the bottom about excluded items and the table turns into the excluded items, with interactive elements to restore them one at a time, or all. But I defer to design.

@mandar-brave
Copy link

@tomlowenthal you comfy showing excluded items? please double confirm

@tildelowengrimm
Copy link
Contributor

No problem showing excluded items behind a click/button. Showing excluded items without a click is dicier.

@jenn-rhim
Copy link

Here is the design recommendations.
The only new items other than the excluded site list itself is the date stamp of when the user excluded each site and the ability to restore the individual site rather than restoring the entire exclusion list. For the excluded sites prior to this change for which we don't have the date stamp, we'll indicate it with '--'.

1-ac-list

2-excluded

@ryanml
Copy link
Contributor

ryanml commented Apr 3, 2019

@jenn-rhim this looks slick! Thanks for providing.

One nit, on the Excluded Sites view, for the restore action, was the X icon intentional? Maybe something like this from our icon library:

Screen Shot 2019-04-03 at 1 32 55 PM

@ryanml
Copy link
Contributor

ryanml commented Apr 3, 2019

Though I do understand if the X icon was more meant to denote: Remove the item from this list

@NejcZdovc NejcZdovc added priority/P3 The next thing for us to work on. It'll ride the trains. and removed release-notes/exclude labels Apr 4, 2019
@jenn-rhim
Copy link

jenn-rhim commented Apr 10, 2019

@ryanml I believe that contextually it is appropriate to use 'x' as a notion of 'Remove' from this list. The context is "here is the list of sites you excluded. Would you like to remove any of the sites from this exclusion list?" I've purposefully displayed the tooltip on hover to make this clear to the user.

What may be helpful is to change the tooltip text to 'Remove from the excluded' instead of 'Restore' maybe?

@Brave-Matt
Copy link

+1 from Community:
https://community.brave.com/t/is-there-an-auto-contribute-excluded-site-list/63770/2

@LaurenWags
Copy link
Member

LaurenWags commented Jul 10, 2019

Verified passed with

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Mac OS X

Verification passed on

Brave 0.67.106 Chromium: 75.0.3770.100 (Official Build) beta (64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.67.110 Chromium: 75.0.3770.100 (Official Build) beta(64-bit)
Revision cd0b15c8b6a4e70c44e27f35c37a4029bad3e3b0-refs/branch-heads/3770@{#1033}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment