Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The glasses thumbnail is not aligned properly in the URL search bar in Private tab #33882

Closed
hffvld opened this issue Oct 24, 2023 · 2 comments · Fixed by brave/brave-core#20665
Assignees
Labels

Comments

@hffvld
Copy link
Contributor

hffvld commented Oct 24, 2023

Description

The glasses thumbnail is not aligned properly in the URL search bar in the Private tab. This is a C119 related issue. I checked the same with Nightly build 1.61.46 which has C118, and the issue is not there.

Steps to reproduce

  1. Launch Brave Nightly 1.61.47 which has C119
  2. Open a Private tab > Observe

Actual result

The glasses thumbnail is not aligned properly in the URL search bar in the Private tab.

2023-10-24_11-24-56

Expected result

The glasses thumbnail must be properly aligned in the URL search bar in the Private tab.

2023-10-24_11-24-28

Issue reproduces how often

Easily reproduced

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NO
  • Can you reproduce this issue with the current Play Store Beta version? NO
  • Can you reproduce this issue with the current Play Store Nightly version? YES

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 7 (phone)
  • Android version: Android 14

Brave version

Brave build: 1.61.47 
Chromium: 119.0.6045.33 (Official Build) canary (64-bit) 
Revision: 63aeef007c8d6fa051b21b4c8cdc9667fb16b389

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

The above requires 1.60.105 or higher for 1.60.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Oct 30, 2023
@hffvld
Copy link
Contributor Author

hffvld commented Oct 30, 2023

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 [panther_beta-user 14 U1B2.230922.010 release-keys]
Brave build: 1.60.106
Chromium: 119.0.6045.59 (Official Build) (64-bit) 
Revision: 16064193dde8c55f64dabd32f125c0cd9380f96a

STEPS:

  1. Followed the steps from The glasses thumbnail is not aligned properly in the URL search bar in Private tab #33882 (comment)

ACTUAL RESULTS:

  • Verified that the glasses thumbnail is properly aligned in the URL search bar in the Private tab.

1 2
1 2

@hffvld hffvld added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants