Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade from Chromium 118.0.5993.54 to Chromium 118.0.5993.70 #33556

Closed
emerick opened this issue Oct 10, 2023 · 6 comments · Fixed by brave/brave-core#20477
Closed

Upgrade from Chromium 118.0.5993.54 to Chromium 118.0.5993.70 #33556

emerick opened this issue Oct 10, 2023 · 6 comments · Fixed by brave/brave-core#20477
Assignees
@emerick @mkarolin
Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@emerick
Copy link
Contributor

emerick commented Oct 10, 2023

Minor Chromium bump

https://chromium.googlesource.com/chromium/src/+log/118.0.5993.54..118.0.5993.70?pretty=fuller&n=10000

QA tests:

  • Check branding items
  • Check for version bump

Additional checks:

  • No specific code changes in Brave (only line number changes in patches)
@emerick emerick added QA/Yes release-notes/include QA/Test-Plan-Specified OS/Android Fixes related to Android browser functionality Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Desktop labels Oct 10, 2023
This was referenced Oct 10, 2023
Merged
Merged
Merged
@kjozwiak
Copy link
Member

Closing as the above was uplifted into 1.60.x & 1.59.x as per brave/brave-core#20476 & brave/brave-core#20475.

@kjozwiak
Copy link
Member

The above requires 1.59.117 or higher for 1.59.x verification 👍 @brave/qa-team we should run through a quick upgrade on a few platforms like Win x64, macOS x64 and Android ARM.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 11, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.59.117 Chromium: 118.0.5993.70 (Official Build) (64-bit)
-- | --
Revision | 766577bee8f040990afcb32677dcab38ffcf0f06
OS | Windows 10 Version 22H2 (Build 19045.3448)
  • Verified the Upgrade test, upgrade looks good
    image

@LaurenWags
Copy link
Member

LaurenWags commented Oct 11, 2023 •
edited
Loading

Verified with

Brave | 1.59.117 Chromium: 118.0.5993.70 (Official Build) (x86_64)
-- | --
Revision | 766577bee8f040990afcb32677dcab38ffcf0f06
OS | macOS Version 13.6 (Build 22G120)
Intel

Verified with

Brave	1.59.117 Chromium: 118.0.5993.70 (Official Build) (arm64) 
Revision	766577bee8f040990afcb32677dcab38ffcf0f06
OS	macOS Version 14.1 (Build 23B5046f)

M1

@btlechowski
Copy link

Verified with

Brave 1.59.117 Chromium: 118.0.5993.70 (Official Build) (64-bit)
Revision 766577bee8f040990afcb32677dcab38ffcf0f06
OS Linux

image

This was referenced Oct 11, 2023
Closed
Closed
@Uni-verse
Copy link
Contributor

Uni-verse commented Oct 11, 2023 •
edited
Loading

Verified on Samsung Galaxy S21 using version:

Brave	1.59.117 Chromium: 118.0.5993.70 (Official Build) (64-bit) 
Revision	766577bee8f040990afcb32677dcab38ffcf0f06
OS	Android 13; Build/TP1A.220624.014; 33; REL
Example Example
Screenshot 2023-10-11 at 10 41 13 AM Screenshot 2023-10-11 at 10 41 26 AM

@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@mkarolin mkarolin

Labels
Chromium/upgrade minor Minor version bump. (ex: Chromium 88.0.0.1 to 88.0.0.2) OS/Android Fixes related to Android browser functionality OS/Desktop QA Pass - Android ARM QA Pass-Linux QA Pass-macOS QA Pass-macOS-arm64 QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade from Chromium 118.0.5993.54 to Chromium 118.0.5993.70 brave/brave-core
8 participants
@kjozwiak @emerick @Uni-verse @LaurenWags @btlechowski @GeetaSarvadnya @mkarolin @brave-builds