Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution date text on Tips panel #3287

Closed
LaurenWags opened this issue Feb 8, 2019 · 1 comment · Fixed by brave/brave-core#1683
Closed

Contribution date text on Tips panel #3287

LaurenWags opened this issue Feb 8, 2019 · 1 comment · Fixed by brave/brave-core#1683

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Feb 8, 2019

Description

Per #1834 (comment) the text for the 'contribution date' in Tips panel should be

"Monthly tips will next be sent" followed by the next contribution date.

However, the text exactly matches Auto Contribute table. Logging per discussion with @mandar-brave for him and @jenn-rhim to review.

Steps to Reproduce

  1. Enable Rewards
  2. Navigate to verified site.
  3. Set up a monthly recurring tip.

Actual result:

Note that contribution text in both Tips and Auto Contribute panels are the same:
screen shot 2019-02-08 at 5 58 47 pm

Expected result:

Was expecting different language per the comment referenced above. If that's no longer accurate, please close this issue.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.60.23 Chromium: 72.0.3626.96 (Official Build) beta(64-bit)
Revision 84098ee7ef8622a9defc2ef043cd8930b617b10e-refs/branch-heads/3626@{#836}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

@btlechowski
Copy link

btlechowski commented Feb 26, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1683

image

Verification passed on

Brave 0.61.39 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux Mint

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment