Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insecure file download warning icon in toolbar size is increased #30736

Closed
simonhong opened this issue Jun 1, 2023 · 1 comment · Fixed by brave/brave-core#18705
Closed

Comments

@simonhong
Copy link
Member

Description

While checking #30626, I found warning icon size is changed.
Latest:
Screenshot 2023-06-01 at 1 25 05 PM

Beta
Screenshot 2023-06-01 at 1 28 00 PM

Steps to Reproduce

  1. load https://www.leaseweb.com/platform/network
  2. context-click on any file-download link
  3. choose Save Link As...
  4. click Save

Actual result:

Icon size should be same with current beta above.

Expected result:

Larger icon is used

Reproduces how often:

100%

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no
  • Can you reproduce this issue with the beta channel? no
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

Verified PASSED using

Brave 1.54.26 Chromium: 114.0.5735.90 (Official Build) nightly (64-bit)
Revision 386bc09e8f4f2e025eddae123f36f6263096ae49-refs/branch-heads/5735@{#1052}
OS Windows 10 Version 22H2 (Build 19045.3031)

Steps:

  1. installed 1.54.26
  2. launch Brave
  3. loaded https://www.leaseweb.com/platform/network
  4. context-clicked on 10,000 mb
  5. chose Save link as...
  6. clicked Save
  7. confirmed insecure-download warning icon appeared on the browser toolbar

Confirmed the insecure-download warning icon is now properly-sized

in context up close
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment