Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FBD] Synchronize ephemeral and first party storage cleanup event #30090

Closed
goodov opened this issue May 2, 2023 · 7 comments · Fixed by brave/brave-core#18331
Closed

[FBD] Synchronize ephemeral and first party storage cleanup event #30090

goodov opened this issue May 2, 2023 · 7 comments · Fixed by brave/brave-core#18331

Comments

@goodov
Copy link
Member

goodov commented May 2, 2023

Modify ES cleanup event to trigger after 30 seconds the website is closed as discussed in the "Forget first party by default" PR: brave/brave-core#16470 (comment)

This will allow us to perform cleanup for all parts (permissions, ephemeral storage, first party storage) at the same time.

Related #26465

@goodov goodov self-assigned this May 2, 2023
@goodov goodov changed the title Unify ephemeral storage and first party storage cleanup event [FBD] Unify ephemeral storage and first party storage cleanup event May 18, 2023
@goodov goodov changed the title [FBD] Unify ephemeral storage and first party storage cleanup event [FBD] Synchronize ephemeral and first party storage cleanup event May 18, 2023
@brave-builds brave-builds added this to the 1.54.x - Nightly milestone Jun 8, 2023
@goodov
Copy link
Member Author

goodov commented Jun 12, 2023

Include all test cases from brave/brave-variations#567 (comment)

Additional test cases

Test case 1

  1. Open https://dev-pages.brave.software/storage/ephemeral-storage.html and pass all steps up to the Step 6.
  2. Perform Step 6.
  3. Expect "Remote Frame" storage is NOT cleared up, i.e. the result should be equal to Step 4 table.
  4. Close the page, wait 30 seconds, open the copied URL again.
  5. Expect "Remote Frame" storage is cleared up, i.e. the result should be equal to Step 6 table.

Test case 2

  1. Enable "Forget by default" for a website.
  2. Disable shields on the website.
  3. Close the website, wait 30 seconds, reopen it.
  4. Expect "Forget by default" was not executed, i.e. cookies, local storage and other DOM storage data is intact.

Test case 3

  1. Open https://permission.site
  2. Trigger any permission, choose permission lifetime "until I close the site".
  3. Close the website, wait 30 seconds, reopen it.
  4. Expect permission is reset.

@MadhaviSeelam
Copy link

MadhaviSeelam commented Jul 13, 2023

Verification PASSED using

Brave | 1.57.8 Chromium: 115.0.5790.75 (Official Build) beta (64-bit)
-- | --
Revision | 77bffd419b7e89d7e666c9695e7fa0d1d0367a99
OS | Windows 11 Version 22H2 (Build 22621.1992)

Verification is passed for all the tests (i.e Test Case 1 - Test Case 7) as below using STR from #30090 (comment). However, Additional testcases were skipped as per the discussion.

Test Case 1 - Enabling BraveForgetFirstPartyStorage feature via Griffin - PASSED

Case 1 - Before feature being enabled via Griffin - PASSED

  1. Installed 1.57.8
  2. launched Brave
  3. confirmed BraveForgetFirstPartyStorage isn't visible under brave://version
  4. visited github.com in a new tab
  5. clicked Shields icon to open the Shields panel
  6. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle doesn't appear via the Shields panel
  • Confirmed Forget me when I close this site toggle doesn't appear via brave://settings/shields
step 3 step 5 step 6
image image image

Case 2: After feature being enabled via Griffin - PASSED

  1. continue from Case 1:
  • BraveForgetFirstPartyStorage isn't visible under brave://version
  • Forget me when I close this site toggle doesn't appear via brave://settings/shields
  1. closed and restarted Brave
  2. confirmed BraveForgetFirstPartyStorage:Enabled is shown in brave://version
  3. opened Shields panel in the nytimes.com tab
  4. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle appears in the Shields panel and is Off by default
  • Confirmed Forget me when I close this site toggle appears in the brave://settings/shields and is Off by default
step 3 step 4 step 5
image image image

Dark theme

shields panel brave://settings/shields
image image

Test Case 2: Enable Forget me when I close this site setting in the Shields panel per domain - PASSED

Case 1 - Enable Forget me when I close this site setting in the Shields panel and toggle per site and wait 30s - PASSED

  1. continued from Case 2 (Test Case 1)
    • BraveForgetFirstPartyStorage is shown under brave://version
    • Forget me when I close this site toggle is Off is shown via the Shields panel for github.com
    • Forget me when I close this site toggle is Off is shown via brave://settings/shields
  2. visited into https://www.github.com and logged into the account
  3. visited https://www.nytimes.com and logged into the account
  4. confirmed password credentials for both github.com & nytimes.com are saved in brave://settings/passwords
  5. confirmed github.com & nytimes.com entries are shown in brave://settings/content/all
  6. restarted the browser and confirmed that I am still logged into both nytimes & Github
  7. toggled Forget me when I close this site On for nytimes.com & github.com in the Shields panel
  8. closed both tabs for the sites (nytimes & Github) and wait for ~30sec
  9. reopened brave://settings/content/all in a new tab
  10. confirmed both Github.com & nytimes.com have been completely removed from brave://settings/content/all
  11. reloaded both https://github.com & https://www.nytimes.com sites
  12. confirmed that I have been logged out of both the sites i.e. github.com & nytimes.com
  13. confirmed nytimes.com and github.com entries haven't been removed/cleared from brave://history
  14. confirmed that passwords are not being removed via brave://settings/passwords

confirmed nytimes.com & github.com sites are removed from brave://settings/content/all

confirmed that passwords entries are not removed via brave://settings/passwords

confirmed when nytimes.com & github.com sites are reloaded, I am signed out of both the sites

step 1 step 4 step 5 step 7a step 7b step 10 step 12a step 12b step 13 step 14
image image image image image image image image image image

Case 2 - Enable Forget me when I close this site setting in the Shields panel and reopen a site within 30 secs - PASSED

  1. new profile
  2. launched Brave
  3. relaunched Brave and verified following:
    • BraveForgetFirstPartyStorage is shown under brave://version
    • Forget me when I close this site toggle is shown via brave://settings/shields
  4. logged into https://www.nytimes.com & github.com and saved password credentials
  5. confirmed password credentials are saved in brave://settings/passwords for both the sites
  6. confirmed nytimes.com & github entries shown in brave://settings/content/all
  7. opened the Shields panel for https://www.nytimes.com site and verified Forget me when I close this site toggle is OFF
  8. toggled On/enable Forget me when I close this site setting in the Shields panel
  9. closed both sites, nytimes.com & github.com (but not the browser)
  10. confirmed nytimes.com entry is still shown in brave://settings/content/all
  11. confirmed password credentials are still shown in brave://settings/passwords
  12. re-loaded the `nytimes.com site within ~30s (15s) and confirmed I am still logged into the site
  13. reloaded github.com site within ~30s (15s) and confirmed I am still logged into the site
  14. open brave://history in a new tab
  • Confirmed when nytimes.com is reloaded within 30 secs, nytimes.com entry is still shown in brave://settings/content/all
  • Confirmed password credentials are still shown in brave://settings/passwords
  • Confirmed when nytimes.com site is reloaded, I am still signed in to the site
  • Confirmed brave://history is not cleared
step 3a step 3b step 5 step 6 step 8a step 8b step 10 step 11 step 12 step 13
image image image image image image image image image image

Additionally ran through this using different times. Example: within 5s, 10s, 20s confirmed storage wasn't removed as below:

within 20s
---- | ---- | ----

  • new profile
  • verified with https://nytimes.com
  • followed test steps from above and loaded the website within ~20 secs
  • confirmed still logged into nytimes.com
  • confirmed brave://settings/all shows the site nytimes.com
  • confirmed brave://settings/passwords shows saved passwords
example example example example
image image image image

within 10s

  • new profile
  • verified with https://bloomberg.com
  • followed test steps from above and loaded the website within ~10 secs
  • confirmed still logged into bloomberg.com & github.com
  • confirmed brave://settings/all shows the site bloomberg.com & github.com
  • confirmed brave://settings/passwords shows saved passwords
  • confirmed browsing history is not clearing in brave://history
example example example
image image image

within 5s

  • new profile
  • https://microsoft.com/
  • followed test steps from above and loaded the website within ~5 secs
  • confirmed still logged into nytimes.com
  • confirmed brave://settings/all shows the site microsoft.com &
  • confirmed brave://settings/passwords shows saved passwords
example example example
image image image

Continued from above and waited ~30 sec and confirmed the storage has been removed

step 14 step 15 step 16 step 17
  1. logged into both github.com & nytimes.com sites
  2. enabled Forget me when I close the site setting for both the sites in the Shields panel
  3. github.com & nytimes.com are shown in brave://settings/content all
  4. passwords entries are shown in brave://settings/passwords
  5. closed both sites nytimes and github and waited ~30s
  6. verified nytimes.com is removed from brave://settings/content/all
  7. verified that passwords entries are not removed via brave://settings/passwords
  8. verified that browsing history in brave://history hasn't been removed
  9. verified when https://www.nytimes.com/ reloaded, I am signed out of the site
  10. verified when https://www.github.com/ reloaded, I am signed out of the site
step 1a step 1b step 6 step 7 step 8 step 9 step 10
image image image image image image image

Test Case 3 - Enabling BraveForgetFirstPartyStorage (Permissions) - PASSED

Case 1: Select until I close this site in the permission prompt for talk.brave.com while not logged in - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear under brave://settings/shields
  2. visited https://talk.brave.com/
  3. keep the default value until I close this site permissions in the permission prompt for both Microphone & Camera
  4. clicked Allow to give permissions for both Microphone & Camera
  5. clicked on the lock icon via https://talk.brave.com/ and confirmed Microphone & Camera permissions are enabled
  6. confirmed brave.com entry is shown in brave://settings/content/all
  7. confirmed when drill down brave.com>>cookies and site Data, local storage data is shown
  8. toggled Forget me when I close this site On via the shields panel
  9. closed https://talk.brave.com/ tab and waited ~30s
  10. confirmed brave.com is removed in brave://settings/content/all
  11. confirmed that both Microphone & Camera are shown default values Ask (default) in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com
  12. confirmed no entries are shown in Allowed to use your camera via brave://settings/content/camera & brave://settings/content/microphone
step 1a step 1b step 2a step 2b step 5 step 6 step 7 step 8 step 10 step 11 step 12a step 12b
image image image image image image image image image image image image

Case 2: Select Forever in the permissions prompt for talk.bravesoftware.com while logged in - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear under brave://settings/shields
  2. logged in to https://talk.bravesoftware.com/ and click Start Premium call and join the meeting
  3. selected Until I close this site for microphone and Forever for Camera permissions in the permission prompt
  4. clicked Allow to give permissions for both Microphone & Camera
  5. clicked on the lock icon via https://talk.bravesoftware.com/ URL and confirmed Microphone & Camera permissions are enabled
  6. verified site settings for Camera and Microphone show Allow via brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com
  7. verified bravesoftware.com entry is shown in brave://settings/content/all
  8. verified local storage data is shown when drill down brave.com>>cookies and site Data
  9. verified brave://settings/content/camera shows talk.bravesoftware.com:443 entry
  10. verified brave://settings/content/microphone shows talk.bravesoftware.com:443 entry
  11. toggled Forget me when I close this site on via the shields panel for https://talk.bravesoftware.com/
  12. closed https://talk.bravesoftware.com/ tab including subscription page tab and waited ~30s
  13. confirmed bravesoftware.com is shown with 0 B in brave://settings/content/all
  14. confirmed local storage is removed via bravesoftware.com>>cookies and Site Data, which is the pass condition
  15. confirmed that Microphone shows Ask (default) & Camera shown values `Ask in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com which is expected given the permissions
  16. confirmed entries https://talk.bravesoftware.com:443 is shown in Allowed to use your camera via brave://settings/content/camera which is expected given the permissions
  17. confirmed no entries are shown in Allowed to use your microphone via brave://settings/content/microphone
step 1 step 2a step 2b step 5 step 6 step 7 step 8 step 11 step 13 step 14 step 15 step 16 step 17
image image image image image image image image image image image image image

Test Case 4 : Enable BraveForgetFirstPartyStorage global value via brave://settings/shields - PASSED

Case 1: Enable Forget me when I close this site in brave://settings/shields but leave the setting enabled per site - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear under brave://settings/shields
  2. enabled Forget me when I close this site via brave://settings/shields
  3. visited https://netflix.com/ and ensure that Forget me when I close this site is enabled via the shields panel
  4. logged into https://netflix.com
  5. confirmed password credentials are saved in brave://settings/passwords (saved passwords shown only for hbomax)
  6. confirmed netflix.com entries are shown within brave://settings/content/all
  7. leave Forget me when I close this site for https://netflix.com` via brave shields panel
  8. closed https://www.netflix.com/ tab and wait ~30s
  9. reopened/reloaded brave://settings/content/all tab
  10. confirmed netflix.com entry is removed from brave://settings/content/all
  11. confirmed that passwords are not being removed via brave://settings/passwords
  12. reopened https://www.netflix.com/
  13. confirmed I am logged out of the website
  14. confirmed that brave://history hasn't been removed/cleared
step 1 step 2 step 3 step 4 step 5 step 6 step 10 step 11 step 13 step 14
image image image image image image image image image image

Case 2: Enable Forget me when I close this site in brave://settings/shields but disable the setting per site - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear and is Off under brave://settings/shields
  2. enabled Forget me when I close this site via brave://settings/shields
  3. visited https://github.com and https://www.hbomax.com/ and verified that Forget me when I close this site is enabled via the shields panel
  4. visited https://https://github.com/ and https://www.hbomax.com and logged into the websites
  5. confirmed password credentials are saved in brave://settings/passwords
  6. confirmed github.com and max.com entries are shown within brave://settings/content/all with local storage
  7. disabled Forget me when I close this site on https://www.github.com/ via Shields panel and also leave it enabled globally
  8. leave Forget me when I close this site setting On for https://hbomax.com via Shields panel
  9. closed https://www.gmail.com/ and waited ~30s
  10. closed https://www.hbomax/ and waited ~30s
  11. confirmed github.com is NOT removed from brave://settings/content/all
  12. confirmed hbomax.com is removed from brave://settings/content/all
  13. confirmed passwords are not being removed via brave://settings/passwords
  14. confirmed that brave://history hasn't been removed/cleared
  15. reopened https://www.hbomax.com/ and confirmed that I am logged out
  16. reopened https://github.com/ site and confirmed that I am still logged in
step 1 step 2 step 3a step 3b step 5 step 6a step 6b step 7 step 8 step 11 step 12 step 13 step 14 step 15 step 16
image image image image image image image image image image image image image image image

Test Case 5 - Enable BraveForgetFirstPartyStorage and disable and enable Shields - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear and is Off in brave://settings/shields
  2. visited https://joinhoney.com and enabled Forget me when I close this site toggle via the Shields panel
  3. log into https://joinhoney.com
  4. verified joinhoney.com entry in brave://settings/content/all and local storage data in brave://settings/cookies/detail?site=www.joinhoney.com
  5. verified that password entry is shown via brave://settings/passwords
  6. disable Shields in the Shields panel for the site joinhoney.com
  7. closed the tab for joinhoney.com and wait for ~30s
  8. opened brave://settings/content/all and confirmed joinhoney.com entry and local storage is removed
  9. confirmed I am logged out of joinhoney.com and Shields is still disabled
  10. open https://joinhoney.com and re-enable shields on the Shields panel
  11. closed https://joinhoney.com/ and wait ~30s
  12. confirmed https://joinhoney.com is removed from brave://settings/content/all and local storage in brave://settings/cookies/detail?site=www.joinhoney.com
  13. confirmed that brave://history hasn't been removed/cleared
  14. confirmed that passwords are not being removed via brave://settings/passwords
step 1a step 2 step 4a step 4b step 5 Step 6 step 8a step 8b step 9 step 10 step 12a step 12b step 13
image image image image image image image image image image image image image

Test Case 6 - Enable BraveForgetFirstPartyStorage via brave://settings/shields but Forget me when I close this site not enabled in the Shields panel in Guest window - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear and is Off in brave://settings/shields
  2. enabled Forget me when I close this site via brave://settings/shields
  3. click hamburger menu >> open guest window
  4. visited https://github.com, https://walmart.com, https://amazon.com sites in the guest window

Confirmed Forget me when I close this site isn't enabled in the Shields panel

step 1a step 1b step 2 step 3 github walmart amazon
image image image image image image image

Test Case 7 - Enable Forget me when I close this site via Shields panel in Private window - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear and is Off in brave://settings/shields
  2. click hamburger menu >> Private window
  3. logged into https://brave.sp.backtrace.io/login in the Private window
  4. close the https://brave.sp.backtrace.io tab (not the browser) and relaunch
  5. verified I am still logged in to https://brave.sp.backtrace.io site
  6. toggled On Forget me when I close this site setting in the Shields panel
  7. closed the https://brave.sp.backtrace.io tab and waited for ~30 secs and reopen the site
  8. confirmed I am logged out of https://brave.sp.backtrace.io site
step 1a step 1b step 2 step 3 step 6 step 8
image image image image image image

Additional test cases - Below testcases are skipped as per the discussion.

Testcase 1 - Enable Ephemeral Storage via brave://flags - Skipped

Shared steps:

  1. new profile
  2. opened https://dev-pages.brave.software/storage/ephemeral-storage.html in a new tab
  3. opened brave://flags in a new tab and enabled #brave-ephemeral-storage
step 2 step 3
image image

Case 1: Leave the default Cross-site cookies blocked in the Shields panel

Pre-requisite: leave `Block cross-site cookies` setting the Shields panel & `Forget by default` toggle `Off`
  1. Step 1: Initial Case
  2. Step 2: Remote Page, Same Session
    • continued from Step 1 from test page
    • clicked the link in the Step 2 Open up the version of this page on the other origin
    • clicked Read values on other site
    • confirmed results matched to expected outcome in Step 2: Remote Page, Same Session except for Nested frame - N/A (N/A is valid. Site needs update to show empty)
  3. Step 3: Remote Page, New Session
  4. Step 4: This Page, Same Session Case - Failed
    • completed Step1 & Step 2 (Same session which is a initial session)
    • completed Step 3 in a new session and close the session
    • return to existing session (initial session)
    • navigate to Step 4 in the testpage and clicked the link Open up the version of this page on the other origin to open in a new tab
    • clicked Read values on the other site
      Actual Results: all of the columns show success except for Nested 1p which shows N/A
  5. Step 5: This Page, Different Session
    • continued from Step 4 from test page
    • click Copy to clipboard and paste on a new tab
    • confirmed results matched to expected outcome in Step 5: This Page, Different Session except for Nested frame which shows N/A (N/A is valid. Site needs update to show empty)
  6. Step 6: New Page, Reset Session Case
step 1 step 2 step 3a step 3b step 3c
image image image image image
step 4 (exp.results) step 4 (act.results) step 5 (exp.results) step 5 (act.results)
image image image image
Step 6 (within 30 sec - expected results (Step4)) Step 6 (within 30 sec - actual results (Step6))
image image
step 6 exp.results (wait for 30 secs) step 6 (wait for 30 secs)
image image

Case 2: Block all cookies in the Shields panel - Skipped

Pre-requisite:

  • Select Block all cookies setting the Shields panel & Forget by default toggle Off
  • Select Cookies blocked option in the test page
image
  1. Step 1: Initial Case
  2. Step 2: Remote Page, Same Session
    • continued from Step 1 from test page
    • clicked the link in the Step 2 Open up the version of this page on the other origin
    • clicked Read values on other site
    • confirmed results matched to expected outcome in Step 2: Remote Page, Same Session except for Nested frame - N/A (N/A is valid. Site needs update to show empty)
  3. Step 3: Remote Page, New Session
  4. Step 4: This Page, Same Session Case - Failed
    • completed Step1 & Step 2 (Same session which is a initial session)
    • completed Step 3 in a new session and close the session
    • return to existing session (initial session)
    • navigate to Step 4 in the testpage and clicked the link Open up the version of this page on the other origin to open in a new tab
    • clicked Read values on the other site
      Actual Results: all of the columns show success except for Nested 1p which shows N/A
  5. Step 5: This Page, Different Session
    • continued from Step 4 from test page
    • click Copy to clipboard and paste on a new tab
    • confirmed results matched to expected outcome in Step 5: This Page, Different Session except for Nested frame which shows N/A (N/A is valid. Site needs update to show empty)
  6. Step 6: New Page, Reset Session Case
Step 1 Step 2 Step 3(exp.results) Step 3 (act.results) step 4 (exp.results) step 4( act.results)
image image image image image image
Step 5 (exp.results) Step 5 (act.results) Step 6 (exp.30 sec) Step 6 (act.30 sec)
image image image image

Case 3: Allow all cookies in the Shields panel - Skipped

Test case 2 - PASSED

  1. new profile
  2. launched Brave
  3. loaded usatoday.com
  4. clicked on the Shields icon
  5. toggled Forget me when I close this site to On
  6. toggled Shields to Off for this site
  7. closed the usatoday.com tab
  8. waited 30 seconds
  9. opened a new tab with usatoday.com and verified Shields still Off
  10. opened brave://settings/content/all
  11. clicked through for usatoday.com
  12. confirmed cookies + localstorage data was intact
step 5 step 6 step 9 step 10 step 10a
image image image image image

Test case 3 - PASSED

  1. new profile
  2. launched Brave
  3. shut down and relaunched Brave
  4. opened https://permission.site/
  5. clicked on Notification
  6. confirmed the dropdown read Until I close this site
  7. clicked Allow
  8. confirmed it read/set Notification (green in screenshot)
  9. closed the site
  10. waited 30 seconds
  11. reopened https://permissions.site
  12. confirmed Notification was reset`
  13. clicked again on Notification
  14. confirmed dropdown listed Until I close this site (again)
example example example example example
image image image image image

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 13, 2023
@stephendonner
Copy link

stephendonner commented Jul 19, 2023

Verification PASSED using

Brave | 1.57.16 Chromium: 115.0.5790.98 (Official Build) beta (x86_64)
-- | --
Revision | d6c8a44fbe78ae6ee53d838307b4d17bec8de940
OS | macOS Version 11.7.8 (Build 20G1351)

and others, as noted inline


NOTE: all tests pass, with the exception of #30090 (comment), which we're skipping

Tests from brave/brave-variations#567 (comment)

Testcase 1: Enabling BraveForgetFirstPartyStorage feature via Griffin - PASSED

Case 1: Before feature being enabled via Griffin - PASSED

  1. installed 1.57.16
  2. launched Brave
  3. confirmed BraveForgetFirstPartyStorage isn't visible under brave://version
  4. loaded github.com in a new tab
  5. clicked Shields icon to open the Shields panel
  6. opened brave://settings/shields
  • Confirmed Forget me when I close this site doesn't appear via the Shields panel
  • Confirmed Forget me when I close this site doesn't appear via brave://settings/shields
step 3 step 5 step 6
Screen Shot 2023-07-19 at 2 29 31 PM Screen Shot 2023-07-19 at 2 30 06 PM Screen Shot 2023-07-19 at 2 30 36 PM

Case 2: After feature is enabled via Griffin - PASSED

(continued from Case 1 above)

  1. closed and restarted Brave
  2. confirmed BraveForgetFirstPartyStorage:Enabled is shown in brave://version
  3. opened Shields panel on abcnews.com
  4. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle appears in the Shields panel and is toggled to Off by default
  • Confirmed Forget me when I close this site toggle appears in brave://settings/shields and is Off by default
step 2 step 3 step 4
Screen Shot 2023-07-19 at 2 38 13 PM Screen Shot 2023-07-19 at 2 39 57 PM Screen Shot 2023-07-19 at 2 40 06 PM

Testcase 2: Enable Forget me when I close this site setting in the Shields panel per domain - PASSED

Case 1: Enable Forget me when I close this site setting in the Shields panel and toggle per site and wait 30s - PASSED

  1. continued from Case 2 (Test Case 1)
    • BraveForgetFirstPartyStorage is shown under brave://version
    • Forget me when I close this site toggle is Off is shown via the Shields panel for github.com
    • Forget me when I close this site toggle is Off is shown via brave://settings/shields
  2. visited into https://www.github.com and logged into the account
  3. visited https://www.nytimes.com and logged into the account
  4. confirmed password credentials for both github.com & nytimes.com are saved in brave://settings/passwords
  5. confirmed github.com & nytimes.com entries are shown in brave://settings/content/all
  6. restarted the browser and confirmed that I am still logged into both nytimes & Github
  7. toggled Forget me when I close this site On for nytimes.com & github.com in the Shields panel
  8. closed both tabs for the sites (nytimes & Github) and wait for ~30sec
  9. reopened brave://settings/content/all in a new tab
  10. confirmed both Github.com & nytimes.com have been completely removed from brave://settings/content/all
  11. reloaded both https://github.com & https://www.nytimes.com sites
  12. confirmed that I have been logged out of both the sites i.e. github.com & nytimes.com
  13. confirmed nytimes.com and github.com entries haven't been removed/cleared from brave://history
  14. confirmed that passwords are not being removed via brave://settings/passwords

confirmed nytimes.com & github.com sites are removed from brave://settings/content/all

confirmed that passwords entries are not removed via brave://settings/passwords

confirmed when nytimes.com & github.com sites are reopened, I am signed out of both sites

step 1 step 4 step 5 step 7a step 7b step 10 step 12a step 12b step 13 step 14
Screen Shot 2023-07-19 at 4 17 57 PM Screen Shot 2023-07-19 at 4 25 48 PM Screen Shot 2023-07-19 at 4 26 36 PM Screen Shot 2023-07-19 at 4 27 04 PM Screen Shot 2023-07-19 at 4 27 12 PM Screen Shot 2023-07-19 at 4 28 27 PM Screen Shot 2023-07-19 at 4 28 52 PM Screen Shot 2023-07-19 at 4 28 58 PM Screen Shot 2023-07-19 at 4 30 29 PM Screen Shot 2023-07-19 at 4 31 06 PM

Case 2 - Enable Forget me when I close this site setting in the Shields panel and reopen a site within 30 sec. - PASSED

  1. new profile
  2. launched Brave
  3. relaunched Brave and verified following:
    • BraveForgetFirstPartyStorage is shown under brave://version
    • Forget me when I close this site toggle is shown via brave://settings/shields
  4. logged into https://www.nytimes.com & github.com and saved password credentials
  5. confirmed password credentials are saved in brave://settings/passwords for both the sites
  6. confirmed nytimes.com & github entries shown in brave://settings/content/all
  7. opened the Shields panel for https://www.nytimes.com site and verified Forget me when I close this site toggle is OFF
  8. toggled On/enable Forget me when I close this site setting in the Shields panel
  9. closed both sites, nytimes.com & github.com (but not the browser)
  10. confirmed nytimes.com entry is still shown in brave://settings/content/all
  11. confirmed password credentials are still shown in brave://settings/passwords
  12. re-loaded the `nytimes.com site within ~30s (15s) and confirmed I am still logged into the site
  13. reloaded github.com site within ~30s (15s) and confirmed I am still logged into the site
  14. open brave://history in a new tab
  • Confirmed when nytimes.com is reloaded within 30 secs, nytimes.com entry is still shown in brave://settings/content/all
  • Confirmed password credentials are still shown in brave://settings/passwords
  • Confirmed when nytimes.com site is reloaded, I am still signed in to the site
  • Confirmed brave://history is not cleared
step 3a step 3b step 5 step 6 step 8a step 8b step 10 step 11 step 12 step 13 step 14
Screen Shot 2023-07-19 at 4 54 51 PM Screen Shot 2023-07-19 at 4 55 04 PM Screen Shot 2023-07-19 at 4 56 58 PM Screen Shot 2023-07-19 at 4 57 13 PM Screen Shot 2023-07-19 at 4 58 05 PM Screen Shot 2023-07-19 at 5 13 54 PM Screen Shot 2023-07-19 at 5 16 04 PM Screen Shot 2023-07-19 at 5 17 41 PM Screen Shot 2023-07-19 at 5 14 29 PM Screen Shot 2023-07-19 at 5 14 34 PM Screen Shot 2023-07-19 at 5 17 44 PM

Test Case 3 - Enabling BraveForgetFirstPartyStorage (Permissions) - PASSED

Case 1: Select until I close this site in the permission prompt for talk.brave.com while not logged in - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear under brave://settings/shields
  2. visited https://talk.brave.com/
  3. keep the default value until I close this site permissions in the permission prompt for both Microphone & Camera
  4. clicked Allow to give permissions for both Microphone & Camera
  5. clicked on the lock icon via https://talk.brave.com/ and confirmed Microphone & Camera permissions are enabled
  6. confirmed brave.com entry is shown in brave://settings/content/all
  7. confirmed when drill down brave.com>>cookies and site Data, local storage data is shown
  8. toggled Forget me when I close this site On via the shields panel
  9. closed https://talk.brave.com/ tab and waited ~30s
  10. confirmed brave.com is removed in brave://settings/content/all
  11. confirmed that both Microphone & Camera are shown default values Ask (default) in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com
  12. confirmed no entries are shown in Allowed to use your camera via brave://settings/content/camera & brave://settings/content/microphone
step 1a step 1b step 2a step 2b step 5 step 6 step 7 step 8 step 10 step 11 step 12a step 12b
Screen Shot 2023-07-20 at 10 17 54 AM Screen Shot 2023-07-20 at 10 19 35 AM Screen Shot 2023-07-20 at 10 21 07 AM Screen Shot 2023-07-20 at 10 23 23 AM Screen Shot 2023-07-20 at 10 23 54 AM Screen Shot 2023-07-20 at 10 24 17 AM Screen Shot 2023-07-20 at 10 24 46 AM Screen Shot 2023-07-20 at 10 26 15 AM Screen Shot 2023-07-20 at 10 28 44 AM Screen Shot 2023-07-20 at 10 31 27 AM Screen Shot 2023-07-20 at 10 32 01 AM Screen Shot 2023-07-20 at 10 32 10 AM

Case 2: Select Forever in the permissions prompt for talk.brave.com while logged in - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear under brave://settings/shields
  2. logged in to https://talk.bravesoftware.com/ and click Start Premium call and join the meeting
  3. selected until I close this site for microphone and Forever for Camera permissions in the permission prompt
  4. clicked Allow to give permissions for both Microphone & Camera
  5. clicked on the lock icon via https://talk.brave.com/ URL and confirmed Microphone & Camera permissions are enabled
  6. verified site settings for Camera and Microphone show Allow via brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.brave.com
  7. verified bravesoftware.com entry is shown in brave://settings/content/all
  8. verified local storage data is shown when drill down brave.com>>cookies and site Data
  9. verified brave://settings/content/camera shows talk.brave.com:443 entry
  10. verified brave://settings/content/microphone shows talk.brave.com:443 entry
  11. toggled Forget me when I close this site on via the shields panel for https://talk.brave.com/
  12. closed https://talk.brave.com/ tab including subscription page tab and waited ~30s
  13. confirmed brave.com is shown with 0 B in brave://settings/content/all
  14. confirmed local storage is removed via brave.com>>cookies and Site Data, which is the pass condition
  15. confirmed that Microphone shows Ask (default) & Camera shown values `Ask in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.brave.com which is expected given the permissions
  16. confirmed entry https://talk.brave.com:443 is shown in Allowed to use your camera via brave://settings/content/camera which is expected given the permissions
  17. confirmed no entries are shown in Allowed to use your microphone via brave://settings/content/microphone
step 1 step 2a step 2b step 5 step 6 step 7 step 8 step 11 step 13 step 14 step 15 step 16 step 17
Screen Shot 2023-07-20 at 10 53 28 AM Screen Shot 2023-07-20 at 10 54 01 AM Screen Shot 2023-07-20 at 10 54 27 AM Screen Shot 2023-07-20 at 10 55 34 AM Screen Shot 2023-07-20 at 10 56 07 AM Screen Shot 2023-07-20 at 10 57 13 AM Screen Shot 2023-07-20 at 10 57 48 AM Screen Shot 2023-07-20 at 10 57 57 AM Screen Shot 2023-07-20 at 10 58 19 AM Screen Shot 2023-07-20 at 10 59 45 AM Screen Shot 2023-07-20 at 10 59 57 AM Screen Shot 2023-07-20 at 11 00 22 AM Screen Shot 2023-07-20 at 11 00 57 AM

Test Case 4 : Enable BraveForgetFirstPartyStorage global value via brave://settings/shields - PASSED

Case 1: Enable Forget me when I close this site in brave://settings/shields but leave the setting enabled per site - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear under brave://settings/shields
  2. enabled Forget me when I close this site via brave://settings/shields
  3. visited www.hulu.com and ensure that Forget me when I close this site is enabled via the shields panel
  4. logged into www.hulu.com
  5. confirmed password credentials are saved in brave://settings/passwords
  6. confirmed www.hulu.com entries are shown within brave://settings/content/all
  7. leave Forget me when I close this site for https://netflix.com` via brave shields panel
  8. closed www.hulu.com tab and wait ~30s
  9. reopened/reloaded brave://settings/content/all tab
  10. confirmed www.hulu.com entry is removed from brave://settings/content/all
  11. confirmed that passwords are not being removed via brave://settings/passwords
  12. reopened www.hulu.com
  13. confirmed I am logged out of the website
  14. confirmed that brave://history hasn't been removed/cleared
step 1 step 2 step 3 step 4 step 5 step 6 step 10 step 11 step 13 step 14
Screen Shot 2023-07-20 at 11 43 38 AM Screen Shot 2023-07-20 at 11 44 01 AM Screen Shot 2023-07-20 at 11 45 09 AM Screen Shot 2023-07-20 at 11 46 16 AM Screen Shot 2023-07-20 at 11 47 27 AM Screen Shot 2023-07-20 at 11 54 24 AM Screen Shot 2023-07-20 at 11 55 50 AM Screen Shot 2023-07-20 at 11 56 10 AM Screen Shot 2023-07-20 at 11 56 48 AM Screen Shot 2023-07-20 at 11 57 14 AM

Case 2: Enable Forget me when I close this site in brave://settings/shields but disable the setting per site - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear and is Off under brave://settings/shields
  2. enabled Forget me when I close this site via brave://settings/shields
  3. visited https://github.com and https://www.hbomax.com/ and verified that Forget me when I close this site is enabled via the shields panel
  4. visited https://https://github.com/ and https://www.hbomax.com and logged into the websites
  5. confirmed password credentials are saved in brave://settings/passwords
  6. confirmed github.com and max.com entries are shown within brave://settings/content/all with local storage
  7. disabled Forget me when I close this site on https://www.github.com/ via Shields panel and also leave it enabled globally
  8. leave Forget me when I close this site setting On for https://hbomax.com via Shields panel
  9. closed https://www.gmail.com/ and waited ~30s
  10. closed https://www.hbomax/ and waited ~30s
  11. confirmed github.com is NOT removed from brave://settings/content/all
  12. confirmed hbomax.com is removed from brave://settings/content/all
  13. confirmed that brave://history hasn't been removed/cleared
  14. confirmed passwords are not being removed via brave://settings/passwords
  15. reopened https://www.hbomax.com/ and confirmed that I am logged out
  16. reopened https://github.com/ and confirmed that I am still logged in
step 1 step 2 step 3a step 3b step 5 step 6a step 6b step 7 step 8 step 11 step 12 step 13 step 14 step 15 step 16
Screen Shot 2023-07-20 at 12 11 28 PM Screen Shot 2023-07-20 at 12 11 40 PM Screen Shot 2023-07-20 at 12 12 22 PM Screen Shot 2023-07-20 at 12 12 28 PM Screen Shot 2023-07-20 at 12 14 23 PM Screen Shot 2023-07-20 at 12 15 24 PM Screen Shot 2023-07-20 at 12 21 12 PM Screen Shot 2023-07-20 at 12 17 09 PM Screen Shot 2023-07-20 at 12 17 31 PM Screen Shot 2023-07-20 at 12 21 37 PM Screen Shot 2023-07-20 at 1 45 33 PM Screen Shot 2023-07-20 at 1 47 35 PM Screen Shot 2023-07-20 at 1 47 48 PM Screen Shot 2023-07-20 at 12 22 36 PM Screen Shot 2023-07-20 at 12 22 42 PM

Test Case 5 - Enable BraveForgetFirstPartyStorage and disable and enable Shields - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear and is Off in brave://settings/shields
  2. visited att.com and enabled Forget me when I close this site toggle via the Shields panel
  3. log into att.com
  4. verified att.com entry in brave://settings/content/all and local storage data in brave://settings/cookies/detail?site=www.att.com
  5. verified that password entry is shown via brave://settings/passwords
  6. disable Shields in the Shields panel for the site att.com
  7. closed the tab for att.com and wait for ~30s
  8. opened brave://settings/content/all and confirmed att.com entry and local storage is removed
  9. confirmed I am logged out of att.com and Shields is still disabled
  10. opened att.com and re-enabled Shields on the Shields panel
  11. closed att.com and waited ~30s
  12. confirmed att.com is removed from brave://settings/content/all and local storage in `brave://settings/cookies/detail?site=www.att.com
  13. confirmed that brave://history hasn't been removed/cleared
  14. confirmed that passwords are not being removed via brave://settings/passwords
step 1a step 2 step 4a step 4b step 5 Step 6 step 8a step 8b step 9 step 10 step 12a step 12b step 13 step 14
Screen Shot 2023-07-21 at 12 29 33 AM Screen Shot 2023-07-21 at 12 30 15 AM Screen Shot 2023-07-21 at 12 33 50 AM Screen Shot 2023-07-21 at 12 38 32 AM Screen Shot 2023-07-21 at 12 38 56 AM Screen Shot 2023-07-21 at 12 39 19 AM Screen Shot 2023-07-21 at 12 40 19 AM Screen Shot 2023-07-21 at 12 42 37 AM Screen Shot 2023-07-21 at 12 45 07 AM Screen Shot 2023-07-21 at 12 46 53 AM Screen Shot 2023-07-21 at 12 52 39 AM Screen Shot 2023-07-21 at 1 06 53 AM Screen Shot 2023-07-21 at 12 52 59 AM Screen Shot 2023-07-21 at 12 55 14 AM

Test Case 6 - Enable BraveForgetFirstPartyStorage via brave://settings/shields but not enabled in the Shields panel in Guest window - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear and is Off in brave://settings/shields
  2. enabled Forget me when I close this site via brave://settings/shields
  3. click hamburger menu >> Open Guest window
  4. visited https://github.com, https://walmart.com, https://amazon.com sites in the guest window

Confirmed Forget me when I close this site isn't enabled in the Shields panel

step 1a step 1b step 2 github walmart amazon
Screen Shot 2023-07-20 at 2 00 21 PM Screen Shot 2023-07-20 at 2 01 18 PM Screen Shot 2023-07-20 at 2 01 31 PM Screen Shot 2023-07-20 at 2 02 01 PM Screen Shot 2023-07-20 at 2 02 15 PM Screen Shot 2023-07-20 at 2 03 02 PM

Test Case 7 - Enable BraveForgetFirstPartyStorage via Shields panel in Private window - PASSED

  1. new profile (followed STR from Test Case 1 Case 2)
    • BraveForgetFirstPartyStorage is visible under brave://version
    • Forget me when I close this site toggle appear and is Off in brave://settings/shields
  2. clicked hamburger menu >> Private window
  3. logged into brave.sp.backtrace.io in the Private window
  4. closed the brave.sp.backtrace.io tab (not the browser) and relaunched
  5. verified I am still logged in to brave.sp.backtrace.io
  6. toggled On Forget me when I close this site setting in the Shields panel
  7. closed the brave.sp.backtrace.io tab and waited for ~30 secs and reopen the site
  8. confirmed I am logged out of brave.sp.backtrace.io
step 1a step 1b step 3 step 6 step 8
Screen Shot 2023-07-20 at 2 00 21 PM Screen Shot 2023-07-20 at 2 01 18 PM Screen Shot 2023-07-20 at 2 12 22 PM Screen Shot 2023-07-20 at 2 20 35 PM Screen Shot 2023-07-20 at 2 22 32 PM

Tests from #30090 (comment) ("Additional test cases")

NOTE: details in https://bravesoftware.slack.com/archives/C7VLGSR55/p1689815943379709

Test case 1 - SKIPPED/PASSED

  1. installed 1.57.18
  2. launched Brave
  3. shut down Brave
  4. relaunched
  5. confirmed BraveForgetFirstPartyStorage:Enabled Griffin study enrollment via brave://version
  6. confirmed Forget me when I close this site toggle appears on brave://settings/shields
  7. loaded https://dev-pages.brave.software/storage/ephemeral-storage.html
  8. followed the page's instructions for steps 1-6

Expected:

Remote Frame should read Success

Actual:

Remote Frame reads empty

(continuing below)

  1. open a (blank) new-tab page
  2. close the original https://dev-pages.brave.software/storage/ephemeral-storage.html tab
  3. wait 30 seconds
  4. open https://dev-pages.brave.software/storage/ephemeral-storage.html in the tab from step 9
  5. click Read values

Confirmed:

  • N/A in teal Nested 1P Frame column is expected, per @goodov 👍
  • others?

Beta 1.57.18 (Chromium: 115.0.5790.98)

brave://version brave://settings/shields
Screen Shot 2023-07-20 at 11 45 57 PM Screen Shot 2023-07-20 at 11 45 53 PM

Actual results

Step 1 Step 2 Step 3 Step 4 Step 5 Step 6
Screen Shot 2023-07-31 at 10 59 10 AM Screen Shot 2023-07-31 at 10 59 21 AM Screen Shot 2023-07-31 at 10 59 30 AM Screen Shot 2023-07-31 at 10 59 38 AM Screen Shot 2023-07-31 at 10 59 48 AM Screen Shot 2023-07-31 at 11 00 36 AM

Reference results

Ref, Step 1 Ref, Step 2 Ref, Step 3 Ref, Step 4 Ref, Step 5 Ref, Step 6
Screen Shot 2023-08-01 at 2 07 30 AM Screen Shot 2023-08-01 at 2 08 03 AM Screen Shot 2023-08-01 at 2 08 11 AM Screen Shot 2023-08-01 at 2 08 22 AM Screen Shot 2023-08-01 at 2 08 31 AM Screen Shot 2023-08-01 at 2 08 38 AM

Release 1.56.14 (Chromium: 115.0.5790.114)

brave://version brave://settings/shields
Screenshot 2023-07-31 at 4 45 54 AM Screenshot 2023-07-31 at 4 46 14 AM
Step 1 Step 2 Step 3 Step 4 Step 5 Step 6
Screen Shot 2023-07-31 at 10 30 10 AM Screen Shot 2023-07-31 at 10 30 23 AM Screen Shot 2023-07-31 at 10 30 40 AM Screen Shot 2023-07-31 at 10 30 54 AM Screen Shot 2023-07-31 at 10 31 05 AM Screen Shot 2023-07-31 at 10 31 52 AM

Test case 2 - PASSED

  1. installed 1.57.18
  2. launched Brave
  3. loaded cnn.com
  4. clicked on the Shields icon
  5. toggled Forget me when I close this site to On
  6. toggled Shields to Off for this site
  7. closed the cnn.com tab
  8. waited 30 seconds
  9. opened a new tab with cnn.com
  10. opened brave://settings/content/all
  11. clicked through for cnn.com
  12. confirmed cookies + localstorage data was intact
example example example example example example example
Screen Shot 2023-07-20 at 3 19 34 PM Screen Shot 2023-07-20 at 3 19 53 PM Screen Shot 2023-07-20 at 3 20 37 PM Screen Shot 2023-07-20 at 3 21 59 PM Screen Shot 2023-07-20 at 3 23 46 PM Screen Shot 2023-07-20 at 3 27 08 PM Screen Shot 2023-07-20 at 3 28 52 PM

Test case 3 - PASSED

  1. installed 1.57.18
  2. launched Brave
  3. shut down and relaunched Brave
  4. opened https://permission.site/
  5. clicked on Location
  6. confirmed the dropdown read Until I close this site
  7. clicked Allow
  8. confirmed it read/set Location (green in screenshot)
  9. closed the site
  10. waited 30 seconds
  11. reopened https://permissions.site
  12. confirmed Location was reset`
  13. clicked again on Location
  14. confirmed dropdown listed Until I close this site (again)
example example example example example
Screen Shot 2023-07-20 at 2 48 23 PM Screen Shot 2023-07-20 at 2 45 08 PM Screen Shot 2023-07-20 at 2 45 23 PM Screen Shot 2023-07-20 at 2 48 23 PM Screen Shot 2023-07-20 at 2 48 27 PM

@stephendonner
Copy link

@LaurenWags
Copy link
Member

Per discussion with @rebron @pes10k @MadhaviSeelam @stephendonner @LaurenWags today, QA is going to skip tests that are associated with test pages (such as https://dev-pages.brave.software/storage/ephemeral-storage.html) as noted in #30090 (comment).

@pes10k noted via https://bravesoftware.slack.com/archives/C7VLGSR55/p1690918874502599?thread_ts=1689815943.379709&cid=C7VLGSR55 that this unintentionally overloads this test page and FBD + Ephemeral Storage should have their own specific (and likely separate) test page(s). When @goodov returns from PTO, @pes10k has graciously offered to sync up so that this can be sorted out (thank you!).

Once FBD + Ephemeral Storage tests are in place, QA can then verify, although this likely will not be in time for the initial 1.57.x release. During today's call risk for skipping these tests was deemed minimal so the group was comfortable delaying this testing until later.

@MadhaviSeelam MadhaviSeelam added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 3, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Aug 4, 2023

Verified with

Brave	1.57.36 Chromium: 115.0.5790.171 (Official Build) beta (64-bit) 
Revision	a4bb683f14dc402f5da13707e13559dc4d5ef08b
OS	Linux

Verified test plan from #30090 (comment).

Part 1 - Cases from brave/brave-variations#567 (comment) - PASSED

Test Case 1 - Enabling `BraveForgetFirstPartyStorage` feature via Griffin - PASSED

Scenario 1 - Before feature being enabled via Griffin - PASSED

  1. Installed 1.57.x
  2. launched Brave
  3. confirmed BraveForgetFirstPartyStorage isn't visible under brave://version
  4. visited github.com in a new tab
  5. clicked Shields icon to open the Shields panel
  6. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle doesn't appear via the Shields panel
  • Confirmed Forget me when I close this site toggle doesn't appear via brave://settings/shields
step 3 step 5 step 6
1 2 3

Scenario 2: After feature being enabled via Griffin - PASSED

  1. continue from Case 1:
  • BraveForgetFirstPartyStorage isn't visible under brave://version
  • Forget me when I close this site toggle doesn't appear via brave://settings/shields
  1. closed and restarted Brave
  2. confirmed BraveForgetFirstPartyStorage:Enabled is shown in brave://version
  3. opened Shields panel in the nytimes.com tab
  4. opened brave://settings/shields
  • Confirmed Forget me when I close this site toggle appears in the Shields panel and is Off by default
  • Confirmed Forget me when I close this site toggle appears in the brave://settings/shields and is Off by default
step 3 step 4 step 5
1 2 3

Dark theme

shields panel brave://settings/shields
4 5
Test Case 2: Enable `Forget me when I close this site` setting in the Shields panel per domain - PASSED

Scenario 1 - Enable Forget me when I close this site setting in the Shields panel and toggle per site and wait 30s - PASSED

  1. continued from Test Case 1, Scenario 2
    • BraveForgetFirstPartyStorage is shown under brave://version
    • Forget me when I close this site toggle is Off is shown via the Shields panel for github.com
    • Forget me when I close this site toggle is Off is shown via brave://settings/shields
  2. visited into https://www.github.com and logged into the account
  3. visited https://www.economist.com and logged into the account
  4. confirmed password credentials for both github.com & economist.com are saved in brave://settings/passwords
  5. confirmed github.com & economist.com entries are shown in brave://settings/content/all
  6. restarted the browser and confirmed that I am still logged into both economist & Github
  7. toggled Forget me when I close this site On for economist.com & github.com in the Shields panel
  8. closed both tabs for the sites (economist & Github) and wait for ~30sec
  9. reopened brave://settings/content/all in a new tab
  10. confirmed both Github.com & economist.com have been completely removed from brave://settings/content/all
  11. confirmed economist.com and github.com entries haven't been removed/cleared from brave://history
  12. confirmed that passwords are not being removed via brave://settings/passwords
  13. reopened both https://github.com & https://www.economist.com sites
  14. confirmed that I have been logged out of both the sites i.e. github.com & economist.com

confirmed economist.com & github.com sites are removed from brave://settings/content/all

confirmed that passwords entries are not removed via brave://settings/passwords

confirmed when economist.com & github.com sites are reopened, I am signed out of both the sites

step 1 step 4 step 5 step 7a step 7b step 10 step 11 step 14a step 14b
1 4 5 7a 7b 10 11 14a 14b

Scenario 2 - Enable Forget me when I close this site setting in the Shields panel and reopen a site within 30 secs - PASSED

  1. new profile
  2. launched Brave
  3. relaunched Brave to pull griffin
  4. logged into ravelry.com and saved password credentials
  5. confirmed password credentials are saved in brave://settings/passwords
  6. confirmed ravelry entry shown in brave://settings/content/all
  7. opened the Shields panel for https://www.ravelry.com site and verified Forget me when I close this site toggle is OFF
  8. toggled On/enable Forget me when I close this site setting in the Shields panel
  9. closed site ravelry.com (but not the browser)
  10. confirmed ravelry.com entry is still shown in brave://settings/content/all
  11. confirmed password credentials are still shown in brave://settings/passwords
  12. confirmed ravelry.com still shown in brave://history
  13. reopened the ravelry.com site within ~30s (15s) and confirmed I am still logged into the site
  14. reopened ravelry.com site within ~30s (15s) and confirmed I am still logged into the site

Additionally spot checked this using different times. Example: within 5s, 10s, 20s confirmed storage wasn't removed.

Also ran the below case as part of this check:

  • followed test steps from above and loaded the website within ~20 secs
  • confirmed still logged into ravelry.com
  • confirmed brave://settings/all shows the site ravelry.com
  • confirmed brave://settings/passwords shows saved passwords
  • confirmed browsing history is not clearing in brave://history
  • closed ravelry.com
  • waited 30s
  • confirmed brave://settings/all does not show ravelry.com
  • confirmed brave://settings/passwords shows saved passwords
  • confirmed browsing history is not clearing in brave://history
Test Case 3 - Enabling BraveForgetFirstPartyStorage (Permissions) - PASSED

Scenario 1: Select until I close this site in the permission prompt for talk.brave.com while not logged in - PASSED
(note, camera parts were skipped, couldn't get Linux VM to recognize my external webcam)

  1. new profile, close and relaunch to pull griffin
  2. visited https://talk.brave.com/
  3. keep the default value until I close this site permissions in the permission prompt for both Microphone & Camera
  4. clicked Allow to give permissions for both Microphone & Camera
  5. clicked on the lock icon via https://talk.brave.com/ and confirmed Microphone & Camera permissions are enabled
  6. confirmed brave.com entry is shown in brave://settings/content/all
  7. confirmed when drill down brave.com>>cookies and site Data, local storage data is shown
  8. toggled Forget me when I close this site On via the shields panel
  9. closed https://talk.brave.com/ tab and waited ~30s
  10. confirmed brave.com is removed in brave://settings/content/all
  11. confirmed that both Microphone & Camera are shown default values Ask (default) in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com
  12. confirmed no entries are shown in Allowed to use your camera via brave://settings/content/camera & brave://settings/content/microphone

Scenario 2: Select Forever in the permissions prompt for talk.bravesoftware.com while logged in - PASSED
(note, skipped camera parts, couldn't get Linux VM to recognize my external webcam)

  1. new profile close and relaunch to pull griffin
  2. logged in to https://talk.bravesoftware.com/ and click Start Premium call and join the meeting
  3. selected Forever for microphone and Until I close this site for Camera permissions in the permission prompt
  4. clicked Allow to give permissions for both Microphone & Camera
  5. clicked on the lock icon via https://talk.bravesoftware.com/ URL and confirmed Microphone & Camera permissions are enabled
  6. verified site settings for Camera and Microphone show Allow via brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com
  7. verified brave.com entry is shown in brave://settings/content/all
  8. verified local storage data is shown when drill down brave.com>>cookies and site Data
  9. verified brave://settings/content/camera shows talk.bravesoftware.com:443 entry
  10. verified brave://settings/content/microphone shows talk.bravesoftware.com:443 entry
  11. toggled Forget me when I close this site on via the shields panel for https://talk.bravesoftware.com/
  12. closed https://talk.bravesoftware.com/ tab including subscription page tab and waited ~30s
  13. confirmed brave.com is shown with 0 B in brave://settings/content/all
  14. confirmed local storage is removed via brave.com>>cookies and Site Data, which is the pass condition
  15. confirmed that Microphone shows Allow & Camera shown values `Ask in brave://settings/content/siteDetails?site=https%3A%2F%2Ftalk.bravesoftware.com which is expected given the permissions
  16. confirmed entries https://talk.bravesoftware.com:443 is shown in Allowed to use your microphone via brave://settings/content/microphone which is expected given the permissions
  17. confirmed no entries are shown in Allowed to use your microphone via brave://settings/content/camera
Test Case 4 : Enable BraveForgetFirstPartyStorage global value via brave://settings/shields - PASSED

Scenario 1: Enable Forget me when I close this site in brave://settings/shields but leave the setting enabled per site - PASSED

  1. new profile and relaunched to pull griffin
  2. enabled Forget me when I close this site via brave://settings/shields
  3. visited https://netflix.com/ and ensure that Forget me when I close this site is enabled via the shields panel
  4. logged into https://netflix.com
  5. confirmed password credentials are saved in brave://settings/passwords
  6. confirmed netflix.com entries are shown within brave://settings/content/all
  7. leave Forget me when I close this site for https://netflix.com` via brave shields panel
  8. closed https://www.netflix.com/ tab and wait ~30s
  9. reopened/reloaded brave://settings/content/all tab
  10. confirmed netflix.com entry is removed from brave://settings/content/all
  11. confirmed that passwords are not being removed via brave://settings/passwords
  12. reopened https://www.netflix.com/
  13. confirmed I am logged out of the website
  14. confirmed that brave://history hasn't been removed/cleared

Scenario 2: Enable Forget me when I close this site in brave://settings/shields but disable the setting per site - InProgress

  1. new profile and relaunched to pull griffin
  2. enabled Forget me when I close this site via brave://settings/shields
  3. visited https://github.com and https://www.hbomax.com/ and verified that Forget me when I close this site is enabled via the shields panel
  4. visited https://https://github.com/ and https://www.hbomax.com and logged into the websites
  5. confirmed password credentials are saved in brave://settings/passwords
  6. confirmed github.com and max.com entries are shown within brave://settings/content/all with local storage
  7. disabled Forget me when I close this site on https://www.github.com/ via Shields panel and also leave it enabled globally
  8. leave Forget me when I close this site setting On for https://hbomax.com via Shields panel
  9. closed https://www.gmail.com/ and waited ~30s
  10. closed https://www.hbomax/ and waited ~30s
  11. confirmed github.com is NOT removed from brave://settings/content/all
  12. confirmed hbomax.com is removed from brave://settings/content/all
  13. confirmed passwords are not being removed via brave://settings/passwords
  14. confirmed that brave://history hasn't been removed/cleared
  15. reopened https://www.hbomax.com/ and confirmed that I am logged out
  16. reopened https://github.com/ site and confirmed that I am still logged in
Test Case 5 - Enable BraveForgetFirstPartyStorage and disable and enable Shields - PASSED
  1. new profile close and relaunch to pull griffin
  2. visited https://ravelry.com and enabled Forget me when I close this site toggle via the Shields panel
  3. log into https://ravelry.com
  4. verified ravelry.com entry in brave://settings/content/all and local storage data in brave://settings/cookies/detail?site=www.ravelry.com
  5. verified that password entry is shown via brave://settings/passwords
  6. disable Shields in the Shields panel for the site ravelry.com
  7. closed the tab for ravelry.com and wait for ~30s
  8. opened brave://settings/content/all and confirmed ravelry.com entry and local storage is not removed
  9. confirmed I am not logged out of ravelry.com and Shields is still disabled
  10. open https://ravelry.com and re-enable shields on the Shields panel
  11. closed https://ravelry.com/ and wait ~30s
  12. confirmed https://ravelry.com is removed from brave://settings/content/all and local storage in brave://settings/cookies/detail?site=www.ravelry.com
  13. confirmed that brave://history hasn't been removed/cleared
  14. confirmed that passwords are not being removed via brave://settings/passwords
Test Case 6 - Enable BraveForgetFirstPartyStorage via `brave://settings/shields` but `Forget me when I close this site` not enabled in the Shields panel in Guest window - PASSED
  1. new profile close and relaunch to pull griffin
  2. enabled Forget me when I close this site via brave://settings/shields
  3. click hamburger menu >> open guest window
  4. visited https://walmart.com in the guest window

Confirmed Forget me when I close this site isn't enabled in the Shields panel

Step 1 Step 2 Step 4
1 2 3
Test Case 7 - Enable `Forget me when I close this site` via Shields panel in Private window - PASSED
  1. new profile close and relaunch to pull griffin
  2. click hamburger menu >> Private window
  3. logged into https://brave.sp.backtrace.io/login in the Private window
  4. close the https://brave.sp.backtrace.io tab (not the browser) and relaunch
  5. verified I am still logged in to https://brave.sp.backtrace.io site
  6. toggled On Forget me when I close this site setting in the Shields panel
  7. closed the https://brave.sp.backtrace.io tab and waited for ~30 secs and reopen the site
  8. confirmed I am logged out of https://brave.sp.backtrace.io site

Part 2 - "Additional Cases" as listed in #30090 (comment) - 2 PASSED, 1 SKIPPED

Test Case 1 - SKIPPED, see note

Skipped as per #30090 (comment)

Test Case 2 - PASSED
  1. Enable "Forget by default" for a website. (I used economist.com)
    • Logged in, did not save password
  2. Disable shields on the website.
  3. Close the website, wait 30 seconds.
    • Checked brave://settings/content/all and confirmed data was still displayed there
  4. Reopened site in a new tab.
  5. Expect "Forget by default" was not executed, i.e. cookies, local storage and other DOM storage data is intact.
    • Confirmed still logged in
Test case 3 - PASSED
  1. Open https://permission.site/
  2. Trigger any permission, choose permission lifetime "until I close the site". (I used "Location")
  3. Close the website, wait 30 seconds, reopen it.
  4. Expect permission is reset.

@LaurenWags LaurenWags added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 4, 2023
@Uni-verse
Copy link
Contributor

Verified for 1.57.x on Android using the following devices:

Samsung Galaxy S21 (ARM64) - #26465 (comment)
Samsung Galaxy Tab S7 (ARM64) - #26465 (comment)
Pixel 5 (x86) - #26465 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment