Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Estimated earnings data shows blank in the BR panel upon upgrade #29978

Closed
MadhaviSeelam opened this issue Apr 25, 2023 · 8 comments · Fixed by brave/brave-core#18233
Closed

Comments

@MadhaviSeelam
Copy link

MadhaviSeelam commented Apr 25, 2023

Description

Found this issue while verifying manual test run #29930 ads testcases. Have a profile which has 3 ads and the estimated earnings show 0.135 in the rewards panel when I launched with 1.50.x. Upgraded to 1.52.x. Ads received correctly shows 3 in the brave://rewards page and Ads history in shows correct count but Estimated Earnings show blank

Steps to Reproduce

  1. Install 1.50.x
  2. launch Brave with ads data (3 ads shown) in the BR panel
  3. upgrade to 1.52.69

Actual result:

Estimated ads earnings field shows blank (0.000 BAT)

1.50.x 1.52.x
image image

Expected result:

Correct amount should be displayed (i.e. before upgrade amount 0.135 BAT)

Reproduces how often:

Brave version (brave://version info)

Brave | 1.52.69 Chromium: 113.0.5672.53 (Official Build) nightly (64-bit)
-- | --
Revision | 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@tmancey

cc: @rebron @brave/qa-team

@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Apr 25, 2023

@btlechowski @GeetaSarvadnya Thanks for confirming this issue. Please feel free to add any relevant notes.

@btlechowski
Copy link

This is a regression in 1.52.x. Not reproducible in 1.51.x. Probably due to #21238

@tmancey tmancey self-assigned this Apr 25, 2023
@tmancey tmancey added QA/Yes release-notes/exclude priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Apr 25, 2023
@brave-builds brave-builds added this to the 1.52.x - Nightly milestone Apr 26, 2023
@kjozwiak kjozwiak added the OS/Android Fixes related to Android browser functionality label Apr 26, 2023
@MadhaviSeelam
Copy link
Author

Verification PASSED using

Brave | 1.52.76 Chromium: 113.0.5672.53 (Official Build) nightly (64-bit)
-- | --
Revision | 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Verified with original STR #29978 (comment)

Confirmed Estimated earnings data is not lost after upgrade and is showing correct amount i.e. same as before upgrade 0.135 BAT

1.50.121 1.52.76
image image

@kjozwiak
Copy link
Member

kjozwiak commented Apr 26, 2023

Verification PASSED using

Brave | 1.52.76 Chromium: 113.0.5672.53 (Official Build) nightly (64-bit)
-- | --
Revision | 12f5dac35d12e8f4e72d7dd11df557ef93bc046f-refs/branch-heads/5672@{#703}
OS | Windows 11 Version 22H2 (Build 22621.1555)

Verified with original STR #29978 (comment)

Confirmed Estimated earnings data is not lost after upgrade and is showing correct amount i.e. same as before upgrade 0.135 BAT

Thanks for running through the above @MadhaviSeelam 👍 Unblocks channel migrations.

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 5G using the following version(s):

Brave	1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (64-bit) 
Revision	c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS	Android 13; Build/TP1A.220624.014; 33; REL

Using STR in #29978 (comment)

  • Verified Estimated earnings data is retained when upgrading from 1.50.106 -> 1.52.102.
  • Verified Ads are shown and Estimated earnings is updated when ads are shown after upgrading from 1.50.106.
1.50.106 1.52.102 1.52.102 (Ad)
screenshot-1684766393471 screenshot-1684766621304 screenshot-1684766671205

@stephendonner
Copy link

Verification PASSED using

Brave 1.52.108 Chromium: 114.0.5735.26 (Official Build) beta (x86_64)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS macOS Version 11.7.7 (Build 20G1345)

Followed the original steps to reproduce from #29978 (comment)

Confirmed Estimated Earnings is populated with its value retained, when upgrading

example example example
Screen Shot 2023-05-22 at 5 42 14 PM Screen Shot 2023-05-22 at 5 44 06 PM Screen Shot 2023-05-22 at 5 44 28 PM

@hffvld
Copy link
Contributor

hffvld commented May 23, 2023

Verified on Galaxy Tab S8 using version(s):

Device/OS: SM-X700 Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
Brave build: 1.52.109
Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision: 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}

STEPS:

  1. Install 1.50.x
  2. Launch Brave with ads data (3 ads shown) in the BR panel
  3. Upgrade to 1.52.x > Verify

ACTUAL RESULTS:

  • Verified that Ads received this month, Current earnings this month (estimated) and Estimated Earnings shows correct info after an upgrade.
1.50.107 1.50.107 1.52.109 1.52.109
1 2 3 4

@btlechowski
Copy link

Verification passed on

Brave 1.52.109 Chromium: 114.0.5735.26 (Official Build) beta (64-bit)
Revision 7075cbb66f0542ac3e01ddfde6b813e7d61118a5-refs/branch-heads/5735@{#454}
OS Ubuntu 18.04

Followed the original steps to reproduce from #29978 (comment)

Confirmed Estimated Earnings is populated with its value retained, when upgrading

image

@tmancey tmancey added this to Ads Jun 10, 2024
@tmancey tmancey moved this to Done in Ads Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment