sometimes cmd+C doesn't copy expected text

[LaurenWags]

Description

Sometimes when highlighting text on GH (from an issue description for example) and copying to a new GH issue, if I highlight text and copy it with the keyboard shortcut (cmd+C), when I paste into the new issue the URL of the issue I copied text from is pasted instead of the text I highlighted.

Note, highlighting the text and using the right click context menu > Copy will copy the text as expected, just seems to be a problem w/ cmd+C. I only encountered in one browsing session - but it happened several times when going back and forth between two GH issues. Couldn't reproduce with a clean profile and isn't reproducing right now either.

Could be related to #27902.

Steps to Reproduce

Unsure of exact steps. Generally I was doing the following:

1. Have a GH issue open in one window
2. Have a blank issue open in a second window
3. Use 3 dots on first GH issue and select "Edit"
4. Click in the description box and copy description text (either via mouse or click in the description box and use cmd+A to get the whole description)
5. Use cmd+C to copy highlighted text
6. Go to new issue and cmd+V in issue description
   ---> sometimes first issue URL is pasted, not the copied text

Actual result:

URL pasted into new issue

Expected result:

copied text should be pased

Reproduces how often:

Difficult/Intermittent. When it happened it reproduced for a bit but then it stopped. Maybe switching between the browser and Slack had some effect, but haven't been able to reproduce.

Brave version (brave://version info)

Brave | 1.49.102 Chromium: 110.0.5481.104 (Official Build) dev (x86_64)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | macOS Version 12.6.3 (Build 21G419)

Version/Channel Information:

• Can you reproduce this issue with the current release?
• Can you reproduce this issue with the beta channel?
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @stephendonner @rebron

[rebron]

cc: @spylogsster

[LaurenWags]

sent video of what I'm seeing (no steps though) to @spylogsster

the only way I've seen to get out of this state, is to click in the URL bar and then click away. then the browser seems to properly register that the URL bar isn't in focus.

Here's what it looks like - the URL bar is outlined in orange (in focus) even though I don't have it in focus - have clicked elsewhere on the page to copy text. If I open "Edit" from macOS app menu in this case "Copy clean link" should not be available, but it is bc the browser thinks that the URL bar is in focus.

[marcfitt]

I have the same issue. Honestly, it's quite annoying that it's now the default copy and paste. Why not create a shortcut for it or at least let people change the shortcut to what they want?

I'm currently considering using another browser because it hinders my productivity while working. I'm on a website wanting to copy text and it copies the url. It's just frustrating, and there's no way to disable this thing. I just want to copy the text I want to copy, please 🙏

[AustinGitHub]

is this fixed? I just opened an issue for this because me and other users are seeing it on the latest release #29074
Why are we changing an industry standard keyboard shortcut to something other than the standard? This is one way to drive people away from using the browser and I would like to see it fixed rather than switch browsers to another one because this is very troubling and annoying to even use the browser since I can't even copy and paste properly. Thanks!

[kjozwiak]

The above requires 1.49.126 or higher for 1.49.x verification 👍

[kjozwiak]

is this fixed? I just opened an issue for this because me and other users are seeing it on the latest release #29074 Why are we changing an industry standard keyboard shortcut to something other than the standard? This is one way to drive people away from using the browser and I would like to see it fixed rather than switch browsers to another one because this is very troubling and annoying to even use the browser since I can't even copy and paste properly. Thanks!

It should be fixed on Nightly & BETA and we'll release the above fix via the 1.49.x maintenance release which is scheduled for Wednesday March 22, 2023 as per https://github.com/brave/brave-browser/wiki/Brave-Release-Schedule#release-channel-dates.

[LaurenWags]

Verified with

Brave | 1.49.126 Chromium: 111.0.5563.64 (Official Build) (x86_64)
-- | --
Revision | c710e93d5b63b7095afe8c2c17df34408078439d-refs/branch-heads/5563@{#995}
OS | macOS Version 12.6.3 (Build 21G419)

As per the description above, I encountered this sometimes when using 1.49.x but did not find specific steps to reproduce. As such, I've generally tried the below to verify this PR, but since there aren't STR, I can't guarantee it's resolved 100%.

Spot check of "Copy clean link" functionality - PASSED

1. Visited https://dev-pages.bravesoftware.com/clean-urls/?brave_testing1=foo&brave_testing2=bar&brave_testing3=keep&&;b&d&utm_content=removethis&e=&f=g&=end
2. Clicked the URL bar and confirmed "Copy clean link" available from macOS app menu
3. Right-clicked the URL and confirmed "Copy clean link" is in the context menu
4. Confirmed "Copy clean link" is displayed in the share menu from URL bar
5. Used "Cmd + C" while the URL bar is in focus to copy the URL
6. Opened a new tab and pasted the copied URL
7. Confirmed link is https://dev-pages.bravesoftware.com/clean-urls/?brave_testing3=keep&&;b&d&e=&f=g&=end as per the original issue verification from "Copy clean URL" feature #23315
8. Opened a new tab and visited https://twitter.com/LBC/status/1577628501364146176?s=20&t=fpVMBMSfgI_pNGQxxpV6bw
9. Selected "Copy clean link" from share menu in URL bar
10. Opened a new tab and pasted the copied link
11. Confirmed link pasted is https://twitter.com/LBC/status/1577628501364146176 as per the original issue verification from "Copy clean URL" feature #23315

Step 2	Step 3	Step 4	Step 7	Step 8	Step 9	Step 11

General scenarios - PASSED

Tried the below to reproduce the issue. Note, I encountered the copy problem while doing some of the below, but it didn't reproduce reliably.

1. Copying text from one GH issue description to another (same window, different tab)
2. Copying text from one GH issue description to another (different windows)
3. Restoring a GH issue from my macOS dock, copying text on GH issue, and then pasting it into a different GH issue in another window (not minimized)
4. Switching between Brave and Slack, copying text from Brave to Slack

[TheOtherBrianJ]

This is still broken in 1.49.128 (MacOS 10.15.7)

[shaisamuel]

We are on 1.50.121 and this is still not fixed or added as an option to settings. This is so annoying :)

[AustinGitHub]

Go to brave://flags/ and disable Override default copy hotkey with copy clean link