Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign Copy keyboard shortcut to "copy clean link" - Mac App Menu part #27902

Closed
spylogsster opened this issue Jan 19, 2023 · 5 comments · Fixed by brave/brave-core#16746
Closed
Assignees
Labels

Comments

@spylogsster
Copy link

Mac has App Menu in top left display corner with Copy item( hotkey cmd+c) and we show Copy Clean Link if user has url selected in the location bar. Need reassign default hotkeys from copy item to copy clean link item as well.

@spylogsster spylogsster self-assigned this Jan 19, 2023
@spylogsster spylogsster added priority/P2 A bad problem. We might uplift this to the next planned release. release-notes/include copy-clean-link labels Jan 19, 2023
@brave-builds brave-builds added this to the 1.49.x - Nightly milestone Jan 21, 2023
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Feb 13, 2023
@stephendonner
Copy link

Verified PASSED using

Brave 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64)
Revision 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
OS macOS Version 11.7.3 (Build 20G1116)

Case 1: Copy Clean Link

  1. installed 1.49.96
  2. launched Brave
  3. loaded https://brave.com/?foo=bar?baz=foopy?blah=blue
  4. selected the URL
  5. context-clicked the URL
  6. opened Apple menubar -> Edit -> Copy Clean Link ⌘C
  7. confirmed Copy Clean Link ⌘C had shortcut keys ⌘C
  8. copied and pasted the text

Confirmed copying and pasting retained parameters (these are not known trackers; this was a negative test)

Screen Shot 2023-02-13 at 1 26 26 PM

Case 2: Copy

(continued from above)

  • selected only a substring of the full URL

Screen Shot 2023-02-13 at 1 26 05 PM

Confirmed with just text (no canonical URL) we show the Copy ⌘C shortcut in the menu

Case 3: No selection

(continued from above)

  • cleared user selection of all text

Confirmed with no selection, the shortcut is Copy ⌘C in the menu

Screen Shot 2023-02-13 at 1 24 49 PM

@LaurenWags
Copy link
Member

Updated to release-notes/exclude per discussion with @rebron in favor of #26761.

@Taifun07
Copy link

Hello, I am having issues with this feature. In fact, the problem is that this feature suddenly became available and is now set as my default cmd+C function.
I do not want to use it.
How can I disable it?
I am running Mac 13.2.1 on a Brave browser.

@LaurenWags
Copy link
Member

@Taifun07 we're tracking the problem with this under #29074

@dinhanhthi
Copy link

In the version 1.56.14, I cannot use cmd+C to copy the URL / selection on the address bar. Every time I use cmd+C, it opens the Inspect Element panel. It's annoying!!! The older version doesn't have this issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants