-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assign Copy keyboard shortcut to "copy clean link" - Mac App Menu part #27902
Comments
Verified
|
Brave | 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64) |
---|---|
Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839} |
OS | macOS Version 11.7.3 (Build 20G1116) |
Case 1: Copy Clean Link
- installed
1.49.96
- launched Brave
- loaded
https://brave.com/?foo=bar?baz=foopy?blah=blue
- selected the URL
- context-clicked the URL
- opened
Apple menubar
->Edit
->Copy Clean Link ⌘C
- confirmed
Copy Clean Link ⌘C
had shortcut keys⌘C
- copied and pasted the text
Confirmed copying and pasting retained parameters (these are not known trackers; this was a negative test)
Case 2: Copy
(continued from above)
- selected only a substring of the full URL
Confirmed with just text (no canonical URL) we show the Copy ⌘C
shortcut in the menu
Case 3: No selection
(continued from above)
- cleared user selection of all text
Confirmed with no selection, the shortcut is Copy ⌘C
in the menu
Hello, I am having issues with this feature. In fact, the problem is that this feature suddenly became available and is now set as my default cmd+C function. |
In the version 1.56.14, I cannot use |
Mac has App Menu in top left display corner with Copy item( hotkey cmd+c) and we show Copy Clean Link if user has url selected in the location bar. Need reassign default hotkeys from copy item to copy clean link item as well.
The text was updated successfully, but these errors were encountered: