Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use shared constants in mojom in Solana instruction decoding #28591

Open
yrliou opened this issue Feb 17, 2023 · 0 comments
Open

Use shared constants in mojom in Solana instruction decoding #28591

yrliou opened this issue Feb 17, 2023 · 0 comments
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon".

Comments

@yrliou
Copy link
Member

yrliou commented Feb 17, 2023

Android version of brave/brave-ios#6967.

We have some constants newly added in mojom to support checking param name during Solana instruction decoding in the UI side (#28578).
brave/brave-core@d0011d9#diff-9f2cf11d57c8efee5461b92cdb38fa327b70c25fd8d009f7692049e8e88944a8R1602-R1612

This issue is for Android to update the current code to use these new shared constants if possible.
I only did a quick search so there might have more occurrences other than below.

  1. https://github.com/brave/brave-core/blob/master/android/java/org/chromium/chrome/browser/crypto_wallet/util/WalletConstants.java#L76-L80
  2. https://github.com/brave/brave-core/blob/master/android/java/org/chromium/chrome/browser/crypto_wallet/util/WalletConstants.java#L95-L100 (this one is not included in 17267, but would be added by https://github.com/brave/brave-core/pull/17128/files#diff-9f2cf11d57c8efee5461b92cdb38fa327b70c25fd8d009f7692049e8e88944a8R913-R918.
  3. solanaInstructionAccountParam.name.equalsIgnoreCase("signers"); in SolanaInstructionPresenter.java.

cc @Pavneet-Sing

@yrliou yrliou added priority/P4 Planned work. We expect to get to it "soon". feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/solana labels Feb 17, 2023
@yrliou yrliou added this to Web3 Feb 17, 2023
@yrliou yrliou moved this to Backlog in Web3 Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P4 Planned work. We expect to get to it "soon".
Projects
Status: Backlog
Development

No branches or pull requests

1 participant