Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose type info and some shared strings used in Solana instruction data backend decoder #28578

Closed
yrliou opened this issue Feb 17, 2023 · 0 comments · Fixed by brave/brave-core#17267
Closed

Expose type info and some shared strings used in Solana instruction data backend decoder #28578

yrliou opened this issue Feb 17, 2023 · 0 comments · Fixed by brave/brave-core#17267
Assignees
@yrliou
Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.50.x - Release

Comments

@yrliou
Copy link
Member

yrliou commented Feb 17, 2023

During review of brave/brave-core#17128, I came up with ideas below to avoid duplicate constants being added again in UI.

  1. Expose type info to UI so UI can check if a parameter is an account address to do some better formatting.
  2. Add shared string in mojo so backend and UI don't need to hardcode the value separately and to avoid typo in both sides.
@yrliou yrliou added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop feature/web3/wallet/core labels Feb 17, 2023
@yrliou yrliou self-assigned this Feb 17, 2023
@yrliou yrliou added this to Web3 Feb 17, 2023
@yrliou yrliou changed the title Expose type info and some shared string used in Solana instruction data backend decoder Expose type info and some shared strings used in Solana instruction data backend decoder Feb 17, 2023
@yrliou yrliou mentioned this issue Feb 17, 2023
Merged
25 tasks
@StephenHeaps StephenHeaps mentioned this issue Feb 17, 2023
Closed
@jamesmudgett jamesmudgett moved this to In Review in Web3 Feb 17, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Feb 17, 2023
@brave-builds brave-builds added this to the 1.50.x - Nightly milestone Feb 17, 2023
@yrliou yrliou mentioned this issue Feb 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yrliou yrliou

Labels
feature/web3/wallet/core feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.50.x - Release
2 participants
@yrliou @brave-builds