Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

navigator.connection is present in service/web workers. #28552

Closed
mkarolin opened this issue Feb 15, 2023 · 5 comments · Fixed by brave/brave-core#17242
Closed

navigator.connection is present in service/web workers. #28552

mkarolin opened this issue Feb 15, 2023 · 5 comments · Fixed by brave/brave-core#17242

Comments

@mkarolin
Copy link
Contributor

This is a follow up issue for #20122 which removed navigator.connection, but the attribute is still available in workers. Workers should not exhibit a different behavior regarding this attribute.

STR:

  1. Start Brave
  2. Navigate to the test page https://dev-pages.brave.software/dom-properties/controlled.html created by @pes10k
  3. Click Run test

Expected results:
In the connection row values for Service and Web Workers should be null

Actual results:
The values are NetworkInformation (meaning the attribute is available).

@kjozwiak
Copy link
Member

The above requires 1.48.168 or higher for 1.48.x verification 👍

@LaurenWags
Copy link
Member

LaurenWags commented Feb 22, 2023

Verified with

Brave | 1.48.169 Chromium: 110.0.5481.104 (Official Build) (x86_64)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | macOS Version 12.6.3 (Build 21G419)

Verified test plan from #28552 (comment).

1.48.164 1.48.169
164 169

@btlechowski
Copy link

Verification passed on

Brave 1.48.169 Chromium: 110.0.5481.104 (Official Build) (64-bit)
Revision 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS Ubuntu 18.04 LTS

Verified test plan from #28552 (comment).

image

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.48.169 Chromium: 110.0.5481.104 (Official Build) (64-bit)
-- | --
Revision | 46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS | Windows 11 Version 21H2 (Build 22000.1574)

Verified with test plan from #28552 (comment)

Confirmed connection row values for Service and Web Workers are null

1.48.167 1.48.169
image image

@Uni-verse
Copy link
Contributor

Verified on Samsung Galaxy S21 5G using version:

Brave	1.48.169 Chromium: 110.0.5481.104 (Official Build) (64-bit) 
Revision	46de4a7f41979e829b430bc1ee30ef483aa227ac-refs/branch-heads/5481_77@{#19}
OS	Android 13; Build/TP1A.220624.014

Test Plan: #28552 (comment)

  • Confirmed connection row values for Service and Web Workers are showing as null
Example Example
screenshot-1677083962862 screenshot-1677083990587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment