-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache private search provider's template url data #28360
Cache private search provider's template url data #28360
Comments
fix brave/brave-browser#28360 Cached default private search provider is added to list when it's not included in default provider list. So far Brave is set when previous default one is not included in the default list. We should set previous one as a default when new default list is changed and it's not included.
New id is assigned when it's added. f/u PR for #17015 fix brave/brave-browser#28360
@simonhong are there any other pre-requisites for this? I visited Maybe I missed some steps? Any additional information is appreciated. |
@LaurenWags Hmm, it's strange. There is no prerequisites for this. |
Thanks @simonhong I'll try again - I thought I copied and pasted the search item, but perhaps I mistyped it instead 🤔 |
Verified with
Verified test plan from brave/brave-core#17015 (comment). Clean Profile - PASSEDRan through below cases using a clean install of 1.50.x. Upgrade Profile - PASSEDRan through the below cases after upgrading from 1.49.120. Default Private Window SE - PASSEDConfirmed
Modified Private Window SE - PASSEDModified the Private Window SE on 1.49.120 and then upgraded to 1.50.91. Confirmed
Verification passed on
Verified test plan from brave/brave-core#17015 (comment). Clean Profile - PASSEDRan through below cases using a clean install of 1.50.x. Upgrade Profile - PASSEDRan through the below cases after upgrading from 1.49.120. |
Verification
Verified test plan from brave/brave-core#17015 (comment). Clean Profile - PASSEDUpgrade Profile - PASSEDRan through the below cases after upgrading from 1.49.120. Default Private Window SE - PASSEDConfirmed
Modified Private Window SE - PASSEDModified the Private Window SE on 1.49.120 and then upgraded to 1.50.91. Confirmed
|
As we can update default search provider list in the future, we should cache private search provider's template url data.
If we can use cached template url data for private window's search provider, we can set and use previous default search provider
even if new default search provider list doesn't include it.
default_private_search_provider_data
is cacheddefault_private_search_provider_data.synced_guid
anddefault_private_search_provider_guid
is sameThe text was updated successfully, but these errors were encountered: