Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewards panel hard to distinguish against light #28283

Closed
kjozwiak opened this issue Feb 3, 2023 · 2 comments
Closed

rewards panel hard to distinguish against light #28283

kjozwiak opened this issue Feb 3, 2023 · 2 comments
Labels
closed/duplicate Issue has already been reported

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Feb 3, 2023

Description

When opening the rewards panel on a website that's completely white, you'll notice that it's hard to distinguish between Brave and the website. I'm assuming the same issue can happen in Dark mode if vising a website that has the same background as the panel due to going into Dark mode or using the Dark theme. Adding some type of border would probably help.

Steps to reproduce

  1. install 1.48.154 Chromium: 110.0.5481.52 (or any version with rewards 2.5)
  2. once installed, ensure that you've enabled rewards and connected to a custodian
  3. visit startpage.com and open the rewards panel
  4. you'll notice it's hard to distinguish between the rewards panel and the website

Actual result

image

Expected result

The rewards panel should be easier to distinguish. With the current design, it's hard to tell where it starts/ends.

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A (going out via 1.48.x)
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: Android 13

Brave version

Brave | 1.48.154 Chromium: 110.0.5481.52 (Official Build) (32-bit)
--- | ---
Revision | 979113183ded4544a2c443aceb1629c430907e52-refs/branch-heads/5481@{#636}
OS | Android 13; Build/TQ1A.230105.002

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @Miyayes @deeppandya @LaurenWags

@kjozwiak kjozwiak added enhancement feature/user-interface All UI related feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality labels Feb 3, 2023
@kjozwiak kjozwiak changed the title rewards panel hard to distinguish against light/dark backgrounds rewards panel hard to distinguish against light Feb 3, 2023
@Miyayes
Copy link
Collaborator

Miyayes commented Feb 3, 2023

Thanks. This is actually a dupe of #27257, so we'll get to it :)

@Miyayes Miyayes closed this as not planned Won't fix, can't repro, duplicate, stale Feb 3, 2023
@kjozwiak
Copy link
Member Author

kjozwiak commented Feb 4, 2023

Thanks. This is actually a dupe of #27257, so we'll get to it :)

Perfect 👍 Thanks.

@kjozwiak kjozwiak added closed/duplicate Issue has already been reported and removed enhancement feature/user-interface All UI related feature/rewards QA/Yes OS/Android Fixes related to Android browser functionality labels Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/duplicate Issue has already been reported
Projects
None yet
Development

No branches or pull requests

2 participants