Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add drop shadow around Rewards dropdown panel #27257

Closed
Miyayes opened this issue Dec 8, 2022 · 3 comments · Fixed by brave/brave-core#18193
Closed

[Android] Add drop shadow around Rewards dropdown panel #27257

Miyayes opened this issue Dec 8, 2022 · 3 comments · Fixed by brave/brave-core#18193
Assignees
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-All-Platforms QA/Yes release-notes/include

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 8, 2022

Description

The Rewards dropdown panel melds into the underlying webpage on Android because there is no dropshadow separating it from the background:

image

It should be more like desktop, where there's a dropshadow that sets it apart:

image

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality labels Dec 8, 2022
@Miyayes Miyayes added QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Dec 8, 2022
@Miyayes
Copy link
Collaborator Author

Miyayes commented Dec 14, 2022

Android 6/7 APIs different, so we need to make sure it works on all the devices.

@stephendonner
Copy link

Verified PASSED on Google Pixel XL (arm64) running Android 9:

Brave	1.52.102 Chromium: 113.0.5672.126 (Official Build) beta (32-bit)
Revision	c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}
OS	Android 9; Build/PQ2A.190305.002; 28; REL

Steps:

  1. installed 1.52.102
  2. launched Brave
  3. enabled Rewards staging via QA Debug menu
  4. relaunched Brave
  5. logged into Uphold's staging sandbox
  6. loaded laurenwags.github.io
  7. tapped on the Rewards icon
  8. tapped to enable Rewards
  9. tapped again to invoke the dropdown Rewards panel

Confirmed the dropshadow is now present around the panel

1.52.102 1.51.114
Screenshot_20230518-125009 Screenshot_20230518-125219

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 22, 2023
@hffvld
Copy link
Contributor

hffvld commented May 22, 2023

Verified on Nexus 5X, Galaxy Tab S8 and Google Pixel 7 using version(s):

Device/OS: 
- Google Nexus 5X [Android 6.0; Android 7.1.1; Android 8.1]
- SM-X700 Galaxy Tab S8 [gts8wifixx-user 13 TP1A.220624.014 release-keys]
- Google Pixel 7 [panther_beta-user 13 UPB2.230407.014 release-keys]
Brave build: 1.52.102
Chromium: 113.0.5672.126 (Official Build) beta (64-bit)
Revision: c541687b21a73452ab403e2dced7033ddc97ee9d-refs/branch-heads/5672@{#1202}

Filed follow-up issue #30495


STEPS:

  1. Install build 1.52.102
  2. Launch Brave > Hamburger Menu > Settings
  3. Enable Rewards Staging via QA Debug menu > Relaunch Brave
  4. Tap on the Rewards icon > Enable Rewards
  5. Connect account > Sign in to Uphold or Gemini account
  6. Open wikipedia.com, for example
  7. Tap Rewards icon to invoke the dropdown Rewards panel

ACTUAL RESULTS:

  • Verified that drop shadow is shown for the Rewards panel in Light and Dark Modes
Android 6 - Not supported
1
1
Android 7 - PASS
Light Mode
1
Android 8 - PASS
Light Mode Dark Mode
1
Android 13 - PASS
Light Mode Dark Mode
1 2
Android 14 - PASS
Light Mode Dark Mode
1 2

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android 8 - Test/Verification Checking on an older Android device to make sure everything is working as expected feature/rewards OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants