Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube publisher not recognized based on placement of attribute–value pairs in URL #2820

Closed
btlechowski opened this issue Jan 4, 2019 · 1 comment · Fixed by brave/brave-core#1230

Comments

@btlechowski
Copy link

Steps to Reproduce

  1. Enable rewards
  2. Open https://www.youtube.com/watch?time_continue=580&v=Zp9ZJiFFBnU
  3. Open rewards panel and try to tip

Actual result:

Can not tip because the publisher is not recognized.
image

The reason is placement of attribute–value pairs in URL:
time_continue=580&v=Zp9ZJiFFBnU
If we switch them then it works properly:
v=Zp9ZJiFFBnU&time_continue=580

Expected result:

The publisher is always recognized

image

Reproduces how often:

always

Brave version (brave://version info)

Brave 0.58.18 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS Windows 7

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Additional Information

Issue reported by community: https://community.brave.com/t/depending-on-url-youtube-links-wont-show-a-site-listed-under-wallet/41430

cc @brave/legacy_qa @NejcZdovc @jasonrsadler

@btlechowski
Copy link
Author

btlechowski commented Jan 17, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Used STR from brave/brave-core#1230
Used permutations of the original URL

image

Verification passed on 17.10

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

Used STR from brave/brave-core#1230

image

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

screen shot 2019-01-23 at 5 28 52 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment