Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background image options do not appear when system default language is set to Spanish #28144

Closed
Brave-Matt opened this issue Jan 30, 2023 · 1 comment · Fixed by brave/brave-core#16932

Comments

@Brave-Matt
Copy link

Description

A user reported that they were unable to change their background image settings for the NTP because the options for it (NTP --> Customize --> Background image) were not appearing for them:
image

After some troubleshooting, it was discovered that this behavior occurs when the OS (I believe) default Language settings were set to Spanish. Changing the language settings back to English, then returning to NTP --> Customize --> Background image, the options now appear again as expected.
image

Unclear as to whether or not this is specific to the Espanol (Spanish) language setting or if this occurs when any other language is selected (will test myself later).

Brave version (brave://version info)

v1.47.186
macOS versión: 12.6.2 (Monterey)

Miscellaneous Information:

Initial user report:
https://community.brave.com/t/the-background-image-option-does-not-appear/465543/8

@stephendonner
Copy link

stephendonner commented Feb 14, 2023

Verified PASSED using

Brave 1.49.96 Chromium: 110.0.5481.77 (Build oficial) beta (x86_64)
Revisión 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839}
SO macOS Versión 11.7.3 (Fase 20G1116)

Case 1: Non Super-Referral - PASSED

Prerequisite: set Spanish as my preferred macOS language

Steps:

  1. installed 1.49.96
  2. launched with clean profile
  3. opened a new-tab page
  4. clicked on Personalizar
  5. background Image option in NTP customize should be visible regardless of language settings
Captura de Pantalla 2023-02-13 a la(s) 5 14 52 p  m

Case 2: Super-Referral - PASSED

Steps:

  1. removed pre-existing user profile
  2. created an empty user directory of ~/Library/Application Support/BraveBrowser/Brave-Browser-Beta/
  3. created a file called promocode (no file extension/ending) with the sole string TECHNIK and dropped it into the above folder
  4. launched Brave
  5. opened brave://components
  6. confirmed NTP Super Referrer (Technikke) and NTP Super Referrel Mapping Table were installed and up-to-date
  7. loaded new tab and check TECHNIK bg image is shown
  8. confirmed the Background Image option is not visible
  9. opened chrome://settings/appearance and went to the Theme submenu
  10. selected Brave default images
  11. opened a new-tab page
  12. clicked on Customize
  13. confirmed the Background Image options have returned

Confirmed the Background Image options have returned, and the background is from Brave backgrounds

example example example example example example
Screen Shot 2023-02-13 at 5 29 58 PM Screen Shot 2023-02-13 at 5 29 01 PM Screen Shot 2023-02-13 at 5 44 07 PM Screen Shot 2023-02-13 at 5 31 23 PM Screen Shot 2023-02-13 at 5 31 51 PM Screen Shot 2023-02-13 at 8 17 06 PM

@stephendonner stephendonner added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA/Test-Plan-Specified QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment