Add Copy Text from Image to image context menu (macOS)
#27513
Assignees
Labels
OS/Desktop
OS/macOS
priority/P3
The next thing for us to work on. It'll ride the trains.
QA Pass-macOS
QA/Test-Plan-Specified
QA/Yes
release-notes/include
Milestone
Comments
rebron
added
the
priority/P3
25 tasks
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Jan 6, 2023
fix brave/brave-browser#27513 "Copy Text From Image" entry is added to render view's context menu. It gets bitmap data from renderer via LocalFrame::GetImage() mojom interface, and then passed it to TextRecognitionDialog to extract and show text from that image.
simonhong
added a commit
to brave/brave-core
that referenced
this issue
Jan 13, 2023
fix brave/brave-browser#27513 "Copy Text From Image" entry is added to render view's context menu. It gets bitmap data from renderer via LocalFrame::GetImage() mojom interface, and then passed it to TextRecognitionDialog to extract and show text from that image.
Verified
|
| Brave | 1.49.96 Chromium: 110.0.5481.77 (Official Build) beta (x86_64) |
|---|---|
| Revision | 65ed616c6e8ee3fe0ad64fe83796c020644d42af-refs/branch-heads/5481@{#839} |
| OS | macOS Version 11.7.3 (Build 20G1116) |
Steps
- installed
1.49.96 - launched Brave
- loaded
search.brave.com - searched for various memes
- context-clicked on images with text
- chose
Copy Text from Image - compared the digested text is pretty close to the original text
- also tested using
images.google.com
Confirmed Copy Text From Image does pretty well with long text, punctuation marks, and at least one additional non-English language, Spanish
search.brave.com:
| example | example | example |
|---|---|---|
 |
 |
 |
search.google.com:
| example | example | example |
|---|---|---|
 |
 |
 |
|
|
|
Not working on my Brave V 1.49.120 - Windows 10 - x64 |
|
Same I'm also on windows 10 I don't see it working. Maybe it only works on Mac? |
I think so |
|
@uzuki7777 correct - only works on macOS at the moment I created #29003 to track |
rebron
changed the title
Copy Text From Image entry to image's context menuCopy Text from Image to image context menu (macOS)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add similar feature of FF's
Copy Text From Image.When select that entry, browser launches a dialog and that dialog contains text from image.
The text was updated successfully, but these errors were encountered: