Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Change "Unverified" text to "Connect" #27215

Closed
Miyayes opened this issue Dec 7, 2022 · 1 comment · Fixed by brave/brave-core#16345
Closed

[Android] Change "Unverified" text to "Connect" #27215

Miyayes opened this issue Dec 7, 2022 · 1 comment · Fixed by brave/brave-core#16345
Assignees
@deeppandya
Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/exclude
Milestone
1.48.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 7, 2022

Description

Android version of #27191
@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality labels Dec 7, 2022
@Miyayes Miyayes added the priority/P2 A bad problem. We might uplift this to the next planned release. label Dec 7, 2022
@Miyayes Miyayes changed the title [Android] Change "Unverified" text to "Connect account" [Android] Change "Unverified" text to "Connect" Dec 7, 2022
@deeppandya deeppandya mentioned this issue Dec 13, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 14, 2022
@stephendonner
Copy link

stephendonner commented Feb 1, 2023 •
edited
Loading

Verification PASSED using Brave 1.48.152, Chromium 109.0.5414.119 on a Google Pixel XL (arm64) running Android 9

Confirmed Unverified -> Connect on the default/disconnected states

New profile

  1. installed 1.48.152
  2. launched Brave
  3. switched to staging environment via QA Preferences menu
  4. relaunched
  5. tapped on the BAT icon
  6. tapped on Start using Brave Rewards
  7. tapped on Connect
  8. tapped on Uphold
  9. logged in to Uphold
default brave://rewards Rewards panel connected brave://rewards Rewards panel
Screenshot_20230201-005158 Screenshot_20230201-005210 Screenshot_20230201-005340 Screenshot_20230201-005357

Upgraded profile

  1. installed 1.47.161
  2. launched Brave
  3. switched to staging environment via QA Preferences menu
  4. relaunched
  5. tapped on the BAT icon
  6. tapped on Start using Brave Rewards
  7. accepted the ad grant of 30.000 BAT
  8. set a one-time tip, a monthly tip/contribution, and auto-contributions
  9. closed Brave
  10. installed 1.48.152
  11. ensured that the tips & contributions migrated over
  12. logged in to Uphold for good measure, since this is an upgrade
1.47.161 example example 1.48.152 example example
Screenshot_20230201-011327 (1) Screenshot_20230201-011217 Screenshot_20230201-011226 Screenshot_20230201-011450 Screenshot_20230201-011342 Screenshot_20230201-011353

1.47.161 (for reference)

Unverified brave://rewards Rewards panel Verified brave://rewards Rewards panel
Screenshot_20230305-001505 Screenshot_20230305-001532 Screenshot_20230305-002029 Screenshot_20230305-002051

This was referenced Feb 7, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
feature/rewards OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Update rewards text brave/brave-core
5 participants
@stephendonner @kjozwiak @deeppandya @Miyayes @brave-builds