Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "Unverified" text to "Connect" #27191

Closed
2 tasks
Miyayes opened this issue Dec 6, 2022 · 0 comments · Fixed by brave/brave-core#16280
Closed
2 tasks

Change "Unverified" text to "Connect" #27191

Miyayes opened this issue Dec 6, 2022 · 0 comments · Fixed by brave/brave-core#16280
Assignees
@zenparsing
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Milestone
1.48.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Dec 6, 2022 •
edited
Loading

  • When in grandfathered state, show "Connect" in Rewards panel state pill
  • When verified, show "Connected"

Update: "Connect account" is too long in the grandfathered structure, and will overflow. Especially on Android.
@Miyayes Miyayes added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. OS/Desktop labels Dec 6, 2022
@Miyayes Miyayes changed the title Change "Unverified" text "Connect account" Change "Unverified" text to "Connect account" Dec 6, 2022
@Miyayes Miyayes mentioned this issue Dec 7, 2022
Closed
@Miyayes Miyayes changed the title Change "Unverified" text to "Connect account" Change "Unverified" text to "Connect" Dec 7, 2022
@zenparsing zenparsing mentioned this issue Dec 7, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA/No release-notes/exclude
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Replace verified text with connected text in Rewards card brave/brave-core
3 participants
@zenparsing @Miyayes @brave-builds