-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add flow for no browser detected when onboarding #27170
Labels
onboarding
Front-end related to helping a new user learn about features within the browser.
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-macOS
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
rebron
added
onboarding
Front-end related to helping a new user learn about features within the browser.
priority/P2
A bad problem. We might uplift this to the next planned release.
release-notes/exclude
QA/No
QA/Yes
and removed
QA/No
labels
Dec 5, 2022
How confident are we in detecting that there is no settings to import? Is there a possibility of false negative? If there is a possibility, we may need to accommodate that use case, and allow manual operation. |
@jenn-rhim Fairly confident. I tested on a normal user's machine and encountered this case. |
25 tasks
7 tasks
The above requires |
Verified
|
Brave | 1.47.154 Chromium: 109.0.5414.46 (Official Build) beta (x86_64) |
---|---|
Revision | 6e36b77363ef3febbe792af680fa1367993ddcf0-refs/branch-heads/5414@{#709} |
OS | macOS Version 13.2 (a) (Build 22D7750270d) |
Original issue:
Prerequisites:
- removed all profile folders for various browsers, in
/Users/sdonner/Library/Application\ Support/
- removed
Opera's
com.operasoftware.Opera
file object in the above, top-level - ran the
Reset Safari Using Terminal
section fromhttps://www.makeuseof.com/reset-safari-default-mac/
line-by-line:
mv ~/Library/Safari ~/Desktop/Safari-`date +%Y%m%d%H%M%S`;
rm -Rf ~/Library/Cache/*;
rm -Rf ~/Library/Caches/Apple\ -\ Safari\ -\ Safari\ Extensions\ Gallery;
rm -Rf ~/Library/Caches/Metadata/Safari;
rm -Rf ~/Library/Caches/com.apple.Safari;
rm -Rf ~/Library/Caches/com.apple.WebKit.PluginProcess;
rm -Rf ~/Library/Cookies/*;
rm -Rf ~/Library/Cookies/Cookies.binarycookies;
rm -Rf ~/Library/Preferences/Apple\ -\ Safari\ -\ Safari\ Extensions\ Gallery;
rm -Rf ~/Library/Preferences/com.apple.Safari.LSSharedFileList.plist;
rm -Rf ~/Library/Preferences/com.apple.Safari.RSS.plist;
rm -Rf ~/Library/Preferences/com.apple.Safari.plist;
rm -Rf ~/Library/Preferences/com.apple.WebFoundation.plist;
rm -Rf ~/Library/Preferences/com.apple.WebKit.PluginHost.plist;
rm -Rf ~/Library/Preferences/com.apple.WebKit.PluginProcess.plist;
rm -Rf ~/Library/PubSub/Database;
rm -Rf ~/Library/Safari/*;
rm -Rf ~/Library/Safari/Bookmarks.plist;
rm -Rf ~/Library/Saved\ Application\ State/com.apple.Safari.savedState;
Case 1: Dynamic auto-mode selection with Match system setting
selected - PASSED
Brave, Dark (Auto) |
macOS, Dark |
Brave, Light (Auto) |
macOS, Light |
---|---|---|---|
Confirmed setting Match system setting
dynamically follows the selected Light
or Dark
macOS theme setting
Case 2: Override the OS setting via Light mode
and Dark mode
- PASSED
Brave, Dark |
macOS, Light |
Brave, Light |
macOS, Dark |
---|---|---|---|
Confirmed the Brave setting overrides the macOS
system setting
Case 3: Skip
, then Finish
on Choose your theme
defaults pref to same as macOS
- PASSED
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
onboarding
Front-end related to helping a new user learn about features within the browser.
OS/Desktop
priority/P2
A bad problem. We might uplift this to the next planned release.
QA Pass-macOS
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Description
If no browsers are detected during the onboarding v2 import flow, show the
Choose your theme
screen. Default to match system setting. When selecting dark mode, change background of buttons to reflect dark mode choice.Steps to reproduce:
Actual result:
Expected result:
https://www.figma.com/file/MFHpcXJMg2RUQpUJMAZZ4R/Desktop-Onboarding?node-id=3325%3A42022&t=LEYjscmyx6nVbe4p-0
Reproduces how often:
Easily.
Brave version (brave://version info)
1.47.x
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
The text was updated successfully, but these errors were encountered: