Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make pinned tabs laid out in a grid when it's vertical tab strip #27066

Closed
Tracked by #24717
sangwoo108 opened this issue Nov 30, 2022 · 0 comments · Fixed by brave/brave-core#16165
Closed
Tracked by #24717

Make pinned tabs laid out in a grid when it's vertical tab strip #27066

sangwoo108 opened this issue Nov 30, 2022 · 0 comments · Fixed by brave/brave-core#16165
Assignees
@sangwoo108
Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.48.x - Release

Comments

@sangwoo108
Copy link

No description provided.

@sangwoo108 sangwoo108 mentioned this issue Nov 30, 2022
Closed
26 tasks
@sangwoo108 sangwoo108 self-assigned this Nov 30, 2022
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude feature/vertical-tabs labels Nov 30, 2022
@sangwoo108 sangwoo108 changed the title Make pinned tabs laid out in a grid Make pinned tabs laid out in a grid when it's vertical tab strip Nov 30, 2022
@sangwoo108 sangwoo108 mentioned this issue Nov 30, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.48.x - Nightly milestone Dec 17, 2022
simonhong added a commit to brave/brave-core that referenced this issue Dec 17, 2022
@simonhong
Fixed build failure from vertical tab PR with cr109
6a814d8 
f/u PR for #16165

issue: brave/brave-browser#27066
@simonhong simonhong mentioned this issue Dec 17, 2022
Merged
25 tasks
mihaiplesa pushed a commit to brave/brave-core that referenced this issue Dec 17, 2022
@simonhong
Fixed build failure from vertical tab PR with cr109 (#16394)
bb9bb2a 
f/u PR for #16165

issue: brave/brave-browser#27066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/vertical-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.48.x - Release
Development

Successfully merging a pull request may close this issue.

Split pinned tabs and non-pinned tabs area for vertical tab strip brave/brave-core
2 participants
@sangwoo108 @brave-builds