-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chromium icons: in url bar; bookmark this page. #2641
Labels
misc/icons
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
Milestone
Comments
bbondy
added
the
priority/P1
A very extremely bad problem. We might push a hotfix for it.
label
Dec 20, 2018
thanks for posting, nice find. |
Reproduced with Beta channel 0.59.12 cc @rebron for visibility |
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
Dec 22, 2018
Chromium. Also, relocated settings.icon to chrome/app. Fixes brave/brave-browser#2641
Removing uplift-request flag. Should be with the pr not the issue. |
Verification passed on
Verification passed on Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit) Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
misc/icons
priority/P1
A very extremely bad problem. We might push a hotfix for it.
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Test-Plan-Specified
QA/Yes
release-notes/exclude
The fresh master branch based on Chromium 72 has the icon of Chromium in url bar instead of Brave's icon; star for 'Bookmark this page' instead of
Description
Steps to Reproduce
Actual result:
Expected result:
Reproduces how often:
Easy
Brave version (brave://version info)
Reproducible on current release:
hadn't tried
The text was updated successfully, but these errors were encountered: