Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium icons: in url bar; bookmark this page. #2641

Closed
AlexeyBarabash opened this issue Dec 19, 2018 · 5 comments · Fixed by brave/brave-core#1180
Closed

Chromium icons: in url bar; bookmark this page. #2641

AlexeyBarabash opened this issue Dec 19, 2018 · 5 comments · Fixed by brave/brave-core#1180

Comments

@AlexeyBarabash
Copy link
Contributor

The fresh master branch based on Chromium 72 has the icon of Chromium in url bar instead of Brave's icon; star for 'Bookmark this page' instead of image

Description

Steps to Reproduce

  1. Open chrome://bookmarks/

Actual result:

  1. See the icon of Chromium

image

Expected result:

  1. Icon looks like before in Chromium 71 based builds
    image

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.61.0 Chromium: 72.0.3626.17 (Developer Build) (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    hadn't tried
@bbondy bbondy added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Dec 20, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Dec 20, 2018
@bbondy
Copy link
Member

bbondy commented Dec 20, 2018

thanks for posting, nice find.

@rossmoody rossmoody self-assigned this Dec 20, 2018
@cndouglas
Copy link
Contributor

Also happens with Brave 0.60.4 dev:

@LaurenWags
Copy link
Member

LaurenWags commented Dec 21, 2018

Reproduced with Beta channel 0.59.12
screen shot 2018-12-21 at 1 33 40 pm

cc @rebron for visibility

@rebron
Copy link
Collaborator

rebron commented Dec 22, 2018

Removing uplift-request flag. Should be with the pr not the issue.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 29, 2018

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Windows
  • Verified the STR mentioned in description
    image

Verification passed on

Brave 0.59.13 Chromium: 72.0.3626.28 (Official Build) beta (64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

  • Verified the STR mentioned in description
    image

Verified passed with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants