Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload device tile do not show same image as the background when Dashboard closed re-opened #26335

Closed
MadhaviSeelam opened this issue Oct 28, 2022 · 4 comments · Fixed by brave/brave-core#15796
Assignees
Labels
bug feature/new-tab needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude

Comments

@MadhaviSeelam
Copy link

Description

Not sure if this is expected but I am expecting Upload from device tile image should match to the image on the background when Dashboard opened

Steps to Reproduce

  1. Install 1.46.81
  2. launch Brave
  3. click Customize
  4. click Upload from device
  5. upload few custom images
  6. close and reopen Dashboard

Actual result:

Upload from device tile shows grey

step 5 result
image image

Expected result:

Expected the Upload from device tile image match to the background image

Reproduces how often:

Easily

Brave version (brave://version info)

Brave | 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Version/Channel Information:

  • Can you reproduce this issue with the current release? N/A
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@sangwoo108 @rebron

@MadhaviSeelam MadhaviSeelam changed the title Upload device tile do not show same image as the background when Dashboard opened Upload device tile do not show same image as the background when Dashboard closed re-opened Oct 28, 2022
@sangwoo108
Copy link

@rebron @aguscruiz I'd like to hear about this. I thought it'd be more recognizable with the upload icon than the acutal image that was chosen. What do you think?

@sangwoo108 sangwoo108 self-assigned this Oct 28, 2022
@sangwoo108 sangwoo108 added the needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. label Oct 28, 2022
@aguscruiz
Copy link

@sangwoo108
Copy link

sangwoo108 commented Nov 4, 2022

When has no image

image

When has 1 image

image

When has 2 images

image

When has 3 images

image

When has 4 >= images

image

@MadhaviSeelam
Copy link
Author

MadhaviSeelam commented Dec 14, 2022

Verification PASSED using

Brave | 1.47.126 Chromium: 108.0.5359.99 (Official Build) beta (64-bit)
-- | --
Revision | 410951fc34bb4b2cbf182231f9f779efaafaf682-refs/branch-heads/5359_71@{#9}
OS | Windows 11 Version 21H2 (Build 22000.1219)
  • Install 1.46.81
  • launch Brave

Case 1: No custom images are available - PASSED

  • click Customize in a new-tab
  • do not upload any images

Confirmed Upload from device icon is available in the Customize Dashboard when no custom images are available

image

Case 2: Single custom image - PASSED

  1. continue from Case 1:
    • No custom images are available in the Customize Dashboard
  2. click Upload from device tile
  3. Upload a single custom image
  4. click on the image in the Use your own tile
  5. uploaded image thumbnail along with Upload from device tile are displayed
  6. click Use your own
  7. close the dashboard and reopen

Confirmed a single custom image is displayed in the Use your own tile in the Customize Dashboard

step 1 step5 result
image image image

Case 3: Two custom images - PASSED

  1. Continue from Case 2:
    • a single image already uploaded
    • Upload from device tile is available
  2. click Upload from device tile
  3. upload an image
  4. click on the image in the Use your own tile
  5. both uploaded image thumbnails along with Upload from device tile are displayed
  6. click Use your own
  7. close the dashboard and reopen

Confirmed both images are shown in the Use your own tile in the Customize Dashboard

step 1 step 5 result
image image image

Case 4: Three custom images - PASSED

  1. Continue from Case 3:
    • two images already uploaded
    • Upload from device tile is available
  2. click Upload from device tile
  3. upload an image
  4. click on the image in the Use your own tile
  5. all three uploaded image thumbnails along with Upload from device tile are displayed
  6. click Use your own
  7. close the dashboard and reopen

Confirmed all three images are shown in the Use your own tile in the Customize Dashboard

step 1 step 5 result
image image image

Case 5: Four images - PASSED

  1. Continue from Case 4:
    • three images already uploaded
    • Upload from device tile is available
  2. click Upload from device tile
  3. upload an image
  4. click on the image in the Use your own tile
  5. all four uploaded image thumbnails along with Upload from device tile are displayed
  6. click Use your own
  7. close the dashboard and reopen

Confirmed all four images are shown in the Use your own tile in the Customize Dashboard

step 1 step 5 result
image image image

Case 6: Five custom images - PASSED

  1. Continue from Case 5:
    • four images already uploaded
    • Upload from device tile is available
  2. click Upload from device tile
  3. upload an image
  4. all five uploaded image thumbnails along with Upload from device tile are displayed
  5. click Use your own
  6. close the dashboard and reopen

Confirmed only at most four images are shown in the Use your own tile in the Customize Dashboard

Confirmed all five images are shown after closing and reopening dashboard

step 1 step 5 result result
image image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/new-tab needs-discussion Although the issue is clear, we haven't yet reached a decision about the right solution. OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants