Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for multiple custom images for NTP background images #25761

Closed
sangwoo108 opened this issue Oct 2, 2022 · 2 comments · Fixed by brave/brave-core#15311
Closed

Add support for multiple custom images for NTP background images #25761

sangwoo108 opened this issue Oct 2, 2022 · 2 comments · Fixed by brave/brave-core#15311
Assignees
@sangwoo108
Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.46.x - Release

Comments

@sangwoo108
Copy link

This is a subtask of #15252

Users should be able to upload multiple images for their NTP background.
@sangwoo108 sangwoo108 added feature/new-tab priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Desktop labels Oct 2, 2022
@sangwoo108 sangwoo108 self-assigned this Oct 2, 2022
@sangwoo108 sangwoo108 mentioned this issue Oct 2, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.46.x - Nightly milestone Oct 4, 2022
@rebron rebron mentioned this issue Oct 4, 2022
Closed
4 tasks
@MadhaviSeelam
Copy link

MadhaviSeelam commented Oct 27, 2022 •
edited
Loading

Verification PASSED using

Brave | 1.46.81 Chromium: 107.0.5304.68 (Official Build) beta (64-bit)
-- | --
Revision | a4e93e89d3b3df1be22214603fba846ad0183ca5-refs/branch-heads/5304@{#991}
OS | Windows 11 Version 21H2 (Build 22000.1098)

Pre-requisites: Have few images available in a directory

Case 1: Upload a single image in the very first tab

  1. Install 1.46.81
  2. launch Brave
  3. click Skip welcome tour
  4. click Customize
  5. Click Upload from device in Use your own tile
  6. select an image from the directory (eg. Downloads)-->open
  7. Uploaded image is shown as the background
  8. click the Upload from device again to show the image

Confirmed image is uploaded successfully and shown for NTP background

step 5 step 6 step 7 step8 step 8a
image image image image image

Case 2: Users should be able to upload multiple images in NTP

  1. new profile
  2. launch Brave
  3. open NTP
  4. click Customize
  5. Click Upload from device in Use your own tile
  6. select an image from the directory (eg. Downloads)-->open
  7. Uploaded image is shown as the background
  8. click the Upload from device again to show the image
  9. continue to upload images
  10. Able to upload only 24 images as blank Upload from device tile was not available
  11. click on each of the uploaded images

Confirmed all of the images are uploaded successfully and are shown for NTP background

step 5 step 6 step7 step 8 step 9 Image 1 Image 2 Image 3
image image image image image image image image

Case 3: When user toggle on random button, one of these images should appear on NTP randomly.

  1. Continue from Case 2
    • custom images are uploaded
  2. toggle ON Refresh on ever new tab
  3. Refresh the tab (Ctrl+R)

Confirmed custom images randomly loaded

step 1 step 2 step 3 results
image image image image

Case 4: Users should be able to remove these images

  1. continue from Case 3
    • custom images are uploaded
  2. click Customize
  3. click Upload from device
  4. click x on an image

Confirmed image is removed

step 4 result 1 result 2
image image image

Case 5: a file name has other characters than alphabet, it should be uploaded.

1.new profile
2. launch Brave
3. open NTP
4. click Customize
5. Click Upload from device in Use your own tile
6. select an image (custom139#@$#$$###2323image) from the directory (eg. Downloads)-->open
7. click Upload from device again

Confirmed image loaded successfully

step 6 step 7 image image
image image image image

Bugs filed:

@stephendonner
Copy link

stephendonner commented Oct 31, 2022 •
edited by btlechowski
Loading

Verification IN-PROGRESS using

Brave 1.46.86 Chromium: 107.0.5304.91 (Official Build) beta (x86_64)
Revision 3d5948960d62418160796d5831a4d2d7d6c90fa8-refs/branch-heads/5304@{#1097}
OS macOS Version 11.7.1 (Build 20G918)

Prerequisite: have 15+ images handy

Case 1: Upload a single image in the 1st tab - PASSED

  1. installed 1.46.86
  2. launch Brave
  3. click Skip welcome tour
  4. click Customize
  5. click Upload from device in Use your own tile
  6. select an image from the directory (e.g. Downloads)--> Open
  7. uploaded image is shown as the background
  8. click Upload from device again to show the image

Confirmed image is uploaded successfully and shown for NTP background

step 5 step 6 step 7 step 8a step 8b
Screen Shot 2022-10-31 at 2 47 46 PM Screen Shot 2022-10-31 at 2 48 06 PM Screen Shot 2022-10-31 at 2 48 19 PM Screen Shot 2022-10-31 at 2 48 28 PM Screen Shot 2022-10-31 at 2 48 37 PM

Case 2: Users should be able to upload multiple images in new-tab page - PASSED

  1. install 1.46.86
  2. launch Brave
  3. open new-tab page
  4. click Customize
  5. click Upload from device in Use your own tile
  6. select an image from the directory (e.g. Downloads) --> Open
  7. uploaded image is shown as the background
  8. click the Upload from device again to show the image
  9. continue to upload images
  10. able to upload only 24 images as blank Upload from device tile was not available
  11. click on each of the uploaded images

Confirmed all of the images are uploaded successfully and are shown for NTP background

step 5 step 6 step 8 step 9 image 1 image 2 image 3
Screen Shot 2022-10-31 at 3 09 30 PM Screen Shot 2022-10-31 at 3 09 39 PM Screen Shot 2022-10-31 at 3 09 52 PM Screen Shot 2022-10-31 at 3 06 09 PM Screen Shot 2022-10-31 at 3 07 30 PM Screen Shot 2022-10-31 at 3 07 33 PM Screen Shot 2022-10-31 at 3 07 53 PM

Case 3: Toggling Refresh on every new tab should cycle through images - PASSED

  1. continue from Case 2
  2. custom images are uploaded
  3. toggle ON Refresh on every new tab
  4. refresh the tab / open a new tab

Confirmed custom images loaded randomly with each refresh/new-tab page

step 1 step 2 step 3 results
Screen Shot 2022-10-31 at 3 16 22 PM Screen Shot 2022-10-31 at 3 16 28 PM Screen Shot 2022-10-31 at 3 18 20 PM Screen Shot 2022-10-31 at 3 18 34 PM

Case 4: Users should be able to remove custom-background images - PASSED

  1. continue from Case 3
  2. custom images are uploaded
  3. click Customize
  4. click Upload from device
  5. click x on an image

Confirmed I was able to remove each and every custom-uploaded image

step 4 result 1 result 2 result 3
Screen Shot 2022-10-31 at 3 21 22 PM Screen Shot 2022-10-31 at 3 21 27 PM Screen Shot 2022-10-31 at 3 21 34 PM Screen Shot 2022-10-31 at 3 22 07 PM

Case 5: filename with non-alphanumeric characters - PASSED

  1. install 1.46.86
  2. launch Brave
  3. open new-tab page
  4. click Customize
  5. Click Upload from device in Use your own tile
  6. select an image (crazy-filename-!@#";.jpg) from the directory (e.g. Downloads) --> Open
  7. click Upload from device again
step 6 step 7 image image
Screen Shot 2022-10-31 at 3 35 56 PM Screen Shot 2022-10-31 at 3 36 12 PM Screen Shot 2022-10-31 at 3 42 55 PM Screen Shot 2022-10-31 at 3 38 01 PM

Verification passed on

Brave 1.46.117 Chromium: 107.0.5304.110 (Official Build) beta (64-bit)
Revision 2a558545ab7e6fb8177002bf44d4fc1717cb2998-refs/branch-heads/5304@{#1202}
OS Ubuntu 18.04 LTS

Pre-requisites: Have few images available in a directory

Case 1: Upload a single image in the very first tab

  1. Install 1.46.81
  2. launch Brave
  3. click Skip welcome tour
  4. click Customize
  5. Click Upload from device in Use your own tile
  6. select an image from the directory (eg. Downloads)-->open
  7. Uploaded image is shown as the background
  8. click the Upload from device again to show the image

Confirmed image is uploaded successfully and shown for NTP background

image

Case 2: Users should be able to upload multiple images in NTP

  1. new profile
  2. launch Brave
  3. open NTP
  4. click Customize
  5. Click Upload from device in Use your own tile
  6. select an image from the directory (eg. Downloads)-->open
  7. Uploaded image is shown as the background
  8. click the Upload from device again to show the image
  9. continue to upload images
  10. Able to upload only 24 images as blank Upload from device tile was not available
  11. click on each of the uploaded images

Confirmed all of the images are uploaded successfully and are shown for NTP background

image
image

Case 3: When user toggle on random button, one of these images should appear on NTP randomly.

  1. Continue from Case 2
    • custom images are uploaded
  2. toggle ON Refresh on ever new tab
  3. Refresh the tab (Ctrl+R)

Confirmed custom images randomly loaded

image
image
image

Case 4: Users should be able to remove these images

  1. continue from Case 3
    • custom images are uploaded
  2. click Customize
  3. click Upload from device
  4. click x on an image

Confirmed image is removed

image
image

Case 5: a file name has other characters than alphabet, it should be uploaded.

1.new profile
2. launch Brave
3. open NTP
4. click Customize
5. Click Upload from device in Use your own tile
6. select an image from the directory (eg. Downloads)-->open
7. click Upload from device again

Confirmed image loaded successfully

image
image
image

@LaurenWags LaurenWags mentioned this issue Nov 30, 2022
Closed
@rebron rebron changed the title Support to multiple custom images for NTP background Add support for multiple custom images for their NTP background Nov 30, 2022
@rebron rebron changed the title Add support for multiple custom images for their NTP background Add support for multiple custom images for NTP background images Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/new-tab OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.46.x - Release
Development

Successfully merging a pull request may close this issue.

Support to upload multiple custom images for NTP background brave/brave-core
6 participants
@stephendonner @sangwoo108 @LaurenWags @btlechowski @brave-builds @MadhaviSeelam